Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 06 17:32
    armanbilge closed #6851
  • Dec 06 17:24

    github-actions[bot] on gh-pages

    deploy: 2c034f6e72ff5524e124fbb… (compare)

  • Dec 06 17:13
    danicheg closed #6853
  • Dec 06 17:13

    danicheg on 0.23

    Add default case and test Merge pull request #6853 from m… (compare)

  • Dec 06 17:06
    armanbilge commented #6852
  • Dec 06 17:05

    github-actions[bot] on gh-pages

    deploy: c2166c6b132b6d98eb26ef6… (compare)

  • Dec 06 17:05
    armanbilge commented #6852
  • Dec 06 16:59

    armanbilge on 0.23

    Add fs2-data to integrations do… Merge pull request #6850 from y… (compare)

  • Dec 06 16:59
    armanbilge closed #6850
  • Dec 06 14:17
    mattyjbrown commented #6853
  • Dec 06 14:15
    mattyjbrown commented #6851
  • Dec 06 14:10
    mergify[bot] labeled #6853
  • Dec 06 14:10
    mergify[bot] labeled #6853
  • Dec 06 14:10
    mattyjbrown edited #6853
  • Dec 06 14:09
    mattyjbrown opened #6853
  • Dec 06 14:05
  • Dec 06 11:25
    TimWSpence synchronize #6852
  • Dec 06 11:06
    mergify[bot] labeled #6852
  • Dec 06 11:06
    mergify[bot] labeled #6852
  • Dec 06 11:05
    TimWSpence opened #6852
Rob Norris
@tpolecat
Ok
Christopher Davenport
@ChristopherDavenport
You may want to include the original headers.
Rob Norris
@tpolecat
How do I do that?
Christopher Davenport
@ChristopherDavenport
POST(json, uri).map(req => req.withHeaders(req.headers |+| myHeaders)) if you are on the newer stuff
_.putHeaders does what you want though, assoming you are ok with the eta expansion.
Rob Norris
@tpolecat
That fixed it, thanks.
Rob Norris
@tpolecat
Man, this ConcurrentEffect thing is really bringing me down.
Michael Pilquist
@mpilquist
lol
Rob Norris
@tpolecat
Do you think we could replace this with imperative code that just uses reactive streams instead of hopping into fs2?
Well I guess the response needs a stream doesn't it.
bah
I'll see if the ember client works.
Forked!
Rob Norris
@tpolecat
Aaaaaaaaand it works!
Gavin Bisesi
@Daenyth
:parrots:
Billzabob
@Billzabob
I’m really sad that emote doesn’t work in Gitter :(
Gavin Bisesi
@Daenyth
indeed
Christopher Davenport
@ChristopherDavenport
Woot! Ember to the rescue
Rob Norris
@tpolecat
Do you have a sense for how close it is to being ready for prime time?
Works fine in my dinky experiment.
Christopher Davenport
@ChristopherDavenport
The client is pretty ok, there seems to be some issues with chunked encoding I haven’t pinned down. The server connection reuse is the part I have horribly wrong presently.
For most use cases the client as written is probably good to go.
I put a lot of work into that pool, so it should be mostly useful. :laughing:
Rob Norris
@tpolecat
Neato.
In the meantime blaze and async-http can hang their heads in shame.
We need to rename it CursedMinusTwoConcurrentEffectOfSuffering
Christopher Davenport
@ChristopherDavenport
Catchy name for a client.
Rob Norris
@tpolecat
I should quit while I'm ahead and turn the computer off.
Christopher Davenport
@ChristopherDavenport
That’s the spirit!
I’ll try to cut a release tonight, I want to remove server connection reuse temporarily as I don’t like having broken code in the mainline.
Rob Norris
@tpolecat
I didn't look at the server part. It's possible that can be weakened too.
Christopher Davenport
@ChristopherDavenport
Already took care of it. :smile:
If ember doesn’t suit your needs let me know and I’ll do my best, either here or in ChristopherDavenport/libraries
Rob Norris
@tpolecat
:+1:
Christopher Davenport
@ChristopherDavenport
Bits are migrating now, so you can rely on a real artifact.
Rob Norris
@tpolecat
No worries, it's just a throwaway thing right now.
Just trying to get distributed tracing to actually distribute. It works, so I'm good.
Christopher Davenport
@ChristopherDavenport
I'm excited, it's the only client that doesn't require effect, which means pure throughout.
Rob Norris
@tpolecat
Right. Skunk too, for the same reason.
Carlos Quiroz
@cquiroz
Could you explain that a bit for newbies
Do you mean the Effect type class?
Rob Norris
@tpolecat
yes, the blaze and async-http clients have an Effect constraint
so this means your F[A] can't be Kleisli[G, E, A] because you need an E before you have any hope of getting an A out, so you can't write Kleisli[G, E, A] => A which is basically what Effect is.
So the "reader" effect is incompatible with Effect. You can never have both.
So. Getting rid of an Effect constraint is a big deal.
Ross A. Baker
@rossabaker
I tried, but I can't remember if I tried since cats-effect-1.
I guess ember gets away with it by being one big stream? I think the problem is the request has to be an end of the world in most backends.
Rob Norris
@tpolecat
I guess it comes down to the particulars. fs2 does nio sockets without Effect.
Michael Pilquist
@mpilquist
Oh hey, I spent my Friday evening on this: functional-streams-for-scala/fs2#1497