Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 18 16:22
    drewmullen commented #526
  • Sep 18 16:16
    drewmullen commented #526
  • Sep 18 16:13
    drewmullen commented #526
  • Sep 18 16:12
    drewmullen commented #526
  • Sep 18 16:12
    drewmullen commented #526
  • Sep 18 15:56
    drewmullen commented #526
  • Sep 18 15:25
    LikoV2 opened #526
  • Sep 18 13:21
    codecov-io commented #525
  • Sep 18 13:20
    codecov-io commented #525
  • Sep 18 13:20
    codecov-io commented #525
  • Sep 18 13:19
    codecov-io commented #525
  • Sep 18 13:19
    Travis hvac/hvac#525 passed (1414)
  • Sep 18 13:11
    update-docs[bot] commented #525
  • Sep 18 13:11
    tom-dierckx review_requested #525
  • Sep 18 13:11
    tom-dierckx opened #525
  • Sep 16 15:28
    Travis hvac/hvac (develop) passed (1413)
  • Sep 16 15:21

    drewmullen on develop

    Doc updates (#524) * fix list … (compare)

  • Sep 16 15:21
    drewmullen closed #524
  • Sep 16 15:21
    drewmullen commented #524
  • Sep 16 15:06
    Travis hvac/hvac#524 passed (1412)
drewmullen
@drewmullen
appreciate you bringing it up and explaining!
semrov
@semrov
Adis Cesir
@acesir
just downloaded the hvac client yesterday and running into an issue. We run Vault in kubernetes with auto-unseal via aws kms. When I refactored our code for unsealing from running vault operator init -recovery-shares=1 -recovery-threshold=1 -> to using hvac with vault_client.sys.initialize(1, 1) it does not seem to work
continuously get this error: recovery configuration must specify a positive number of shares
vault is running in HA mode with 3 replicas
our storage backend for vault is postgres
drewmullen
@drewmullen
try specifying the values your setting. it may be defautling to secret_shares and secret_threshold
Instead say
vault_client.sys.initialize(recovery_shares=1, recovery_threshold =1)
Adis Cesir
@acesir
you are correct, strange, I even inspected the parameter order in the function but it would not take them in correct order
yeah i always go straight to source
if you saw it incorrectly ordered in the docs lmk and we can update
:) glad its working for you!
might have miss-understood this section but the initialize section seemed to imply they are the first 2 params in order
drewmullen
@drewmullen
Yeah, that looks wrong to me too
thanks for pointing that out!
Adis Cesir
@acesir
interestingly enough even inside PyCharm it shows those 2 first when inspecting the function
yep, great client btw, i was parsing yaml until i found it =/
drewmullen
@drewmullen
glad its helpful to you! ive been using it to write ansible functions primarily (back to yaml lol)
Adis Cesir
@acesir
ugh lol
drewmullen
@drewmullen
:)
Jeffrey Hogan
@jeffwecan
FYI gonna try to get some
of the recent issues triaged this weekend 🤙
drewmullen
@drewmullen
hashiconf next week!
thats typically what i do when im traveling too, open source work
drewmullen
@drewmullen
@jeffwecan apparently i can commit directly to develop hvac/hvac@b2940d6 . i thought my git config was set to default to my fork but apparently not
drewmullen
@drewmullen
im thinking thats probably on purpose and ijust need to be more careful - sorry about that
Jeffrey Hogan
@jeffwecan
lol whoops
I suppose we can bypass the branch protection since the "Include Administrators" option isn't checked
looks like you could maybe just back those commits out though?:
git checkout develop
git reset --hard 43ce194603d7bff84d4f219b93210778800aac89
git push --force [...]
drewmullen
@drewmullen
To https://github.com/hvac/hvac.git
 ! [remote rejected] develop -> develop (protected branch hook declined)
error: failed to push some refs to 'https://github.com/hvac/hvac.git
did you enable protection?
Jeffrey Hogan
@jeffwecan
I made no changes there
I suppose a force push hits some other setting?
drewmullen
@drewmullen
most likely
Jeffrey Hogan
@jeffwecan
toggled it off briefly, try again now?
drewmullen
@drewmullen
done
ty
sorry about that...
D:
Jeffrey Hogan
@jeffwecan
np! if it makes you feel better, I've only done that about 15 times ;P
probably should read up more on github's branch protection settings since I'm clearly missing something :shrug:
drewmullen
@drewmullen
hmm so do i have to rebase my changes against this new forced history?
*adds to long list of todos
Jeffrey Hogan
@jeffwecan
I would assume you can just reset back to your last commit on a different branch?
since you force pushed to an extant commit, I think your commits are still properly based on develop proper
drewmullen
@drewmullen
before i reset i created a new branch and pushed to my fork
ill open a pr against dev and see if it barfs