Yasir via telegram
Hi! I have a question. When we do batch transactions in python, we do batch meta by iroha.batch([tx1,tx2],atomic=True)
This iroha instance is based on only 1 user however documentation says that batches can have transactions from different users. So how would this work in that case?
Sara via telegram
That's one thing.
Another is the general way batches are made:
1) txs - transactions - can be made by different users, that's definitely not an issue
2) you create unsigned transactions by different users
3) add them batchmeta (basically making them a batch)
4) sign them with the respective signatures of the creator users - transaction by Alice with Alice's key, Bob's transaction with Bob's key etc
5) send the signed transactions together to listTorii
That's the general concept
baziorek via telegram
True, he has two Approves for PR: hyperledger/iroha#1300 from two members from Iroha Core Team, so should he correct something more in the PR, or it can be merged?
His work, according to the project description: https://wiki.hyperledger.org/display/INTERN/Extend+HL+Iroha+queries+with+optional+arguments is to extend:
After merging the PR it looks like his work for Iroha 1 Core would be finished (his work was to extend GetAccountTransactions
, GetAccountAssetTransactions
and GetPendingTransactions
for Postgres and RocksDB. The remaining parts would be to merge PR to Iroha client libraries: python, java, nodeJS, iOS
CC: @liralemur
baziorek via telegram
True, he has two Approves for PR: hyperledger/iroha#1300 from two members from Iroha Core Team, so should he correct something more in the PR, or it can be merged?
His work, according to the project description: https://wiki.hyperledger.org/display/INTERN/Extend+HL+Iroha+queries+with+optional+arguments is to extend:
GetAccountTransactions
2.GetAccountAssetTransactions
`1 and 2 was already merged for Postgres, and it looks like Iroha Core Team used the code for RocksDB, so it done. The last missing part for Iroha Core Code is the PR #1300, which is already approved. So after merging the only missing parts would be to merge PRs for Iroha client libraries: python, java, nodeJS, iOS (PRs for python, nodeJS and ready to merge).
After that he would finish entire internship project, so the question for Iroha 2 team - should be something connected with the internship project (filtering transactions by time range) added to Iroha 2?
CC: @liralemur