Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:51
    JustCallMeDev starred BrighterCommand/Brighter
  • Jan 22 22:20
    iancooper synchronize #1351
  • Jan 22 22:20

    iancooper on improve_kafka

    Improved offset and commit hand… Don't add the broker directory Don't add the zookeeper directo… (compare)

  • Jan 22 03:20
    Shawn-Fan commented #1273
  • Jan 22 02:47
    Shawn-Fan commented #1273
  • Jan 21 20:46
    iancooper commented #1101
  • Jan 21 20:46
    iancooper closed #1101
  • Jan 21 20:45
    iancooper commented #1273
  • Jan 20 17:40
    Shawn-Fan commented #1273
  • Jan 19 09:30
    iancooper labeled #1273
  • Jan 19 09:30
    iancooper unlabeled #1273
  • Jan 19 09:30
    iancooper labeled #1273
  • Jan 19 09:30
    iancooper commented #1273
  • Jan 19 06:41
    Shawn-Fan commented #1273
  • Jan 18 13:14
    willemodendaal starred BrighterCommand/Brighter
  • Jan 18 05:24
    dependabot[bot] labeled #1368
  • Jan 18 05:24
    dependabot[bot] review_requested #1368
  • Jan 18 05:24
    dependabot[bot] review_requested #1368
  • Jan 18 05:24
    dependabot[bot] review_requested #1368
  • Jan 18 05:24
    dependabot[bot] opened #1368
Ian Cooper
@iancooper
@domenicomusto Do you think we could get a shout out on Twitter! It would help with adoption. Do you think we might be able to add you guys to a corporate logo page. We don't have one yet, but when we do we could slap Huddle and justgiving there
Domenico
@domenicomusto
@iancooper I can't authorize it, but let me check with my CTO
I'll let you know
Ian Cooper
@iancooper
@domenicomusto Cheers
Domenico
@domenicomusto
guys is there any .net 4 version of brighter ?
Ian Cooper
@iancooper
Nothing official. I guess you would have to fork and rebuild with .net 4 on the fork. Biggest issue would be the dependency chain, as I don't think we use much 4.5 code like async/await
So to switch a fork to .NET 4 main work would be to get the dependencies right.
I'm good with supporting 1 .NET version back on a branch, but I'd think when 5 is released, that once we support 5, we would drop support for 4, and consider 4.5 our "1 back" version.
Domenico
@domenicomusto
I see
Ian Cooper
@iancooper
It wouldn't mean we kill 4, just that we wouldn't want to take on the workload of supporting both that and 4.5. No problem with someone else maintaining that on a fork. I just think it's a lot to ask, and only supporting one legacy version is industry standard for software
But yes, I was talking to someone here who was mentioning that they have just gone to 4, and are just forming 4.5 plans, so they are quite a way from 5.
Yiannis
@yiannistri
hey guys, I've opened a PR #102 it's basically a change to requeue a message to a specific queue as opposed to a topic (that many queues can be bound against)
review and comments are welcome :smile:
Ian Cooper
@iancooper
@yiannistri Yeah that got mentioned. Makes sense as it stops us broadcasting on a requeue
Don't think @holytshirt or I can review b4 tomorrow. Ask @ianbattersby?
Ian Battersby
@ianbattersby
@penderi Any thoughts on these raven messages before I dig in? https://ci.appveyor.com/project/IanCooper/paramore. Needless to say they pass locally.
Ian Cooper
@iancooper
Hi guys. I was going to switch the sample file to SQLCE today. We use that for the main Db anyway and our SQL provider supports it. So I killed Raven. Was hoping to tackle it during sessions today, but if not might take me a little longer. Raven is just trouble, so swapping to SQLCE seems more robust
Ian Battersby
@ianbattersby
:clap:
Ian Cooper
@iancooper
So feel free to tag those tests with ignore.
Until I get to it
I think the EventStore version is better than Raven if you don't want SQL
Ian Battersby
@ianbattersby
Done. Yeah, using ES a immutable transaction layer is also an interesting concept I've thought.
Ian Cooper
@iancooper
OK. Pushed that change. Support for RavenDb is dropped. If someone complains enough we can recover the code from SC and re-implement in some way that is more isolated i.e. separate tests
Ian Battersby
@ianbattersby

Done. Yeah, using ES a immutable transaction layer is also an interesting concept I've thought.

FYI; Like this: https://github.com/SzymonPobiega/NServiceBus.EventStore

Ian Cooper
@iancooper
@ianbattersby In essence this is @JontyMC's direction of travel with his reference data work. If you use EventStore as a message store, you can expose a stream that we directly consume instead of going via RabbitMQ
It turns out @JontyMC was not aware, but this exposing reference data as a stream is what Iain Robinson and Jim Webber covered in Rest In-Practice, though they wrote to an Atom Feed. I've just done a talk at Progressive.NET where I bastardized Mark Seeman's AtomStorage to do something very similiar (by badly abusing it) but its an interesting concept
I also know that Celery uses Redis to do this, and I believe that is quite common
Ian Cooper
@iancooper
PS I want to move the DB connections in the Tasks example to a SQLCE store for messaging, but I'll get to that as soon as I can
Jonathan Curtis
@JontyMC
IAmAMessageConsumerFactory has a Create method that takes in a routing key parameter. Shouldn't we be creating a consumer per queue, not per routing key?
Jonathan Curtis
@JontyMC
We have a situation in people where we've configured mulitple routing keys for the same queue
Brighter creates a consumer per routing key, so we now have multiple consumers for the same queue racing each other
each is on a separate thread, correct? so this could create an undesirable situation for versioning and requeuing
it also uses the routingkey for the consumer and the configured exchange name when logging, so that can be wrong
rmq sends that information on the message, so it could be passed over
Yiannis
@yiannistri
just opened #104 which has a tiny fix for the Requeue method
Jonathan Curtis
@JontyMC
IAmAChannelFactory uses routingKey in both its methods too. Looking at where routingKey is used, apart from logging it's only used to bind the queue to that routing key.
Ian Cooper
@iancooper
OK, so I think we can support multiple routing keys for one queue as RabbitMQ lets you bind to multiple topics. So the simple fix would be to allow that.
The alternative is to use wildcards on the topic
Understood on rmq for source of logs, we can look at that too
I'll raise the issues
Jonathan Curtis
@JontyMC
ok, thanks
Ian Cooper
@iancooper
OK raised 105, and 106
iancooper/Paramore#105 and iancooper/Paramore#106
George Ayris
@george-ayris
Morning, I'm just looking at ways to gracefully abort pipeline processing (e.g. if a pre-condition check fails) and was wondering: what happens if base.handle() is not called?
Ian Cooper
@iancooper
If you don't call base.handle you won't call a subsequent step, but will return to the calling step. You need to throw an exception
An exception is the preferred mechanism to exit a pipeline
@george-ayris Ask more though if that does not make sense
Benjamin Hodgson
@benjamin-hodgson
iancooper/Paramore#107
i have a couple more on my fork but want to discuss in person first because i have a feeling they will be more controversial
Benjamin Hodgson
@benjamin-hodgson
also iancooper/Paramore#108 (would be good to get that in asap)