Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:51
    JustCallMeDev starred BrighterCommand/Brighter
  • Jan 22 22:20
    iancooper synchronize #1351
  • Jan 22 22:20

    iancooper on improve_kafka

    Improved offset and commit hand… Don't add the broker directory Don't add the zookeeper directo… (compare)

  • Jan 22 03:20
    Shawn-Fan commented #1273
  • Jan 22 02:47
    Shawn-Fan commented #1273
  • Jan 21 20:46
    iancooper commented #1101
  • Jan 21 20:46
    iancooper closed #1101
  • Jan 21 20:45
    iancooper commented #1273
  • Jan 20 17:40
    Shawn-Fan commented #1273
  • Jan 19 09:30
    iancooper labeled #1273
  • Jan 19 09:30
    iancooper unlabeled #1273
  • Jan 19 09:30
    iancooper labeled #1273
  • Jan 19 09:30
    iancooper commented #1273
  • Jan 19 06:41
    Shawn-Fan commented #1273
  • Jan 18 13:14
    willemodendaal starred BrighterCommand/Brighter
  • Jan 18 05:24
    dependabot[bot] labeled #1368
  • Jan 18 05:24
    dependabot[bot] review_requested #1368
  • Jan 18 05:24
    dependabot[bot] review_requested #1368
  • Jan 18 05:24
    dependabot[bot] review_requested #1368
  • Jan 18 05:24
    dependabot[bot] opened #1368
Jonathan Curtis
@JontyMC
We have a situation in people where we've configured mulitple routing keys for the same queue
Brighter creates a consumer per routing key, so we now have multiple consumers for the same queue racing each other
each is on a separate thread, correct? so this could create an undesirable situation for versioning and requeuing
it also uses the routingkey for the consumer and the configured exchange name when logging, so that can be wrong
rmq sends that information on the message, so it could be passed over
Yiannis
@yiannistri
just opened #104 which has a tiny fix for the Requeue method
Jonathan Curtis
@JontyMC
IAmAChannelFactory uses routingKey in both its methods too. Looking at where routingKey is used, apart from logging it's only used to bind the queue to that routing key.
Ian Cooper
@iancooper
OK, so I think we can support multiple routing keys for one queue as RabbitMQ lets you bind to multiple topics. So the simple fix would be to allow that.
The alternative is to use wildcards on the topic
Understood on rmq for source of logs, we can look at that too
I'll raise the issues
Jonathan Curtis
@JontyMC
ok, thanks
Ian Cooper
@iancooper
OK raised 105, and 106
iancooper/Paramore#105 and iancooper/Paramore#106
George Ayris
@george-ayris
Morning, I'm just looking at ways to gracefully abort pipeline processing (e.g. if a pre-condition check fails) and was wondering: what happens if base.handle() is not called?
Ian Cooper
@iancooper
If you don't call base.handle you won't call a subsequent step, but will return to the calling step. You need to throw an exception
An exception is the preferred mechanism to exit a pipeline
@george-ayris Ask more though if that does not make sense
Benjamin Hodgson
@benjamin-hodgson
iancooper/Paramore#107
i have a couple more on my fork but want to discuss in person first because i have a feeling they will be more controversial
Benjamin Hodgson
@benjamin-hodgson
also iancooper/Paramore#108 (would be good to get that in asap)
once the ci build is done obv
Ian Battersby
@ianbattersby
We should probably internalize newtonsoft.. sigh
Benjamin Hodgson
@benjamin-hodgson
@holytshirt :+1: thank you
Stefano Ricciardi
@stefanoric
Hi guys, is there a way to have Brighter only log at a WARN level?
I need DEBUG logs from my app but Brighter is quite verbose
something like
    <logger name="Brighter">
        <level value="WARN" />
    </logger>
Ian Cooper
@iancooper
@stefanoric Just to check I understand. You want to filter out the noise from our logger apart from WARN and above? If so, don't forget we use LibLog, so we are just using an abstraction over your underlying logger. So whatever works for your logger will work for us. You create an instance of a logger to pass into us (as part of the builder normally), so you should be able to identify the logger name, and do something specific with that logger that meets your reporting needs, depending on the underlying logger you use.
@stefanoric Or to put it another way. This should be for your app to control, if we got it right :-)
Stefano Ricciardi
@stefanoric
We are using log4net, and I just needed to know if brighter had its own logger name (a-la NHibernate)
I'll have a look at the plumbing code (didn't write it myself)
Ian Cooper
@iancooper
I'll be plugging away at the Monitoring and Management stuff today. Possibly with a side journey into the CommandSource stuff to document and provide an example.
It will be a line like: var logger = LogProvider.For<Program>();
@stefanoric You pass it in. Look for where you are using CommandProcessorBuilder. I expect you'll be able to track back from there to where you set up LibLog
Stefano Ricciardi
@stefanoric
I have found the code
I see we do something like
Bind<ILog>().ToConstant(LogProvider.For<MyService>());
(this is Ninject IoC plumbing)
and ILog is brighter's interface
What I get in the code is something like:
DEBUG MyNamespace.MyService - RmqMessageConsumer: blah blah blah
I would like to silent all these DEBUG logs
Stefano Ricciardi
@stefanoric
I think I got it now
I have changed it to
``` LogProvider.GetLogger("brighter");
LogProvider.GetLogger("brighter");
and set
   <logger name="Brighter">
        <level value="WARN" />
    </logger>
This one escaped, but it's not a big deal since it's only one:
2015-07-09 11:12:27,177 [19] DEBUG paramore.brighter.commandprocessor.messaginggateway.rmq.MessageGatewayConnectionPool - RMQMessagingGateway: Creating connection to Rabbit MQ endpoint amqp://localhost:5672