Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:27
    iluwatar labeled #1113
  • 10:27
    iluwatar labeled #1113
  • 10:27
    iluwatar labeled #1113
  • 10:27
    iluwatar labeled #1113
  • 10:27
    iluwatar labeled #1113
  • 10:27
    iluwatar assigned #1113
  • 10:27
    iluwatar labeled #1113
  • 10:27
    iluwatar opened #1113
  • Dec 06 17:03
    anuragagarwal561994 commented #984
  • Dec 06 17:03
    anuragagarwal561994 commented #987
  • Dec 06 17:02
    anuragagarwal561994 opened #1112
  • Dec 06 17:01
    anuragagarwal561994 opened #1111
  • Dec 03 17:50
    iluwatar milestoned #1109
  • Dec 03 16:05
    liranz10 synchronize #1110
  • Dec 03 16:04
    liranz10 opened #1110
  • Dec 03 11:15
    hbothra15 synchronize #1108
  • Dec 03 10:26
    erikgajdos1997 closed #1109
  • Dec 03 10:25
    erikgajdos1997 opened #1109
  • Dec 01 13:09
    iluwatar commented #1108
  • Dec 01 13:09
    iluwatar labeled #1108
shachina
@shachina
halo
ThorFindHammer
@ThorFindHammer
hi
Eni Sinanaj
@enisinanaj
Guys we are hiring. Anyone interested to move to Vienna, Austria? let me know.
siddanthsagar
@siddanthsagar
I am from India.. Currently working in Capetown.. can I know the process
and the job profile details..
Request to share the job profile and pay details to siddanth.sagar@gmail.com
Hemant Bothra
@hbothra15
Hi, I wanted to know how can i create a branch with my changes for issue#925
I am getting 403 when I try to execute git push -u origin issue#925 command
Ilkka Seppälä
@iluwatar
Have you forked the repository? Implement the changes in your fork and then create the pull request.
Hemant Bothra
@hbothra15
Done, created a PR for your review
hadesyoon
@hadesyoon
@iluwatar hi sir Im a student in Korea Gwangwoon university i would like to ask some questions about open api in java design patterns can i get you email address?? sorry to everyone in here for me asking personal question
Ilkka Seppälä
@iluwatar
@hadesyoon you can send me a private message via Gitter
Ilkka Seppälä
@iluwatar
@/all we are going to start transitioning to newer Java version. It will take a lot of effort and I would appreciate all help in this process. To begin with, I wrote a preliminary plan in our wiki, see https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition. What do you think, does it look feasible? Any steps you would like to add or remove or reorder? Especially comments from developers who have done this kind of migrations are wanted.
Ilkka Seppälä
@iluwatar
I have created first issues of the transition plan on the backlog. See https://github.com/iluwatar/java-design-patterns/issues starting with "Java 11 support" and pick it up for development if you are interested.
Gaurav Deshpande
@gaurav9822
Hi @iluwatar
about #933
is there anything more needs to be done apart from upgrading the dependencies?
Gaurav Deshpande
@gaurav9822
Update: there have been test failures due to spring. I am looking into it.
Joshua Jimenez
@jjjimenez100
Hi @iluwatar, is it necessary for a section on the pattern to have a visual aid? Or its just optional to have one?
Ahh. Nvm. Just checked out the Builder one and it only had descriptions + the code sample. Thanks! :D
Ilkka Seppälä
@iluwatar
@gaurav9822 I commented the issue there iluwatar/java-design-patterns#933
@jjjimenez100 not mandatory, but would be nice
Joshua Jimenez
@jjjimenez100
Alright, noted on that. Thanks! :D
Gaurav Deshpande
@gaurav9822
@iluwatar Have fixed all issues. Please review
Ilkka Seppälä
@iluwatar
Thanks @gaurav9822, I'll check it very soon
Ilkka Seppälä
@iluwatar
Done
Joshua Jimenez
@jjjimenez100
@iluwatar Hi, is there still someone working with #970 ?
Joshua Jimenez
@jjjimenez100
I can work with it if there's no one currently assigned :D
Ilkka Seppälä
@iluwatar
@jjjimenez100 ok great, go ahead
Please comment the issue so I can assign it to you
adamski.pro
@akrystian
@jjjimenez100 Can I take iluwatar/java-design-patterns#1009 ?
Joshua Jimenez
@jjjimenez100
Sure, kind of busy atm so cant really work on it 😅
adamski.pro
@akrystian
I created PR for iluwatar/java-design-patterns#1009 - I've cleaned what was possible. Dependency declaration in child poms must stay.
Ilkka Seppälä
@iluwatar
Reviewed
adamski.pro
@akrystian
@iluwatar I fixed build iluwatar/java-design-patterns#1009
Ilkka Seppälä
@iluwatar
Thanks
adamski.pro
@akrystian
@iluwatar I fixed some check style errors in adapter pattern iluwatar/java-design-patterns#1033
Ilkka Seppälä
@iluwatar
Thanks @akrystian for the contribution
Solen Dogan
@sodogan
hello
I like to contribute to theproject
ı like design patterns
Ilkka Seppälä
@iluwatar
Welcome @sodogan
Find something to do in the issue list https://github.com/iluwatar/java-design-patterns/issues or create your own issue
General information is available in the wiki https://github.com/iluwatar/java-design-patterns/wiki
adamski.pro
@akrystian
@iluwatar I fixed some check style errors in callback pattern iluwatar/java-design-patterns#1053
Ilkka Seppälä
@iluwatar
Thanks @akrystian, much appreciated
Anurag Agarwal
@anuragagarwal561994
@jjjimenez100 this is the codestyle file I am using in IntelliJ