by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 29 23:13
    HeroicKatora opened #1246
  • May 29 20:25
    HeroicKatora commented #1243
  • May 29 20:22
    HeroicKatora commented #1243
  • May 29 20:15
    fintelia commented #1243
  • May 29 19:57

    HeroicKatora on master

    Revert "Introduce bounds check … Merge pull request #1245 from i… (compare)

  • May 29 19:57
    HeroicKatora closed #1245
  • May 29 19:56
    HeroicKatora opened #1245
  • May 29 19:55

    HeroicKatora on revert-1229-get-pixel-opt

    Revert "Introduce bounds check … (compare)

  • May 29 19:53
    PurpleMyst commented #1244
  • May 29 19:53
    PurpleMyst commented #1244
  • May 29 19:53
    PurpleMyst commented #1244
  • May 29 19:52
    HeroicKatora commented #1243
  • May 29 19:52
    HeroicKatora commented #1243
  • May 29 19:50
    HeroicKatora opened #1244
  • May 29 19:40
    HeroicKatora opened #1243
  • May 29 19:36
    lovasoa commented #1229
  • May 29 19:29
    ArturKovacs closed #1222
  • May 29 19:29
    ArturKovacs commented #1222
  • May 29 19:11

    HeroicKatora on master

    Import zero width image buffer … Implement the fixed iterator J… Collapse newly introduced tests… and 1 more (compare)

  • May 29 19:11
    HeroicKatora closed #1226
BourgondAries
@BourgondAries
Hello! Submitted a PR for a recent regression since v0.22. image-rs/image#1031
HeroicKatora
@HeroicKatora
Thank you for supplied fix. Did that ever work correctly?
BourgondAries
@BourgondAries
It worked correctly in 0.21.0
May I suggest we run cargo fmt -- --check in travis? There's some trailing whitespace in the code
HeroicKatora
@HeroicKatora
There's #1022 and #1024 already, though it doesn't seem to show any trailing whitespace in the PR diff.
BourgondAries
@BourgondAries
@HeroicKatora Yes, because that PR does not appear to touch src/png.rs, which shows trailing whitespace in my editor.
Are we also going to get rid of extern crate and transition to version 2018?
HeroicKatora
@HeroicKatora
Is there a direct benefit from the transition, in tooling, semantics or ergonomics? Imports are somewhat nicer, agreed.
The best motiviation to transition would be something with asnyc but I don't see anything in that way happening soon.
Not that I'd oppose it, just don't see enough benefit to do the work.
BourgondAries
@BourgondAries
@HeroicKatora I think it's just a good idea to stay up to date and remove obsolete features as the language evolves.
Else we end up in a situation where there's too much ancient cruft
HeroicKatora
@HeroicKatora
We have a soft commitment to Rust 1.31 due to being used in several larger projects with slow toolchains.
Removing cruft is okay (e.g. try!) but edition 2015 is not yet cruft, at least for the library users
BourgondAries
@BourgondAries
@HeroicKatora Ok. I guess we'll just have to wait a bit then :)
HeroicKatora
@HeroicKatora
Some of the dependencies have more pressing problems, I think try! hasn't been removed everywhere.
Since that's deprecated it really should be.
BourgondAries
@BourgondAries
it doesn't show up in git grep tho
HeroicKatora
@HeroicKatora
Looks like @JohnTitor got the last of them then :+1:
BourgondAries
@BourgondAries
Can we get 0.22.2 out? since the bugfix?
HeroicKatora
@HeroicKatora
Yeah, I want to fork one or two fixes from another PR before but this weekend
HeroicKatora
@HeroicKatora
Every bugfix that I know of has landed, release coming soon #1034
Yuki Okushi
@JohnTitor
Could someone merge this? I noticed that I have no write access after submitting the review... image-rs/image-core#1
HeroicKatora
@HeroicKatora
Let me get that for you
Yuki Okushi
@JohnTitor
Thanks!
HeroicKatora
@HeroicKatora
I think write access is because this is mostly an experiment by @fintelia right now
Yuki Okushi
@JohnTitor
Got it.
HeroicKatora
@HeroicKatora
So fuzzit.dev can dedicate 4 cpus/fuzzing targets to the organization. And they basically asked us to ask others for donations when we want more.
I can understand, they seem to be early in the startup phase and 4 is already pretty awesome.
Yuki Okushi
@JohnTitor
:+1:
HeroicKatora
@HeroicKatora
So what should we use the fuzzing targets for? Immediately coming to mind:
  • decode but only those that support limits (requires 'Limits' in image)
  • OR: fuzz the individual decoder crates for now
  • fuzz the encoders, this should not require limit structs
Дамјан Георгиевски
@gdamjan
hi all, I load an image with image::load_from_memory(&bytes) and then generate a thumbnail, and then I want to write the thumbnail to a buffer.
how do I get the format of the original bytes, so that I write it back into the same format?
HeroicKatora
@HeroicKatora
Calling guess_format with the same buffer gets you what you need.
Дамјан Георгиевски
@gdamjan
hmm, ok … that calls guess_format twice though, right?
because load_from_memory also calls it
HeroicKatora
@HeroicKatora
It's a pretty cheap call, nothing to worry about
But yes, it does call it twice strictly speaking
Дамјан Георгиевски
@gdamjan
thanks
HeroicKatora
@HeroicKatora
Update on fuzzit: A corpus for png has been uploaded and is going to be integrated in ci image-rs/image-png#168. There's some unknown issue actually starting the respective fuzzer on the infrastructure but the main developer assured me he'd look into it tomorrow. (He's being incredibly responsive).
If everything is running there the we can use that as a template of sorts other fuzzing processes.
HeroicKatora
@HeroicKatora

We just reached 1 million downloads. From crates.io:

Stats Overview
1,000,260 Downloads all time

Feels somewhat surreal

Yuki Okushi
@JohnTitor
Congrats!
Jacob Rosenthal
@jacobrosenthal
Hey all, any guidance on getting the image data as a buffer/pixels by column instead of row? Seems like theres something here with FlatSamples and NormalForm::ColumnMajorPacked but not sure how to put it all together yet
HeroicKatora
@HeroicKatora
You've basically gotten to the correct structs
The idea is to setup an output buffer and corresponding column major packed metadata in FlatSamples (there are only few helper methods here, but column_major_packed for the common case. Otherwise you have to do this by hand, sorry.) Then you can reference that buffer as a mutable image with as_view_mut/ViewMut and copy over pixel by pixel. Not optimal from an ergonomics perspective but saves you from manually working out indexing schemes.
lazypassion
@lazypassion
Hello, do the decoders handle conversion from sRGB to RGB? Specifically the jpeg decoder.
HeroicKatora
@HeroicKatora
They don't. Or, I'm not entirely sure. It's somewhat awkward
jpeg in particular since the decoder crate is not developed by image-rs
Wikipedia suggest that the matter is even more peculiar: https://en.wikipedia.org/wiki/JPEG_File_Interchange_Format#Color_space
lazypassion
@lazypassion
Ok, thank you. I skimmed through the decoder and it doesn't seem to handle srgb, though I'm probably missing something.
Conner
@ZargorNET
Hey, I know that this is a question regarding imageproc but because it builds on image, I hope that somebody can help me.
I observed that draw_text doesn't scale correct. When I multiply my font width times the char count, the resulting width is much larger than the text itself: example (ignore the green box, but the red box is important).
Am I doing smth wrong or is my font (Oswald from Google Fonts) not suitable?
HeroicKatora
@HeroicKatora
@ZargorNET Sorry for the delay, it's probably better to open an issue on imageproc as this channel is for main image.
zero-systems
@zero-systems
Hello, Is it possible to asynchronously read image? I have actix-multipart crate, which helps me gathering multipart data from http, but I don't see any things which can help me generating thumbnails on the fly. is it possible to do this with image-rs crate?
it's very important, because opening even 0.5 MiB image takes almost infinite and generating thumbnail too... So I think I have to make thumbnail on the fly
Kunal Mohan
@kunalmohan
Hi! I am somewhat new to using the image crate. I have been facing problem with the load_from _memory function. Doesn't it support jpeg images?