Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Talal Mostafa
    @TaIaI_Mostafa_twitter
    I have multiple images...my outputs is a txt sheet with the results of particle analysis and an image of the processed image
    Gabriel Selzer
    @gselzer
    @TaIaI_Mostafa_twitter this would be a great question to ask on https://forum.image.sc/, there are many knowledgable people there who would be happy to help answer your question
    Talal Mostafa
    @TaIaI_Mostafa_twitter
    Hello Gabriel
    Thank you I already did
    Deborah Schmidt
    @frauzufall

    Is this section in the wiki about adding a new template to ImageJ up to date? I'm wondering about this part:

    The templates need to be put into a subdirectory corresponding with the correct script language name.

    The examples here don't do this.

    There is also this repo: https://github.com/imagej/example-script-collection which is not mentioned in the wiki, should this still be used as a template? Then I would add a link to it.
    Jan Eglinger
    @imagejan
    I think this is outdated, the addition is from 2014: https://imagej.net/index.php?title=Script_Templates&diff=12385&oldid=12384
    Yes, it would be great if you can update the wiki page! The example-script-collection was intended to show how to manage scripts that show up in the main ImageJ menu, but not targeting script templates in the script editor.
    Still it would be good to mention it where appropriate.
    Deborah Schmidt
    @frauzufall

    Ah, ok, got it. What about this:

    This is required so that templates are made available only when the corresponding script language is available.

    Seems like this check is no longer happening and scripts are added independent of which language is available, is this correct or am I missing something in the code you linked above?

    Jan Eglinger
    @imagejan
    Hm, that's a good point. I don't know. Would also have to dig deeper...
    Deborah Schmidt
    @frauzufall
    I think this is where this check got removed: scijava/script-editor@a1d5a4a
    @ctrueden since you wrote this commit - seems like you wanted scripts without a matching available script language to still be part of the template menu, so I would just remove this paragraph from the wiki.
    Curtis Rueden
    @ctrueden
    @frauzufall Removing the paragraph sounds great. Thanks!
    The language-specific basic templates ship with the scijava/scripting-<foo> components, so the language will be available for those. The only chance of a missing language might be a component that ships scripts without an explicit Maven-side runtime dependency on the relevant scripting-<foo> component—which would then prevent automated testing of the scripts. So I think it's OK.
    Jan Eglinger
    @imagejan
    As far as I can see, this repo has a test dependency on scripting-groovy, but no runtime dependency. So it might be possible to have an ImageJ installation without Groovy support, which still shows this template in the menu...
    Curtis Rueden
    @ctrueden
    @imagejan Ah, so I guess we should add scripting-groovy as a runtime dep to imagej-legacy then, eh?
    BTW: I just purged a whole boatload of spammers from the imagej.net wiki.
    I used https://imagej.net/Special:UserMerge to simply merge all bad users I found to the single account called Spam.
    I browsed through all users with edits, sorted by newest, through the beginning of 2017.
    Curtis Rueden
    @ctrueden
    I've now browsed back through mid-2013 and not finding any more spammers, so I'll stop there.
    Curtis Rueden
    @ctrueden
    I also changed the CAPTCHA questions, although I am guessing it won't help much. My feeling is that the spammers are somehow getting around them.
    Unfortunately, I don't have time to take another stab at fixing the StopForumSpam extension now.
    Jan Eglinger
    @imagejan

    @ctrueden I currently experience problems logging in to the ImageJ wiki. I get the following error message:

    There seems to be a problem with your login session; this action has been canceled as a precaution against session hijacking. Go back to the previous page, reload that page and then try again.

    Could this be related to your recent changes? Or should I look to fix things at our end? (I'm behind a proxied firewall, and noticed laggy TLS handshake behavior earlier...)

    Curtis Rueden
    @ctrueden
    @imagejan I was able to reproduce your problem by logging out and then attempting to log back in.
    I fixed it (for now) by changing $wgMainCacheType = CACHE_ACCEL; to $wgMainCacheType = CACHE_NONE;
    We need to get that CACHE_ACCEL thing working in order for the StopForumSpam extension to work.
    I think the config was left over from when I was playing with it most recently. Sorry for the hassle.
    Jan Eglinger
    @imagejan
    Oh, alright, thanks for the info. I was able to log in now.
    Curtis Rueden
    @ctrueden
    @imagejan OK, the good news is I believe I fixed the CACHE_ACCEL setting. Maybe just my imagination, but the wiki seems very zippy now. :-)
    The bad news is: enabling StopForumSpam still does not easily work. I'll dig more later when I have time.
    Jan Eglinger
    @imagejan

    Hi @frauzufall, do you have any clue why recent Travis CI builds on pull requests of imagej-ui-swing fail? The error is:

    sh: 0: Can't open /etc/init.d/xvfb
    The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during .

    See for example https://travis-ci.org/imagej/imagej-ui-swing/builds/617399012?utm_source=github_status&utm_medium=notification

    Laurent Thomas
    @LauLauThom
    Hi all, any idea why the Color constructor is not recognised as such in the if statement of this method. Eclipse recognised it as a method of the class Roi. Eventhough, I have imported the Color class https://github.com/LauLauThom/ImageJA/blob/531d9fa22ea59dfe74e49456d48a4945994a59dc/src/main/java/ij/gui/Roi.java#L2192
    Jan Eglinger
    @imagejan
    @LauLauThom you mean this line? How about adding the new keyword? It’s Java, not Jython ;-)
    Laurent Thomas
    @LauLauThom
    Ha ha thanks, so dummy ! 🤦‍♂️
    Deborah Schmidt
    @frauzufall
    @imagejan sorry for the delayed answer.. I think I had this before somewhere else and I think the solution was to remove the whole before_script block because this is no longer needed in the most recent travis system. I'll look it up
    Jan Eglinger
    @imagejan
    @frauzufall thanks, that seems to have worked. (Travis still skipped one test in image-ui-swing though, I don’t know if that’s intended…)
    Deborah Schmidt
    @frauzufall
    @imagejan glad it worked! yes there is one fallback test in case HTTPS is not supported by Java, it is ignored in the other case.
    Jan Eglinger
    @imagejan
    @ctrueden @frauzufall is it ok if I go ahead and merge pending PRs on imagej/list-of-update-sites (like imagej/list-of-update-sites#32 and my own imagej/list-of-update-sites#33 ) myself? or should I wait your approval?
    Deborah Schmidt
    @frauzufall
    @imagejan the only thing I was doing in the past is to look over the PR if all the information is filled out and check if imagej.net/UPDATESITENAME exists.
    .. and you can do that too :) Thank you!
    Jan Eglinger
    @imagejan
    Alright, thanks! :+1:
    Laurent Thomas
    @LauLauThom

    Hi guys, I am adding some new functions to the macro language to match some functions I added to the Roi class. I manage to have the following methods working into a macro equivalent: roi.setGroup(int x), roi.getGroup(), Roi.getCurrentGroup(), but I have a runtime issue with the last one Roi.setCurrentGroup(int x):. I dont get why...

    Error:        ')' expected in line 1:
                    var ; initializeSciJavaParameters ( ) ; Roi . setCurrentGroup ( <5> ) ;

    see https://github.com/LauLauThom/ImageJA/blob/08d46930b95647bc168505a37c3dd4d4e4ca6d60/src/main/java/ij/macro/Functions.java#L7287

    NB : For testing the methods with the IJmacro language you need a selected Roi (maybe not so nice for the class method set/getCurrentGroup 🤔)
    Jan Eglinger
    @imagejan

    @LauLauThom just from looking at the other set*() functions: they don’t have a interp.getParens() statement… but I have no clue how the IJ1 Macro Interpreter works internally.

    Before you invest too much effort in improving the legacy IJ1 code, you should contact Wayne directly to know whether he is willing to include your changes. Usually he’ll add changes in some of his own commits, instead of accepting any pull requests or similar.

    In case you wonder: the strange var ; initializeSciJavaParameters ( ) ; statement is added by the SciJava preprocessing of the macro code in order to add the variables defined by script parameters. Unfortunately it shows up in the error message when the issue is in the first line of the macro : (
    If you want to get a cleaner error message, just add a non-problematic first line or comment to your test macro ;-)
    Laurent Thomas
    @LauLauThom
    You were right removing the getParens() worked thanks! About Wayne, he did not reply when I suggested the idea on the forum so I decided to start anyway and learn some stuff on the way. I am thinking that if I propose only part of the solution, he might not be very motivated to implement it while if I have some solid prototype that the community can already try then he might be more willing to take the change
    Curtis Rueden
    @ctrueden
    @LauLauThom I caution you against getting too invested in changing ImageJ 1.x. Wayne has rejected changes in the past, from my group (things needed for ImageJ2), and from others. He has also reimplemented things people submitted in ways that do not fully meet the original requirements. That said, there are many times when he integrates changes quickly and in line with patches people submit. But I would still be much happier if you could find a way to stay away from the macro language and use ImageJ2 instead.