Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 18 16:26

    tinevez on dev

    Return sensible defaults when w… (compare)

  • May 18 10:59
    tinevez synchronize #162
  • May 18 10:59

    tinevez on branch-graph-v2

    Proper menu item label for the … (compare)

  • May 18 10:52
    tinevez synchronize #162
  • May 18 10:52

    tinevez on branch-graph-v2

    A TrackScheme painter that pain… Make the branch trackscheme vie… Rework the branch hierarchy vie… and 2 more (compare)

  • May 17 15:41
    tinevez synchronize #162
  • May 17 15:41

    tinevez on branch-graph-v2

    Fix javadoc errors. (compare)

  • May 17 15:35
    tinevez edited #162
  • May 17 15:33
    tinevez synchronize #162
  • May 17 15:33

    tinevez on branch-graph-v2

    Remove faulty JUnit test. It w… (compare)

  • May 17 15:23
    tinevez opened #162
  • May 17 15:15

    tinevez on branch-graph-v2

    Don't send navigation events to… (compare)

  • May 16 21:05
    ctrueden commented #317
  • May 16 21:04
    ctrueden commented #317
  • May 16 21:03
    ctrueden commented #317
  • May 16 20:54
    ctrueden commented #391
  • May 16 20:08
    imagejan commented #391
  • May 16 13:53

    tinevez on branch-graph-v2-feature-colors

    (compare)

  • May 16 07:00
    tischi commented #391
  • May 15 19:09

    tinevez on branch-graph-v2

    Have a set of basic feature per… (compare)

Tobias Pietzsch
@tpietzsch
Yes
in the menu
and shortcut F11 I think
oh
by Bdv interface, you mean vistools?
Nicolas Chiaruttini
@NicoKiaru

by Bdv interface, you mean vistools?

More the BdvHandle, because it's what we discussed was appropriate in order to make a bunch of Scijava compatible commands for Bdv (see https://forum.image.sc/t/fiji-commands-for-bigdataviewer/25601 and our current attempt located in the repo : https://github.com/BIOP/bigdataviewer_scijava)

Tobias Pietzsch
@tpietzsch
Hmm, no it's not yet supported through BdvHandle
but should be relatively easy to add if you want to make a PR
Nicolas Chiaruttini
@NicoKiaru
Actually after spending some time trying to understand the functioning of BigDataViewer, I realized that most of the communication between plugins is made through the dataset xml file (registrations, sources, etc). So I'm less convinced that bdv scijava commands will be very useful. Perhaps if a dataset.xml file could be accessed from/linked to a BdvHandle, that would be more useful.
But for now I'm not stuck, so that's good. I'll file a PR when I know if I need such a possibility.
Tobias Pietzsch
@tpietzsch
@NicoKiaru the bdv scijava commands would be a step on the way to better integrate BDV into the IJ2 framework
I think it will be very useful
I'm very thankful that you are exploring this!
Nicolas Chiaruttini
@NicoKiaru
Hi everybody, is there a way to retrieve the xml dataset file from a SpimDataobject ? To me it looks like no, only the basepath can be retrieved, but not the file name. Do you confirm ?
Tobias Pietzsch
@tpietzsch
yes
confirmed...
Nicolas Chiaruttini
@NicoKiaru
oki doki, thanks!
Curtis Rueden
@ctrueden
You could get it via reflection for now, no?
Tobias Pietzsch
@tpietzsch
I don't think so
Nicolas Chiaruttini
@NicoKiaru
not even sure, it's contains in the xmlio object, but I don't think in the spimdata object
Curtis Rueden
@ctrueden
Maybe I am looking at the wrong SpimData code then.
mpicbg.spim.data.SpimData?
Nicolas Chiaruttini
@NicoKiaru
Hum, I have AbstractSpimData
Curtis Rueden
@ctrueden
Oh, I see, basePath is not what you want.
Nicolas Chiaruttini
@NicoKiaru
Because it can be SpimData or SpimData2
Indeed
Curtis Rueden
@ctrueden
And the I/O code throws away the filename. Ouch.
Tobias Pietzsch
@tpietzsch
@NicoKiaru What do you need the xml path for?
We could add it
It would be optional however
Nicolas Chiaruttini
@NicoKiaru
It's again along the line of communicating objects within scijava commands
Tobias Pietzsch
@tpietzsch
There are instances where SpimData is not constructed from XML
If you want to make a PR, you can add it to AbstractSpimData
Nicolas Chiaruttini
@NicoKiaru
Let's say you have a command which adds interest points - using sift for instance. You want to get the spimdata object, add interest points, and then potentially resave the xml file
Tobias Pietzsch
@tpietzsch
Would be set when reading a SpimData through XmlIoAbstractSpimData
Otherwise it would be null
Maybe it would be also set, if you save the SpimData to a (different) XML file
but that already gets interesting
Nicolas Chiaruttini
@NicoKiaru
oki doc. Maybe another option is to add an abstract save or resave method to spimdata ? Would that make sense ? The default behaviour would be what you describe. But I'm not familiar with use cases other than the simple ones. I do not want to add a dirty patch which turns out to be annoying.
Tobias Pietzsch
@tpietzsch
I'm not sure how that would play with extensibility
AbstractSpimData and XmlIoAbstractSpimData play together somehow
and then SpimDataMinimal, XmlIoSpimDataMinimal, etc
I wouldn't do it
But potentially you could make a wrapper around a SpimData and a XmlIo that has these methods and keeps the filename
(then we need to make sure, that the default spimdatas in Fiji always are loaded in a way that they have the wrapper)
something like that?
Nicolas Chiaruttini
@NicoKiaru
yep. Ok. For now I will not touch anything, and keep things the way they are. I'll let the user define the dataset name, and with the Parameter being persistent, it's not complicated : if he wants to resave and erase the previous dataset, he lets the same name, and if he wants to avoid erasing the dataset, he changes the name - another dataset is created.
Not ideal, because this dataset name is not transfered from one Command to another. I'll investigate more your advice when required. Thanks a lot !
Tobias Pietzsch
@tpietzsch
Maybe you can just make a static Map< SpimData, String (with weak keys)