These are chat archives for inbilla/CMake

16th
Sep 2015
Packadal
@packadal
Sep 16 2015 11:32
I'm getting an issue where spaces are being ignored
there is a -DSTUFF="foo bar" with two spaces between foo and bar, and only one is passed to the compiler
any thoughts ?
this seems to be on Fastbuild's side
as the fastbuild file has the correct spacing
Joshua Green
@inbilla
Sep 16 2015 12:47
Interesting... It's possible its on the fastbuild side....
There is a tokenise function that often scans through arguments
It may be tokenising wrong, and then stitching it back together?
Packadal
@packadal
Sep 16 2015 12:49
yeah, my guess is it's ignoring every whitespace that directly follows a whitespace
since the doc of fastbuild says it ignores all whitespace
Packadal
@packadal
Sep 16 2015 12:54
I'd like to ask the fastbuild dev about stuff like this, but I don't want to open a bug everytime
maybe we should invite him in this gitter, don't you think ?
Joshua Green
@inbilla
Sep 16 2015 12:57
yeah, my plan was to invite him in here
I've had a number of email threads with him about various things
trying to keep the thread of thoughts separate
Joshua Green
@inbilla
Sep 16 2015 13:02
I think it's most likely that it's not tokenising the arguments properly
it does plenty of this:
// split into tokens
Array< AString > tokens( 1024, true );
m_LinkerArgs.Tokenize( tokens );
const AString * const end = tokens.End();
for ( const AString * it = tokens.Begin(); it!=end; ++it )
{
my guess is that array of tokens, doesn't consider that the beginning of quotes could be after the first character of an argumen...
lets see...
mmm, no, the tokeniser looks like it should handle that case...
from reading the code
is it possible there is a stray quote at the beginning of the arguments?
Packadal
@packadal
Sep 16 2015 13:12
I'm doing a clean build because I had some strange results, I'll tell you as soon as it's over
Packadal
@packadal
Sep 16 2015 13:58
OK, so here's the offending line
-DTARGETSTRING="\"hello`~!@^$*)(+-=}{][:^'.?/ ,&|^^<>world;\""
Packadal
@packadal
Sep 16 2015 14:09
and this is only a line in a multiline variable definition
Joshua Green
@inbilla
Sep 16 2015 14:15
Aha... I don't think fastbuild tokeniser handles escaped quotes...