These are chat archives for inbilla/CMake

19th
May 2017
doodlydroll
@doodlydroll
May 19 2017 05:00
@comicfans , I tried also with our project at work. But that fails. We are using Qt. There are bunch of Qt related tests failing too. Ill try on windows with unit tests to see what numbers I'll get. Windows was working better before (back in Jan) as far as I remember.
comicfans
@comicfans
May 19 2017 06:08
@doodlydroll I haven't tried qt project, I tried building following projects: llvm clang cmake
Packadal
@packadal
May 19 2017 07:10
@comicfans this sounds like really good work, props !
Packadal
@packadal
May 19 2017 07:57
I understand you testing more on real projects, but if we could get the test rate up, we could try to get this integrated
even if it does not work fully well due to Fastbuild lacking some stuff, it would releave us of the burden of rebasing
and probably get some more people working on this and testing stuff
comicfans
@comicfans
May 19 2017 08:04
@packadal yes you're right,but unfortunately I haven't too much time on this since my last try
Packadal
@packadal
May 19 2017 08:06
no worries, I'll try and rebase this on current master, I think it's the most pressing matter
it's too late for integration in 3.9
but I'd like to at least propose for integration in 3.10
comicfans
@comicfans
May 19 2017 08:09
great !
Packadal
@packadal
May 19 2017 08:47
rebased on latest master (on linux) and there are only 8 more fails (9 more tests)
before - 85% tests passed, 67 tests failed out of 438
after - 83% tests passed, 75 tests failed out of 447
@comicfans could you list the test that fail because of missing FBuild features ?
I'd like to get the list of failing tests and hints on how to solve those up to date
so if we have failing tests maybe we can ask for integration anyways
if those are out of our control
comicfans
@comicfans
May 19 2017 09:36
@packadal I haven't checked test lists, so not sure which failure is lead by missing fastbuild feature
but fastbuild/fastbuild#198 is important . without this, there's no way for cmake can express dependencies to fastbuild,so fastbuild can not build targets in correct order
comicfans
@comicfans
May 19 2017 09:42
if there is test which has X-depends-on-Y structure, fastbuild
has a X depends on Y structure , fastbuild/fastbuild#198 Will help
Packadal
@packadal
May 19 2017 12:24
CPakc test fails on linux are due to the *.sh files generated by the generator
the test consists in packing up a .sh file and extracting it
but since there are those sh files along, it detects them and fails
doodlydroll
@doodlydroll
May 19 2017 12:25
@comicfans , I run also your CMake/upstream3 on windows.
  • with msbuild: 98% tests passed, 10 tests failed out of 428 (1 crash)
  • with fbuild: 92% tests passed, 33 tests failed out of 416 (1 crash)
Testing the above took like 6h (the whole exercise) :(
Packadal
@packadal
May 19 2017 12:29
run ctest with "-jX"
it helps a lot
the qt autogen stuff is due to having multiple rules that have the same output
e.g. qt_automoc_file.cpp both in Release.bff and Debug.bff
I'm guessing this issue causes lots of test fails, since it causes the TutorialSterp5+ to fail
comicfans
@comicfans
May 19 2017 12:32
maybe, this needs to be checked in cmake lists
Packadal
@packadal
May 19 2017 12:32
I'll try to move this rule in the common bff file
comicfans
@comicfans
May 19 2017 12:33
most cmake generator is single config
doodlydroll
@doodlydroll
May 19 2017 12:33
@packadal , Re: qt autogen, yes! that is what make it fail on my big project (Qt based)
comicfans
@comicfans
May 19 2017 12:34
if cmake script didn't consider multi config,it will do generate same output by different config
Packadal
@packadal
May 19 2017 12:34
hmmm, indeed, only Debug.bff is included but it complains anyways about duplicate outpus
doodlydroll
@doodlydroll
May 19 2017 12:34
can that be worked around by using Debug.bff only on the command line of fbuild?
comicfans
@comicfans
May 19 2017 12:35
@doodlydroll you can
check fastbuild command help,it can use bff file you pass in
if same output duplicate in different bff,we should check cmake script, but if duplicate output appears in one bff,it seems to be a bug by fastbuild generator
comicfans
@comicfans
May 19 2017 12:42
for first situation ,I am afraid that we can not simply move same output rule to common bff, because different rules is needed by different config,they just outputs same file, I think this should be addressed by make cmake script multi config awared
for my llvm build test ,I also found visual studio debug/release config have same output (which I think it should not)