nathankleyn on v2.0.1
nathankleyn on master
Bump to v2.0.1 with Lua fix. (compare)
nathankleyn on v2.0.1
nathankleyn on v2.0.1
cdagraca on fix-lua-loading
cdagraca on master
Make sure loading Lua from reso… Merge pull request #24 from int… (compare)
nathankleyn on fix-lua-loading
Make sure loading Lua from reso… (compare)
nathankleyn on fix-lua-loading
Make sure loading Lua from reso… (compare)
nathankleyn on fix-lua-loading
Make sure loading Lua from reso… (compare)
Hi Maciej, not sure if I’ve understood correctly, but I guess you mean overriding these keys:local lock_key = 'icicle-generator-lock'
local sequence_key = 'icicle-generator-sequence'
local logical_shard_id_key = 'icicle-generator-logical-shard-id’
So you can generate different ids for persons
and things
.
With the current implementation that’s not possible. It would be possible using some kind of string interpolation in the lua script and adding a key
parameter in the IcicleGenerator
class.
To be completely honest, we don’t see a use case for that, as you can use the same generated ids for different resouces, they are always a long
and they are always sorted, but besides that, you shouldn’t worry about the value and you can use the ids in different resources (as we are actually doing, for example).
What’s the use case or reasoning behind that?
@albertpastrana I checked it and:
So, I get into lua script and it fails on Redis's logging commands, when I removed them, everything was all right. I am gona to take a look closer, but it look like internal Redis problem :(
Hey @maciekciolek! I just independently confirmed the same thing on my end. I'm aiming to publish a new release this week which will be v2.0.0 with update dependencies and a reliance on Redis >= 3.0 to solve this problem.
Basically, it's because the logging levels were renamed, LOG_INFO becomes LOG_NOTICE in >= 3.0. :cry:
Keep an eye on the repo for a new release sometime this week!