I'm also going to have to decide on a server-to-server protocol for components that run on the testnet-of-testnets, would be cool if some of those components would be written in Java.
@andrew-g-za would you agree with @sappenin's remarks in https://github.com/interledger/rfcs/issues/249#issuecomment-318084843 ?
@michielbdejong yes I totally agree. OER support in java seems to be non-existent, and i've yet to find solid, clear documentation on it in one place - it took me many hours to find anything on what an OER GeneralizedTime object looked like 'on the wire'. This presents an obstacle to adoption for sure. If the argument for moving to binary is around performance then perhaps OER is a reasonable choice, but it certainly not winning any awards for ease of use. In the end choosing OER means that we must provide a rock-solid OER serializer/deserialzer that implementers can use out the box.
oh wow, OER is a missing page here: https://en.wikipedia.org/wiki/Abstract_Syntax_Notation_One#Encodings
maybe we can define ILP and LLL in ASN.1 and then still use JSON on the wire
HA - just saw the name on 251 -- never saw the word "lotocol" till now. LLL FTW!
It's a pun on PPP :)
Ah, that makes me feel a bit better - I was thinking it was some meme I hadn't heard of before, like "hodl on" (https://www.reddit.com/r/Bitcoin/comments/2b8t78/whats_hodl/)
the invite is for 17:00 GMT+2
im guessing its an hour late?
@earizon hi! how's it going? I was wondering if there's anything I can help with in the Java implementation, for instance, are there any plans to implement the new version of the PluginVirtual RPC protocol? We changed it from JSON to OER and gave it a more official name: 'Bilateral Transfer Protocol'
@michielbdejong Hi Michiel, I interpret the "JSON" (protocol) can be considered deprecated right now. That was the protocol I was using for the java ledger (https://github.com/earizon/java-vertx-ledger/tree/master/src/main/java/com/everis/everledger/handlers) -that actually is not java but kotlin using the java-ilp-core package -.
Is there any code to check how the new binary protocol is being used in NodeJS?. I'm thinking something similar to the five-bells-ledger/tests I used to develop the java/kotlin ledger.
My intution says that porting from JSON to OER must be a matter of "re-encoding" the messages, so it must not be really difficult.
By the way, the main branch is using an in-memory ledger so balances it's reseted on each reboot. The earizon-ethereumBackend branch used an Ethereum node (or network) as persistent backend. Bassically it keeps the five-bells-ledger protocol to interact with Ethereum (just in "PoC" version with the pre-defined accounts defined in the ./wallet subdirectory)
Hi @earizon, we're replacing the HTTP + JSON protocol with the Websockets + OER one in the trustline implementation (https://github.com/interledgerjs/ilp-plugin-payment-channel-framework/blob/master/src/lib/plugin.js). Are you building a ledger or an ILP client?
(Note I'm talking about the plugin RPC / trustline and payment channel protocol. The Five Bells Ledger API is staying as it was, but we've been prioritizing the bilateral protocols over that one)
@michielbdejong five-bells-ledger actually. Since there was no persistent database for the ledger, I just choosed to use ethereum accounts. Actually any back-end storage implementing the https://github.com/earizon/java-vertx-ledger/blob/earizon-ethereumBackend/src/main/java/com/everis/everledger/ifaces/account/IfaceLocalAccount.java must work.
@emschwartz , Actually this was a PoC ledger trying to replicate five-bells-ledger in java. Bilateral protocols and (ideally a java connector) was next on my list. (Historically I developed it just to get used / trained with Interledger)
@emschwartz , Actually this was a PoC ledger trying to replicate five-bells-ledger in java. Bilateral protocols and (ideally a java connector) was next on my list. (Historically I developed it just to get used / trained with Interledger)
My recommendation for where to get started with an interledger implementation is to implement a sending client like https://github.com/interledgerjs/ilp that uses the Bilateral Transfer Protocol (BTP) for transfers
I'm doing that in Rust at the moment. I'm cleaning up the code now and I should have it on github this week
@earizon The code I've got so far is here: https://github.com/emschwartz/ilp-rs. I'm a bit stuck on how to implement the plugin abstraction and particularly the async parts like events and functions that return futures, but I got it to the point where it can successfully send an SPSP payment to the JS implementation and get the fulfillment back
You sent: interledgerjs/btp-toolbox#2
interledgerjs/btp-toolbox#2
interledgerjs/btp-toolbox#2
;)
Btw - here's a link to a quick branch I put together to demonstrate how easy immutables is to use: interledger/java-ilp-core@724bcb3
To get it working in your IDE, you'll want to follow the directions on the immutables website -- for Intellij, at least, you have to configured the annotation processor in the IDE so it can pickup the immutables annotations. But on the command-line, it should just build.
See here for IDE config: http://immutables.github.io/apt.html