Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 28 16:15

    internalfx on master

    v4.0.3 (compare)

  • Jun 28 16:14

    internalfx on master

    handle empty files (compare)

  • May 26 11:17
    internalfx closed #91
  • May 26 11:17
    internalfx commented #91
  • May 26 11:16

    internalfx on master

    Don't try to log values that ar… (compare)

  • May 26 10:22
    trajce edited #91
  • May 26 10:22
    trajce opened #91
  • May 24 14:55
    internalfx commented #90
  • May 24 14:54
    internalfx closed #90
  • May 24 14:54
    internalfx commented #90
  • May 24 14:53

    internalfx on master

    v4.0.1 (compare)

  • May 24 14:52

    internalfx on master

    fix initial setup (compare)

  • May 24 14:49
    trajce commented #90
  • May 24 14:49
    internalfx commented #90
  • May 24 14:46
    internalfx commented #90
  • May 24 14:46
    internalfx commented #90
  • May 24 14:46
    internalfx commented #90
  • May 24 14:44
    internalfx commented #90
  • May 24 14:42
    trajce opened #90
  • May 24 12:21

    internalfx on master

    update readme (compare)

Winston Hughes
@hughker
haha! yes, all good on your end, thanks again :]
@internalfx i was wondering if it was possible to do qs pages watch or do i just have to keep doing qs pages upload --filer=home.html every time I make a change to the page?
Rick Davies
@rickydazla
@/all has anyone had a chance to see if quickshot works with new Shopify custom (vs private) apps? https://shopify.dev/apps/auth/admin-app-access-tokens
Winston Hughes
@hughker
not yet @rickydazla — but might be able to next week
Rick Davies
@rickydazla
it werks @hughker
when you configure the quickshot target, you provide this: https://[api_key]:[admin_access_token]@storename.myshopify.com/admin/api
via @trajce :)
Bryan Morris
@internalfx
@rickydazla Is there a reason quickshot needs to work with "custom" apps?
Or, what is the difference/advantage?
@rickydazla Also, how have you been man?
Rick Davies
@rickydazla
Good! Spinning a lot of plates :)
Custom apps are the new private apps, different way of generating api creds and defining scopes. I guess Shopify are also not allowing “unpublished public apps” no mo
Bryan Morris
@internalfx
Yeah, they basically killed copycat
Glad to hear you're doing well.
@/all Quickshot 3.6.0 has been released, please file any issues you encounter.
Rick Davies
@rickydazla
Oh yeah! Nice, will do
Bryan Morris
@internalfx
It's a huge update! internalfx/quickshot@bf65d81
Question for everyone.....
How useful would blogs watchor pages watch or products watch be?
Rick Davies
@rickydazla
I would 100% use blogs (articles:)) and pages… probably products too… but all significantly less than theme. Like, if you assume I use theme everyday then I probably use blogs once a week and pages once a month. I would def use products more if it was available, never really considered it
I download, edit and then copy-paste article and page content all the time. Most product edits I do are tags, types, and metafields, and since you can’t copy/paste that stuff then I don’t really need to download either
Bryan Morris
@internalfx
Thanks for that, speaking of metafields, I'm working on a replacement for CopyCat. Do you have any suggestions or things you would want to see in a "from the ground-up" redesign?
Rick Davies
@rickydazla
tbh it seems like shopify are supporting metafields like 1st class citizens now so idk if there is a strong use case for copycat?
Bryan Morris
@internalfx
@rickydazla Oh really? hey that is great to know. I wouldn't want to go wasting time fixing problems that Shop owners aren't dealing with. Thank You!
Winston Hughes
@hughker
@internalfx — if you're able to download/upload metafields on pages/products: that'd be legit. we heavily rely on metafields at my current company and to be able to more easily edit or move from STAGE to PROD using QS would be super handy
Bryan Morris
@internalfx
@hughker I'll look into it.
Bryan Morris
@internalfx
@/all Products upload/download now supports the ignorefile
@/all Pages now has "experimental" support for metafields! Please test WITH A DEV SHOP and report any issues.
I don't expect any issues but I really don't want to break someones site.
It will be released as Version 4.0.0
Bryan Morris
@internalfx
@/all V4.0.0 published to NPM
run npm install -g quickshot to upgrade.
Bryan Morris
@internalfx
@hughker Metafields on products has been supported for a while FYI...
Winston Hughes
@hughker
Yessir @internalfx — I thought I remembered that from a bit ago
Will try it out in a devStore as soon as possible
Bryan Morris
@internalfx
I just noticed that Shopify has increased the API call bucket to 40 requests!
Still only 2 requests per second for the "leak" rate.
But Quickshot has been configured for a 20 request "burst".
Looking at the code....there is nothing that needs to be done, my original implementation reads the call limit headers from Shopify and adjusts automatically.
Bryan Morris
@internalfx
So at some point quickshot just got faster.
Winston Hughes
@hughker
:+1:
Rick Davies
@rickydazla
@internalfx why this?
10:12:03 am - RUN COMMAND [theme download] ================================
10:12:04 am - TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received null
=== START OF OUTPUT ===
TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received null
    at Object.writeFile (node:internal/fs/promises:823:5)
    at Promise.map.concurrency (file:///Users/Rick/.nvm/versions/node/v18.2.0/lib/node_modules/quickshot/src/commands/theme/download.js:65:17) {
  code: 'ERR_INVALID_ARG_TYPE'
}
==== END OF OUTPUT ====
Bryan Morris
@internalfx
hmmm....
@rickydazla Do you know what was being downloaded?
Rick Davies
@rickydazla
I think… an empty file
@internalfx yes, that’s it
Bryan Morris
@internalfx
oh....well that explains why there was no content
@rickydazla try v4.0.3
Rick Davies
@rickydazla
:tada:
Bryan Morris
@internalfx
Great