Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 27 2020 16:49
    internalfx commented #77
  • Oct 26 2020 20:43
    eddysims commented #77
  • Oct 09 2020 16:47
    joshuaiz commented #80
  • Oct 08 2020 21:40
    joshuaiz opened #80
  • Oct 06 2020 14:37
    internalfx commented #79
  • Oct 06 2020 14:34
    internalfx closed #79
  • Oct 06 2020 14:34
    internalfx commented #79
  • Oct 06 2020 14:21
    stevenventimiglia opened #79
  • Oct 06 2020 14:18
    stevenventimiglia commented #55
  • Oct 06 2020 14:18
    stevenventimiglia commented #55
  • Oct 06 2020 14:17
    stevenventimiglia commented #55
  • Jul 16 2020 23:39
    dependabot[bot] labeled #78
  • Jul 16 2020 23:39
    dependabot[bot] opened #78
  • Jul 16 2020 23:39

    dependabot[bot] on npm_and_yarn

    Bump lodash from 4.17.15 to 4.1… (compare)

  • Jun 19 2020 17:32
    joshuaiz commented #75
  • Jun 16 2020 17:50
    joshuaiz commented #77
  • Jun 16 2020 17:50
    joshuaiz commented #77
  • Jun 15 2020 01:54
    eddysims commented #76
  • Jun 15 2020 01:53
    eddysims opened #77
  • Jun 04 2020 03:07
    joshuaiz commented #76
Rick Davies
@rickydazla
No problems with install? You have run qs configure? Your private app has sufficient permissions? You are running qs watch?
Rick Davies
@rickydazla
@internalfx i don’t think it’s an issue w/ config
Bryan Morris
@internalfx
ok...so you made a new config and it still broke?
I ask because qs doesn't ask for APIkey and password anymore
It's just the full "example URL"
Rick Davies
@rickydazla
yeah, config seems fine, i can add and edit targets and qs watch works fine
Bryan Morris
@internalfx
k
is there a stacktrace in the error?
Rick Davies
@rickydazla
just what i posted in the issue
Bryan Morris
@internalfx
arg....found something...
grab 3.0.6
At least there should be a better error now.
Rick Davies
@rickydazla
ok
04:28:14 pm - Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/th
emes/taylorstitch/theme/assets'
=== START OF OUTPUT ===
{ Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/taylors

titch/theme/assets'
  cause:
   { Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/tayl
orstitch/theme/assets'
     errno: -17,
     code: 'EEXIST',
     syscall: 'mkdir',
     path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/assets' },
  isOperational: true,
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/assets' }
==== END OF OUTPUT ====
Bryan Morris
@internalfx
hmm....I wonder if that is MAC specific?
I basically tell the OS to make the folder if it doesn't exist....
Rick Davies
@rickydazla
it does already exist
i’m (re)downloading an existing theme
to check if there are updates on the live site that were made by administrators and 3rd party apps
… which is why I wonder if I should be running qs theme watch --sync instead
Bryan Morris
@internalfx
no...download is what you want...
That is why I'm curious if this is something MAC does differently....my machine seems to silently ignore mkdir if the folder exists.
So it produces no error and writes the file.
Rick Davies
@rickydazla
oh oh i see
¯_(ツ)_/¯
Bryan Morris
@internalfx
give 3.0.7 a whirl
I wrapped the mkdir logic in a try lets see if it works now...
It may just be something I need to do to properly support MAC
Rick Davies
@rickydazla
whoah
04:39:34 pm - Downloaded templates/gift_card.liquid
{ Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/taylors
titch/theme/templates/customers'

  cause:
   { Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/tayl
orstitch/theme/templates/customers'
     errno: -17,
     code: 'EEXIST',
     syscall: 'mkdir',
     path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers'
},
  isOperational: true,
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers' } '
the folder is already there'
04:39:34 pm - Downloaded templates/customers/register.liquid
{ Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/taylors
titch/theme/templates/customers'
  cause:
   { Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/tayl
orstitch/theme/templates/customers'
     errno: -17,
     code: 'EEXIST',
     syscall: 'mkdir',
     path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers'
},
  isOperational: true,
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers' } '
the folder is already there'
04:39:34 pm - Downloaded templates/customers/reset_password.liquid
file error file error file error
Bryan Morris
@internalfx
Did it actually get the files?
Rick Davies
@rickydazla
yes
Bryan Morris
@internalfx
nice...I went ahead and kept logging the error so we could see it.
BOOM 3.0.8
I got a good feeling about this one.
it hides EEXIST errors when trying to create folders. We don't care if they already exists.
Rick Davies
@rickydazla
:boom:
thanks
Bryan Morris
@internalfx
Why linux is naturally OK with that and MAC isn't? i dunno
Appreciated the heads up and testing....
Not supporting MAC is like not supporting probably 90% of my userbase :laughing:
Rick Davies
@rickydazla
haha
Bryan Morris
@internalfx
Right, so is your config still messed up?
Rick Davies
@rickydazla
No it’s fine… I figured out what changed and did search and replace. It did reject the old config, but I had like 16 targets and I know I’m not alone in that, so my question was really if there could be an automagic way (or even docs as to what changed)?
Bryan Morris
@internalfx
right...I basically turned 3 settings into one.
To make creating configs much less tedious
Rick Davies
@rickydazla
yeah, i like it