internalfx/quickshot

A Shopify theme development tool

Rick Davies

@rickydazla

¯_(ツ)_/¯

Bryan Morris

@internalfx

give 3.0.7 a whirl

I wrapped the mkdir logic in a try lets see if it works now...

It may just be something I need to do to properly support MAC

Rick Davies

@rickydazla

whoah

04:39:34 pm - Downloaded templates/gift_card.liquid
{ Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/taylors
titch/theme/templates/customers'

  cause:
   { Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/tayl
orstitch/theme/templates/customers'
     errno: -17,
     code: 'EEXIST',
     syscall: 'mkdir',
     path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers'
},
  isOperational: true,
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers' } '
the folder is already there'
04:39:34 pm - Downloaded templates/customers/register.liquid
{ Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/taylors
titch/theme/templates/customers'
  cause:
   { Error: EEXIST: file already exists, mkdir '/Users/Rick/Sites/myshopify/themes/tayl
orstitch/theme/templates/customers'
     errno: -17,
     code: 'EEXIST',
     syscall: 'mkdir',
     path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers'
},
  isOperational: true,
  errno: -17,
  code: 'EEXIST',
  syscall: 'mkdir',
  path: '/Users/Rick/Sites/myshopify/themes/taylorstitch/theme/templates/customers' } '
the folder is already there'
04:39:34 pm - Downloaded templates/customers/reset_password.liquid

file error file error file error

Bryan Morris

@internalfx

Did it actually get the files?

Rick Davies

@rickydazla

yes

Bryan Morris

@internalfx

nice...I went ahead and kept logging the error so we could see it.

BOOM 3.0.8

I got a good feeling about this one.

it hides EEXIST errors when trying to create folders. We don't care if they already exists.

Rick Davies

@rickydazla

:boom:

thanks

Bryan Morris

@internalfx

Why linux is naturally OK with that and MAC isn't? i dunno

Appreciated the heads up and testing....

Not supporting MAC is like not supporting probably 90% of my userbase :laughing:

Rick Davies

@rickydazla

haha

Re: internalfx/quickshot#57

Bryan Morris

@internalfx

Right, so is your config still messed up?

Rick Davies

@rickydazla

No it’s fine… I figured out what changed and did search and replace. It did reject the old config, but I had like 16 targets and I know I’m not alone in that, so my question was really if there could be an automagic way (or even docs as to what changed)?

Bryan Morris

@internalfx

right...I basically turned 3 settings into one.

To make creating configs much less tedious

Rick Davies

@rickydazla

yeah, i like it

Bryan Morris

@internalfx

Now all you need is a name and the "example URL" given from the private app page.

I realized all the info I needed was in that URL so I parsed the data out of it.

I bet you noticed quickshot3 now pretty formats the quickshot.json :smile:

no super long string of JSON

Rick Davies

@rickydazla

yes, that’s great actually

b/c i usually create new targets by editing that directly but i had to beautify it each time

Bryan Morris

@internalfx

@rickydazla there is now a breaking changes section....

https://github.com/internalfx/quickshot/#migrating-from-2x-breaking-changes

Rick Davies

@rickydazla

now we’re cookin on gas!

Trajce

@trajce

I just checked this thread, so qs v3 is official :D

Ill give it a try on windows 10 and ping you back if i got any specific notes

Bryan Morris

@internalfx

@trajce Please Do! I work and develop on Linux so it's a big help when people let me know problems they find on other platforms

Trajce

@trajce

It seems like its working fine, no issues so far on windows.

Rick Davies

@rickydazla

@/all anyone else seeing this? internalfx/quickshot#68

Winston Hughes

@hughker

@rickydazla I haven't seen that, but I'm also running an older version, sorry

Trajce

@trajce

@rickydazla im getting this one when the internet connection drops, or when i have router issues

Rick Davies

@rickydazla

@trajce makes sense

Winston Hughes

@hughker

@internalfx when i'm uploading a page, the uploaded file appears to be closing out certain elements by itself and adding some as well. is this an issue with quickshot or is that something on Shopify end once it's uploaded they're trying to "fix" the html or something?

here is a gist for the original+rendered HTML » https://gist.github.com/hughker/b1d67dd463cf728a51a9c14371196214

you'll notice there are a bunch of </a> randomly added and the first <a> at line:3 is also closed out

let me know your thoughts, thanks!

Winston Hughes

@hughker

@internalfx i think i've nailed it down to a Shopify issue… it likely sees the first open <a> and is like "oh hey, they didn't close it, we'll close it for them and in turn mess everything up for them!"

appears to be another limitation of the Shopify Admin Page Editor

Where communities thrive

People

Repo info

Activity