@calvinbaart I'm not sure, but people have reported issues previously, and someone even submitted this to their repo: mockery/mockery#897. Posting this here just in case it helps you in any way.
Thanks! It seems my issue is related to some conditional compilation of classes in Mockery, not sure how PeachPie should handle that. Basically it has the following classes: MockeryTestCaseSetUpForV7AndPrevious and MockeryTestCaseSetUpForV8 and uses an if-statement to determine which of the two to alias:
if (class_exists('PHPUnit_Framework_TestCase') || version_compare(\PHPUnit\Runner\Version::id(), '8.0.0', '<')) {
class_alias(MockeryTestCaseSetUpForV7AndPrevious::class, MockeryTestCaseSetUp::class);
} else {
class_alias(MockeryTestCaseSetUpForV8::class, MockeryTestCaseSetUp::class);
}That causes issues in PeachPie, PeachPie seems to think that MockeryTestCaseSetUp doesn't exist. (I guess that the if-statements aren't evaluated at compile time?)
I'm working on a more minimal test-case but haven't had much luck yet
https://github.com/calvinbaart/laravel-peachpie-sample/tree/feature/laravel-sdk/Laravel.Tests
I'm currently working on it here, trying to work-around some issues though
I'm currently working on it here, trying to work-around some issues though
Finally figured out the issue with Mockery :) I have created a minimal test case for it here: peachpiecompiler/peachpie#465
Great, thanks @calvinbaart. As Jakub mentioned, this is because
Bar cannot be resolved at compile time and has to be dynamically compiled during runtime, which is a feature that's on the roadmap, but not until after version 1.0. For now, the workaround is to add a use statement, as follows:use Foo as Bar;
Thanks :) Got something running after a few patches ( https://github.com/calvinbaart/laravel-peachpie-sample/tree/feature/laravel-sdk/Laravel.Tests/patches ): https://pastebin.com/TKJvucgB
I'll write something up after making it a bit more....user-friendly. Still requires alof of user-actions (like the view:cache etc.) to make sure it even runs (and I haven't even touched anything database-related yet...) Still good to see that most of the routing stuff and the container system from laravel function in PeachPie.
Well, with a few hacky-workarounds in the PeachPie compiler itself, some patches made to phpunit/mockery and the fixes made by Jakub I can finally run the full test suite without it crashing somewhere in the middle. Current results are:
Tests: 3742, Assertions: 5375, Errors: 1521, Failures: 151, Warnings: 7, Skipped: 17.
Alright, setup travis-ci to autorun the unit tests: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/123644740 it will automatically pull in the latest peachpie master so that should give some diagnostics into the state of laravel
@jakubmisek I would like to verify if #485 is now correct but I can't seem to run PHPUnit anymore since the latest changes. Seems to be related to the dynamic call to mb_substr I had earlier. Any suggestions how to fix that? I tried removing all compiled files but it still generates a dynamic call here :/
For example this single line:
echo substr("hello", 1, null) . "\r\n"; causes a crash here
@jakubmisek This exception in PHPUnit: https://pastebin.com/dy1PGB5g When I run the single line above I get a different exception though:
Unhandled Exception: System.NotImplementedException: costof(System.Object -> System.Int32)
at Pchp.Core.Dynamic.ConvertExpression.BindCost(Expression arg, Type target)
at Pchp.Core.Dynamic.OverloadBinder.ArgumentsBinder.BindCostOf(Int32 srcarg, Type ptype, Boolean ismandatory, Boolean ignorecost)
at Pchp.Core.Dynamic.OverloadBinder.BindCostOf(MethodBase method, ArgumentsBinder args, BitArray costofargs, ConversionCost& minCost)
at Pchp.Core.Dynamic.OverloadBinder.BindOverloadCall(Type treturn, Expression target, MethodBase[]& methods, Expression ctx, ArgumentsBinder args, Boolean isStaticCallSyntax, PhpTypeInfo lateStaticType)
at Pchp.Core.Dynamic.OverloadBinder.BindOverloadCall(Type treturn, Expression target, MethodBase[] methods, Expression ctx, Expression[] args, Boolean isStaticCallSyntax, PhpTypeInfo lateStaticType)
at Pchp.Core.Dynamic.CallBinder.Bind(DynamicMetaObject target, DynamicMetaObject[] args)
at System.Dynamic.DynamicMetaObjectBinder.Bind(Object[] args, ReadOnlyCollection`1 parameters, LabelTarget returnLabel)
at System.Runtime.CompilerServices.CallSiteBinder.BindCore[T](CallSite`1 site, Object[] args)
at System.Dynamic.UpdateDelegates.UpdateAndExecute4[T0,T1,T2,T3,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3)
at <Root>.main_php.<Main>(Context <ctx>, PhpArray <locals>, Object this, RuntimeTypeHandle <self>) in /Users/calvinbaart/Development/laravel-peachpie-sample/Laravel.Tests/main.php:line 12
at <Script>.Main(String[] args)
The PHPUnit error seems to happen after this commit: peachpiecompiler/peachpie@e90646d or this one: peachpiecompiler/peachpie@6a8d3a8
@jakubmisek Actually two issues that I cant reproduce outside of the Laravel project:
- When a class inherits from Illuminate.Database.Eloquent.Model and you call the static create function on that class it will crash because the default argument for the constructor is not used and instead NULL is passed. I get this exception then:
23) Illuminate\Tests\Broadcasting\BroadcasterTest::testExtractingParametersWhileCheckingForUserAccess TypeError: Argument '1' should not be NULL /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel/src/Illuminate/Database/Eloquent/Model.php:162 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel/src/Illuminate/Broadcasting/Broadcasters/Broadcaster.php:206 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel/src/Illuminate/Broadcasting/Broadcasters/Broadcaster.php:166 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel/src/Illuminate/Broadcasting/Broadcasters/Broadcaster.php:98 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel/src/Illuminate/Support/Collection.php:1119 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel/src/Illuminate/Broadcasting/Broadcasters/Broadcaster.php:95 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel.Tests/tests/Broadcasting/BroadcasterTest.php:317 /home/travis/build/calvinbaart/laravel-peachpie-sample/Laravel.Tests/tests/Broadcasting/BroadcasterTest.php:39 - In some rare cases the traits of a class aren't initialised causing a NULL-pointer exception. Example being:
8) Illuminate\Tests\Auth\AuthGuardTest::testLoginUsingIdLogsInWithUser PHPUnit\Framework\WrappedException: System.NullReferenceException: Object reference not set to an instance of an object. at Illuminate.Auth.SessionGuard.getProvider() at <>.getProvider(SessionGuard ) at Mockery_12_Illuminate_Auth_SessionGuard._mockery_handleMethodCall(PhpValue method, PhpArray args) at Mockery_12_Illuminate_Auth_SessionGuard.getProvider(PhpValue[] <arguments>) at System.Dynamic.UpdateDelegates.UpdateAndExecute2[T0,T1,TRet](CallSite site, T0 arg0, T1 arg1) at Illuminate.Tests.Auth.AuthGuardTest.testLoginUsingIdLogsInWithUser() at System.Dynamic.UpdateDelegates.UpdateAndExecute4[T0,T1,T2,T3,TRet](CallSite site, T0 arg0, T1 arg1, T2 arg2, T3 arg3) at CallSite.Target(Closure , CallSite , TestCase , NameParam`1 , Context , UnpackingParam`1 ) at PHPUnit.Framework.TestCase.runTest()
I'm still working on creating a small test case for these, but I haven't been successfull yet.
the first error needs a test smaller case, but can be fixed then
Doesn't really do much to cause a null exception :/
I can check later, the getProvider method gets compiled to this:
public virtual PhpValue getProvider()
{
//IL_0006: Unknown result type (might be due to invalid IL or missing references)
return <>trait_GuardHelpers.getProvider();
}So I guess trait_GuardHelpers is NULL causing it to crash.
@jakubmisek I can't compile anymore after the fixes for #494 I'm getting this exception: https://pastebin.com/yzzYRbUS
Seems to be locally, Travis is still able to build. After the latest changes the failed tests dropped by from 1024 -> 631:
Tests: 3742, Assertions: 7499, Errors: 631, Failures: 163, Warnings: 10, Skipped: 89.https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/124250409
Still getting the exception related to getProvider on Travis, thought that the fix for #494 would solve it. I'll look into that one further