iolevel/peachpie

PeachPie - The PHP Compiler and Runtime for .NET & .NET Core

Calvin Baart

@calvinbaart

Yea, I removed a few patches though so its probably related to that (Carbon had a patch related to getLastErrors and setLastErrors, so its probably that)

These two:
https://github.com/calvinbaart/laravel-peachpie-sample/commit/bdb3ee2cdfe8c2cb2aed4ebed1544b6486a8246c#diff-6d8766c068db9a9ff2440695bf5676ae
https://github.com/calvinbaart/laravel-peachpie-sample/commit/bdb3ee2cdfe8c2cb2aed4ebed1544b6486a8246c#diff-40b9df2d95d212af148651d308dde70b

Jakub Míšek

@jakubmisek

maybe, but this one is about expecting an array as argument but getting something else when calling a method inside __construct

thanks, Creator2 seems to be that

Calvin Baart

@calvinbaart

getLastErrors in peachpie has the [return: CastToFalse] attribute, but according to the documentation getLastErrors should always return an array. Maybe thats the problem

Jakub Míšek

@jakubmisek

just found it! you're right. I'll double check but I think even PHP returns FALSE if none of date functions were called yet

Calvin Baart

@calvinbaart

With #535 closed can we now require non-compiled .php files?

Jakub Míšek

@jakubmisek

@calvinbaart we've changed the getLastError() implementation so it never returns FALSE. Note in PHP it does return FALSE sometimes but it is not documented and I think developers (and frameworks) do not expect it anyway.

The only scenario where it can be used would be if someone would like to check if any of date-parsing function were used already by checking getLastError() is FALSE.

Calvin Baart

@calvinbaart

Great! Just triggered a new build to see if this resolves the issue: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/127997383

Jakub Míšek

@jakubmisek

thanks!

@calvinbaart the #535 only adds necessary API so w can get it implemented in future, but the whole eval() think is not ready for it yet. Note compiler needs the whole context, all the classes and dependencies. It cannot just compile a piece of it, or at least not efficiently.

We will use it for implementing FIleProviders in ASP.NET Core, so we can pack all the content files (.js, .css,...) into a .NET resource and serve it from there, and PHP's file functions will treat it like it is saved physically on disk.

Calvin Baart

@calvinbaart

That sounds interesting, Would be pretty useful for Laravel :)

Jakub Míšek

@jakubmisek

yes, basically the entire PHP component/web (like the entire wordpress) can be distributed and published as a single DLL file (approx 20MB large)

@calvinbaart we have changed the project's version from 0.9.9 to 1.0.0 (-dev)!

preparing for -alpha, -beta and -rc

Calvin Baart

@calvinbaart

Ic, I won't be able to change the versions now so I guess that will have to wait till tonight

Jakub Míšek

@jakubmisek

sure, thank you :)

smx

@smx-smx

thanks for replies @jakubmisek :)

thanks for the awesome work btw

Musti132

@Musti132

Any news on pthreads?

Calvin Baart

@calvinbaart

@jakubmisek After the latest fixes I started getting the compile crash again (perhaps I'm doing something wrong with the version?) so I tried building PeachPie in Debug for extra information but this gives the following assertion when compiling Laravel: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/128080202

Jakub Míšek

@jakubmisek

@calvinbaart let me add some more debug information

@smx-smx thanks!

@Musti132 no news

Calvin Baart

@calvinbaart

@jakubmisek Retriggered the build, this is the assertion message: Argument for params is expected to be of type PhpValue[], at Headers::__construct(). It looks like a PHP error so I'll look into it when I'm home

Jakub Míšek

@jakubmisek

thanks, seems a __construct() vararg argument might be type-hinted?

Calvin Baart

@calvinbaart

Yea, I'll need to find that class to see whats going wrong. Thanks for adding the debug messages, that atleast gives me some clue :)

Jakub Míšek

@jakubmisek

looking for the class as well :)

Calvin Baart

@calvinbaart

Perhaps its this one: https://github.com/symfony/symfony/blob/b36961c36a0698568e1f09e8d373e5fab1c4c498/src/Symfony/Component/Mime/Header/Headers.php

Contains a type-hinted vararg constructor aswell

Jakub Míšek

@jakubmisek

yes (HeaderInterface ...$headers) thanks!

test case, pretty simple:

class X {
    function __construct(int ...$args) {
        //print_r( $args );
    }
}

Jakub Míšek

@jakubmisek

fixed, thanks @calvinbaart :)

Calvin Baart

@calvinbaart

Great thanks, I'll trigger the build again

Calvin Baart

@calvinbaart

New assertion: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/128180929

Jakub Míšek

@jakubmisek

I guess you have enabled debug build :)

Calvin Baart

@calvinbaart

Yea....I should probably have enabled it sooner (because of all the assertions I should have hit)

Daniel Llewellyn

@diddledan

only one override in WordPress now! iolevel/wpdotnet-sdk#45

Jakub Míšek

@jakubmisek

@calvinbaart should be fixed in latest commit

This message was deleted

@diddledan thanks! what is the last override? that PEAR_Error ?

Calvin Baart

@calvinbaart

Ah debug build....: https://travis-ci.com/calvinbaart/laravel-peachpie-sample
I'll try building in Release...

Jakub Míšek

@jakubmisek

well the debug build should pass as well :) so feel free to keep it, we have to fix all the assertions anyway

seems this is not an assertion btw

Jakub Míšek

@jakubmisek

looks like eval() created the same class twice

Daniel Llewellyn

@diddledan

@jakubmisek yeah, the last one is an

if (class_exists('PEAR_Error')) {
    class foo extends PEAR_Error {}
}

Calvin Baart

@calvinbaart

@jakubmisek I linked the wrong one, this was the build with the failing assertion: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/128209553

Jakub Míšek

@jakubmisek

@calvinbaart thanks! working on it

Jakub Míšek

@jakubmisek

@calvinbaart as I see the most recent issue is the __destruct() being called (in .NET by the Garbage Collection) and crashes

Where communities thrive

People

Repo info

Activity