Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Jakub Míšek
@jakubmisek
Thanks @calvinbaart the assertion might be cause of it, but who knows :) will try to fix it and try your project
Dani Llewellyn
@diddledani
in PeachPied.WordPress.AspNetCore/RequestDelegateExtension.cs there's a reference to WP as a type both in code an documentation comments. VS complains that the type is undefined. This type is defined in the WordPress PHP code IIRC. Is there something we can do to let VS know about it for better "go to definition" and such?
Dani Llewellyn
@diddledani
no idea what this one is doing:
Severity    Code    Description    Project    File    Line    Suppression State    Suppression State
Error    PHP1018    Class 'WPMailSMTP\MailCatcher' doesn't implement abstract method System\IDisposable::Dispose()    net.WordPress.plugin.wp-mail-smtp    C:\Users\yabea\source\repos\diddledan\bowlhat-wpdotnet\net.WordPress.plugin.wp-mail-smtp\wp-content\plugins\wp-mail-smtp\src\MailCatcher.php    16
Dani Llewellyn
@diddledani
this is the most reduced I can make that failure - it's got a copy of WPDotNet rather than relying on the -beta8 release because it only fails with master: https://github.com/diddledan/WPDotNet-PP-0.9.500-Inheritance-Test/tree/master/Inheritence%20Test
Jakub Míšek
@jakubmisek
@diddledan once you compile the WP project, the reference to WP class will be resolved
@diddledan hmm the error might be caused by mismatch in PeachPie versions
Jakub Míšek
@jakubmisek
@calvinbaart getting stack overflow in my test case as well, traits need some fixes when they are compiled in a separate assembly and referenced
Calvin Baart
@calvinbaart
Great that you found it! In the future should I just create a ticket on github for it? (I'm a bit weary to create github issue's without providing any information)
Jakub Míšek
@jakubmisek
@calvinbaart if you'd know the issue :) create a ticket please, but this one was pretty tough ...the latest commit peachpiecompiler/peachpie@e7c7d08 fixes several issues with traits being used from within a compiled library
Calvin Baart
@calvinbaart
@jakubmisek Yea, it's more that build issues just saying "Stack overflow" will be quite hard to create a proper ticket for. Seems that I'm still getting the Stack Overflow with the latest commit: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/134230099
Jakub Míšek
@jakubmisek
@calvinbaart thanks, so there is more occurances of the issue, will be fixed!
Jakub Míšek
@jakubmisek
@calvinbaart assertion was fixed, now getting the stackoverflow as well :)
Jakub Míšek
@jakubmisek
got the test case :/
trait A {
    function foo($a = XXX) {
    }
}

trait B {
    use A;
}
Calvin Baart
@calvinbaart
Traits cause all kind of fun issues don't they?
Jakub Míšek
@jakubmisek
@calvinbaart yep laughing all the day
@calvinbaart ok the laravel-sample project compiles for me now :)
Calvin Baart
@calvinbaart
nice! I'll start a new build on Travis
Jakub Míšek
@jakubmisek
@calvinbaart I see a few new issues, will try to make tests for them a fix
Jakub Míšek
@jakubmisek
@calvinbaart the compile issue should be fixed now, please try again :)
Calvin Baart
@calvinbaart
@jakubmisek Started: https://travis-ci.com/calvinbaart/laravel-peachpie-sample/builds/134558814 I didn't even notice the previous failure yet so that was a quick fix :)
Jakub Míšek
@jakubmisek
thanks :)
Jakub Míšek
@jakubmisek
ok it broke something else :) at least I have a test case
Calvin Baart
@calvinbaart
I also removed a few patches a few days ago because (in theory) they shouldn't be needed anymore. We'll need to see how that works out (only impacts the actual tests though)
Jakub Míšek
@jakubmisek
I'm trying it locally and actually not applying those patches at all .. but it is good to remove them slowly :)
Jakub Míšek
@jakubmisek
@calvinbaart few other fixes for the latest issue commited :)
Calvin Baart
@calvinbaart
It goes a bit further now but skips almost all the tests....I'll have to look into that when I'm home
(Perhaps I should also set up the automated testing for PHPUnit so that we can verify if PHPUnit itself functions correctly)
Jakub Míšek
@jakubmisek
finaly it compiles ...
Array looks like something is doing echo on an array value
Calvin Baart
@calvinbaart
Yea, perhaps one of the patches was still needed (I had some patches for PHPUnit as well)
Calvin Baart
@calvinbaart
@jakubmisek I figured out what is going wrong but I'm still trying to create a test case for it:
  • PHPUnit calls static Test::getMissingRequirements() to figure out if it can run the test
  • getMissingRequirements has a $missing where it stores the missing requirements. This variable is initialized to an empty array at the start of the method.
  • After a specific test $missing is filled suddenly with data (even though its initialized to an empty array at the start).
  • This specific test also has a $missing variable. My theory is that somehow this $missing overrides the local $missing in the getMissingRequirements method. Still trying to figure out a minimal test case for this.
The test that creates the problem is testBasicModelRetrieval
Jakub Míšek
@jakubmisek
@calvinbaart do you have any new test cases? :)
The issue peachpiecompiler/peachpie#252 is mostly fixed, this should allow more tests to pass
Calvin Baart
@calvinbaart
@jakubmisek Still seeing it skip a lot of tests.....haven't figured that one out yet (I think it has to do with a certain combination of code and eval but I haven't cracked that one yet)
Jakub Míšek
@jakubmisek
@calvinbaart meantime we fixed a lot of things with parameters, parameters by ref and default parameters
Prem Murmu
@prem16
'Peachpie.NET.Sdk/0.9.500' specified could not be found
unable to load PeachPied.WordPress
Benjamin Fistein
@bfistein
@prem16 we'll need a little more than that please.
Anthony Turley
@Southerndeep_twitter

Hey guys I'm working on the peachpie / wordpress-sdk implementation. Awesome work btw! I'm trying to deploy my project to a linux vps with ubuntu 18.04. I've been following this tutorial to get the server setup: https://linuxhint.com/install_dot_net_core_ubuntu/

But this tutorial shows how to create a new project on the server. My use case is that I already have a project. Any reading material or suggestions would be great.

Anthony Turley
@Southerndeep_twitter
I didn't go the docker route for setting up mysql. Instead I used xampp, deleted the default "any" user and set a password for the root because it was complaining without. Everything worked like a charm from there.
Just stomped on how to deploy.
Anthony Turley
@Southerndeep_twitter

Lastly, here is the tutorial I was following from Microsoft but they use CentOS and not Ubuntu.

https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/linux-apache?view=aspnetcore-3.0

L!εsAμεr
@liesauer
@jakubmisek no get_Item method now? i have upgraded peachpie from 0.9.44 to 0.9.500.
image.png
image.png
L!εsAμεr
@liesauer
interesting, the top exception occurs because of can not find the resouces dll
L!εsAμεr
@liesauer
{
System.IO.FileNotFoundException: Could not load the specified file.
File name: 'Peachpie.Runtime.resources'
   at System.Runtime.Loader.AssemblyLoadContext.ResolveUsingEvent(AssemblyName assemblyName)
}
Jakub Míšek
@jakubmisek
@Southerndeep_twitter Have yo u been able to run a sample Hello World app? I can help from there
@liesauer PeachPie is the exception handled or unhandled? Because .NET always tries to load **.resources assembly even it does not exist.
Jakub Míšek
@jakubmisek
@liesauer get_Item() might be inaccessible, we need a test case for this feature (it is a workaround for calling an object indexer [] right?)