@minrk question on the contents API: should it be legal for a contents manager to delete its own root directory? The current test suite seems to very explicitly avoid that operation, but I think it "works" with the current implementation
but that leaves the notebook in a totally broken state
or rather, the notebook app
(specifically, all requests to the root page result in a 404)
It's up to the contents service to keep itself making sense. Deleting / doesn't make a lot of sense, but I guess it's allowed.
The Files implementation should probably 400 when attempting to delete root.
I opened ipython/ipython#8168 as a suggestion
I think that makes sense.
I'm having a hard time imagining a scenario where deletion of root would be allowed
b/c, necessarily, it means that listing root returns a 404
Right.
@jdfreder - thanks for looking at the custom serialization PR
@jasongrout np, I'm still looking- was AFK for a bit because my laptop ran out of batteries and the StarBucks I was at blocked all of their outlets. : /
I think this PR brings up larger discussions about communicating metadata across the wire.
one thing that I'm not very happy about in this PR is that the serialization metadata is transferred across the wire every single time a value is synced
(if there is custom serialization)
I think it would be much cleaner if the protocol was agreed upon in advance, and the js side took care of its serialization, and the python side took care of its serialization
instead of the python side telling the js side how to do its serialization
so, for example, the js box widget would know, by itself, which fields it had to check for references to other widgets
and independently, the python side box widget would know the same.
but there are still things in the PR that should be pushed forward, like binary messages in both the sync and custom messages
@rgbkrk can't wait for the binary messages :).
All right, I'm going to make one more change to the PR. Instead of the serialization metadata being sent with a sync message, you'll have to declare it up front in a js class, similar to the to_json and from_json metadata for a traitlet on the python side.
Is there a problem with TravisCI?
What are you seeing? Github has been up and down today..
Hmm, I'm loading an IPython notebook, and somehow the SVG in there doesn't render correctly
it renders fine in the nbviewer or if I re-execute the cell
I added the Chrome inspection thing; it's not SVG for some reason
I'm running IPython 2.4.1
Your notebook is probably untrusted;
Go to file menu and trust it (You know what this means, and if it ever get malicious content then it can errase your hard drive and steel your email credential)
save and reload.
it shows up on nbviewer
also, why would it convert SVG to text?
is SVG that much unsafe compared to a PNG?
I might just replace my SVGs to PNGs directly in the ipynb JSON, so that people can open it ok
because SVG can contain javascript.
and it does not "convert"
you have all the format, it oly show you the "safe" one when it cannot determine wether you are the author of the notebook or not.
You are not authenticat on nbviewer, so you don't risk anything we can show "unsafe" content;
and yes, SVG is much more unsafe than PNG as in this context SVG could steel your credit card information if they are on your machine and install a backdoor, where PNG cannot.
@jdfreder: are you looking at my PR now?
I have some pretty fundamental changes to how it works I want to push :)
there is an output "html" with a <svg> in it
and an output "text" with different content
what it's showing is the "html" one, with the SVG replaced by the two strings that are in there (supposed to be in <text> elements)
so I do call this converting
I'm ok with not displaying the HTML, but mangling it...
it looks like it just strips all HTML tags
@jasongrout I'm looking forward to the binary messages too
;)
what is the correct procedure to pip install the jupyter_* directories of the big split?
None right now.
and the incorrect procedure ? :)
ALmost everything :-)
incorrect procedure:
sudo rm -rf /
(please don't try that at home!)
sudo rm -rf / actually works but has the inelegance of ending up with an error message
please try
--no-preserve-root
right, I was just going to do that... :)
@jdfreder: I'm much happier now with the design on ipython/ipython#7757. I think it's really, really ready for review now :).
@SylvainCorlay only editable installs (
pip install -e) are going to work while the separate packages haven't actually been created
@minrk do you want to force push on master to unmerge ?
github works great even under heavy DDOS
Can someone kick #7757? I think it's a Travis error...
Ok
Done.
Thanks; it passed now!
did you eventually force-push something to master?
(I am i the middle of a big rebase)
seems you did :)
A PR was merged into master that shouldn't have been. It was only on master for about 30 seconds.
I specifically reverted it so you wouldn't have to rebase. Sorry!
I can un-revert it easily enough, if that would make it easier for you.
@SylvainCorlay it looks like you already did a rebase on the split kernel. I can reapply that split.
as you prefer
@SylvainCorlay would you prefer that I reapply the split on master so you can keep your rebase?
I did the revert specifically to make your PR easier, so if you've already done the rebase and are happy with it, I can put the original state back.
just let me know what you do
How did you do the rebase?
pfiou, back online
you can do as you want.
either reset master to where you were a few minutes ago
or i can rerebase
damnit. A PR has been merged since the revert, so I can't easily un-revert anymore.
lol
You can use
git reflog to find the state before you did the rebase.
I can't believe we managed to time it that you pulled and rebased in the less than a minute that IPython master had that PR merged.
yes, I fetched upstream at the exact wrong time
no problem, I can rebase again
Sorry, I messed everything up trying to make it easier.
You shouldn't have to if you get the commit before you rebased via
reflog
I probably have a bookmark of the commit number somewhere
btw, the tip of master cannot start a notebook
"/home/sylvain/ipython/IPython/nbformat/validator.py", line 71, in get_validator IOError: [Errno 2] No such file or directory: '/home/sylvain/ipython/IPython/nbformat/v4/nbformat.v4.schema.json'
reflog should look something like:
a638031 HEAD@{12}: rebase: s/IPython.kernel/jupyter_client in jupyter_client
f64f916 HEAD@{13}: rebase: move client code from IPython.kernel to jupyter_client
865ed70 HEAD@{14}: rebase: checkout master
e72a229 HEAD@{15}: commit: your last commit <- this is the last state before rebase
@SylvainCorlay hm, that should have been fixed by #8167
tip of master has no
IPython/nbformat/validator.py
Might need a
git clean for the removed files.
pyc