These are chat archives for ipython/ipython

28th
Mar 2015
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 00:13
ok, did some cherry-picking eventually.
waiting for travis
Min RK
@minrk
Mar 28 2015 00:14
ok, great. Thanks, and sorry for the trouble.
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 00:16
there is still profile_dir = Instance(ProfileDir, allow_none=True) where I could remove allow_none=True probably, but the _default_profile_dir may just return
Min RK
@minrk
Mar 28 2015 00:17
I think the multi-stage initialization means that profile_dir can be requested before it's set up, so you can leave that one.
I looked it over, and I think the ones that are left should be fine. We can pare them down later on if we can figure out how to avoid validating unused defaults after init.
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 00:21
great
it seems the tests are failing in the last job
the previous one with the missing comma had some tests passing. I think that these failures are unrelated.
Min RK
@minrk
Mar 28 2015 00:23
I think there's a missing allow_none=True on IPython.core.application.BaseIPythonApplication.profile_dir
That's the one you were just talking about, right?
It can probably be fixed to not need allow_none, but I don't think you need to do it in this PR.
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 00:29
yes
I am starting to get green checks... Hopefully I won't be holding you up much longer
Min RK
@minrk
Mar 28 2015 00:32
No problem, thanks for all the extra rebase work.
Should get the last green light in another minute or so.
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 00:35
thanks for getting this in now. It would have been complicated after the split
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 04:35
hello, can someone kick #8142 ?
Matthias Bussonnier
@Carreau
Mar 28 2015 04:37
done
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 04:37
thanks
what does a gray test mean? is is a timeout?
This message was deleted
Sylvain Corlay
@SylvainCorlay
Mar 28 2015 04:55
This message was deleted
This message was deleted
This message was deleted
Matthias Bussonnier
@Carreau
Mar 28 2015 05:07
Grey meen cancelled or timeout IIRC.
Min RK
@minrk
Mar 28 2015 05:47
It timed out. that's been happening a bit. I restarted it and it's green now.