These are chat archives for ipython/ipython

1st
Dec 2015
Sylvain Corlay
@SylvainCorlay
Dec 01 2015 20:29
@rmorshea @takluyver I would like to merge ipython/traitlets#141 so that it does not break notebook. Do you have any concern with the test of the PR?
Ryan Morshead
@rmorshea
Dec 01 2015 20:32
@SylvainCorlay, no issues for me. whether or not to call instance_init can be addressed in a seperate pr.
Or issue
Min RK
@minrk
Dec 01 2015 20:34
@SylvainCorlay go for it
Jason Grout
@jasongrout
Dec 01 2015 21:16
@bollwyvl - is nbbrowserpdf ready for production deployment?
we had lots of issues with generating pdfs in Sage from notebooks
nbbrowserpdf might be a much better way to do things.
@williamstein ^
Jason Grout
@jasongrout
Dec 01 2015 21:24
@blink1073 - I'm about to update jupyter-js-input to have relevant frontmatter. Does your https://github.com/blink1073/jupyter-js-front-matter still represent the 'best practices'?
Steven Silvester
@blink1073
Dec 01 2015 21:37
let me check
yep, go for it
Jason Grout
@jasongrout
Dec 01 2015 21:56
thanks
Jason Grout
@jasongrout
Dec 01 2015 23:09
@blink1073 - the npm run test:coverage reports 100% coverage with just the single 'should always pass' test.
clearly something is wrong. How do I tell it that I actually have 0% test coverage?
Steven Silvester
@blink1073
Dec 01 2015 23:10
you have to import the library code
Jason Grout
@jasongrout
Dec 01 2015 23:11
so I actually did import (but not used) the code...
Steven Silvester
@blink1073
Dec 01 2015 23:11
yeah, if you don’t use it, it gets compiled away AFAIK
Jason Grout
@jasongrout
Dec 01 2015 23:12
ah, right
ah, I have to npm run build:test to compile it in the first place...
Steven Silvester
@blink1073
Dec 01 2015 23:14
that should be part of your build script
and it is, looking at your PR
Jason Grout
@jasongrout
Dec 01 2015 23:15
I was just doing npm run test:coverage. Forgot to build. Now I'm getting build errors (for css), but at least I'm getting somewhere
Steven Silvester
@blink1073
Dec 01 2015 23:15
ha, okay
Jason Grout
@jasongrout
Dec 01 2015 23:22
I'm getting the same browserify error I used to get
Steven Silvester
@blink1073
Dec 01 2015 23:22
for css?
Jason Grout
@jasongrout
Dec 01 2015 23:22
ERROR [framework.browserify]: bundle error
ERROR [framework.browserify]: SyntaxError: Unexpected token (4:0) while parsing [snip]/jupyter-js-input-area/node_modules/codemirror/lib/codemirror.css while parsing file: [snip]/jupyter-js-input-area/node_modules/codemirror/lib/codemirror.css
Steven Silvester
@blink1073
Dec 01 2015 23:23
that means the transform did not work
looking...
Jason Grout
@jasongrout
Dec 01 2015 23:23
I just pushed to my PR
Jason Grout
@jasongrout
Dec 01 2015 23:29
Making that css file it complains about empty makes everything work
so it really is that css file.
it seems that maybe it's not treating that file as css?
(if you have time to talk about this...)
Steven Silvester
@blink1073
Dec 01 2015 23:30
Jason Grout
@jasongrout
Dec 01 2015 23:31
yeah, I thought.
Steven Silvester
@blink1073
Dec 01 2015 23:32
ohh, your test is not creating a browserify bundle
I missed that
Jason Grout
@jasongrout
Dec 01 2015 23:32
?
Steven Silvester
@blink1073
Dec 01 2015 23:33
wait, no, nevermind
nothing is jumping out at me, mind waiting until the morning?
Jason Grout
@jasongrout
Dec 01 2015 23:36
sure
Steven Silvester
@blink1073
Dec 01 2015 23:36
k, have a good night
Jason Grout
@jasongrout
Dec 01 2015 23:36
or I'll keep looking at it for a bit
good night