These are chat archives for ipython/ipython

16th
Nov 2018
vipin kumar
@uservipin
Nov 16 2018 04:11
hi
Guy Sviry
@guysv
Nov 16 2018 15:27
@minrk actually, it seems IPython used the module win_unicode_console which seems to sort the unicode problem for python2. (as seen [here] (https://github.com/ipython/ipython/blob/a28a4445f6891ea02afc13eb0535711ac2119069/IPython/terminal/interactiveshell.py#L422))
I would love to patch jupyter_console to use it too, but it seems you guys are ready to drop python2 support
Min RK
@minrk
Nov 16 2018 15:28
yeah, IPython has done that already, and several other packages, too.
(current IPython is 7.0)
Guy Sviry
@guysv
Nov 16 2018 15:30
if I patch jupyter_console, could you consider a python2 release?
if you're not, im cool with forking.
Min RK
@minrk
Nov 16 2018 15:35
We'd need to make a 5.x backport branch, but I think we can do that
Guy Sviry
@guysv
Nov 16 2018 15:38
sounds great :D please ping me if you do that.
Min RK
@minrk
Nov 16 2018 15:58
5.x branch is up
Guy Sviry
@guysv
Nov 16 2018 16:04
alright!
Guy Sviry
@guysv
Nov 16 2018 17:25
pull request is up :)