Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Sean Poulter
    @seanpoulter
    What's the chance you've got contributor access to https://github.com/wmhilton/isomorphic-pgp as well @jcubic?
    While running the unit tests a bunch I hit this edge case - https://github.com/wmhilton/isomorphic-pgp/blob/master/src/util/trimZeros.js#L14.
    Jakub T. Jankiewicz
    @jcubic
    Uh, I don't have access it's his private repo, but I can ask @wmhilton to migrate that repo to organization.
    Can you explain what is the issue? You've run unit test of isomorphic-git?
    Sean Poulter
    @seanpoulter
    Yea, I've been running the unit tests to find out why there's an intermittent failure. The signed commit doesn't work now and then.
    One of the failures had an obvious error message I traced back to another repo. I opened a PR up:
    wmhilton/isomorphic-pgp#5
    Jakub T. Jankiewicz
    @jcubic
    ok will write to him on twitter, last time he said that he don't visit twitter too often so it may take some time
    Sean Poulter
    @seanpoulter
    All good. I still haven't figured out the root cause of the signing issue.
    Jakub T. Jankiewicz
    @jcubic
    when I contact him I usually use Twitter
    Sean Poulter
    @seanpoulter
    Ah, cool. The disconnects from SauceLabs are happening way more frequently anyways. Womp womp.
    Sean Poulter
    @seanpoulter
    How'd restarting the release build go?
    Still fail?
    Jakub T. Jankiewicz
    @jcubic
    I didn't restarted the build yet
    But I've got email from pgp, I need to check if I'm an admin
    Sean Poulter
    @seanpoulter
    Oh? Where are we using pgp?
    Sean Poulter
    @seanpoulter
    @jcubic, what was the warning you're getting for the SauceLabs proxy? Could you forward that on to me if you want me to have a look? I'm a bit worried that we'll have to nudge the SauceLabs karma plugin on another project. It might be good to get that going sooner rather than later.
    jeff-simeon
    @jeff-simeon
    Hi - does anyone know how I might delete and commit a file using writeCommit? I'm trying to do these operations without having to checkout the repo files into the fs in order to optimize performance. As I understand it, to create a commit without actually operating on the fs, I should writeBlob for the files I want to add/change, then writeTree with TreeEntries for the blobs I wrote, then writeCommit for that tree. This all seems to work, but I'm not sure how to include deletes in my commit. Can someone please point me in the right direction? Thank you!
    Jakub T. Jankiewicz
    @jcubic
    @jeff-simeon Sorry I have no idea how to help you. The only way you can figure that out would be to look into source code and see what isomorphic-git does under the hood
    @seanpoulter this is PGP wmhilton/isomorphic-pgp#5 that PR you sent
    I've got email, but I'm not an admin of that repo, I've got email because you mentioned me in the message
    Jakub T. Jankiewicz
    @jcubic
    I will be unavailable today and probably tomorrow. I'm traveling
    Jakub T. Jankiewicz
    @jcubic
    @seanpoulter what's wierd is that SauseLabs shows that all tests passes
    the last failed test according to SL was on Saturday, May 14th
    Jakub T. Jankiewicz
    @jcubic
    @seanpoulter do you still want to work on the project? What we will do next? If you will not work on the project anymore I will need to rollback your changes and remove update of async package, since that one cause issues with timeout errors from unit tests.
    Sean Poulter
    @seanpoulter
    Hey Jakub, yes, let's drive this forwards. When I look at the failing pipelines here - https://dev.azure.com/isomorphic-git/isomorphic-git/_build?definitionId=4 - and look at the first failing test results the unit tests failed because of a flaky test which is retried. Android disconnected at line 1709, 1970. The rest results on line 3806 don't include all 448 tests for Android 10 because both runs disconnected. It disconnects again on lines 3925 and 4440 so the results on line 5084 are also incomplete.
    My thoughts are retry to confirm it is a SauceLabs issue.
    I'm OK if we revert the PRs.
    I'd suggest we focus all our efforts on the Android 10 disconnects. Is is possible to set me up so I can run Sauce Labs locally to troubleshoot that?
    Jakub T. Jankiewicz
    @jcubic
    ok I think that I will later tomorrow maybe write an email to SauseLabs supports with my issue. Maybe also for Azure, since the error happen only there. It looks fine on SauseLabs. I will also try to find some solution in Google tomorrow, maybe someone has similar issue. Maybe before we start we can ask on some StackExchange site, but I'm not sure if StackOverflow is the right one.
    Sean Poulter
    @seanpoulter
    Let me know if you need any input for those.
    Jakub T. Jankiewicz
    @jcubic
    I din't find time today and tomorrow I'm going for a trip will be back in sunday. But Monday I have day off so If I will not find time on Sunday will do this on monday
    Sean Poulter
    @seanpoulter
    All good. Enjoy the trip!
    It might be worth spending a little time to explore the logs on SauceLabs to see if we can find out why the Android sessions are disconnecting.
    Sean Poulter
    @seanpoulter
    Would you and can you add me as a user on SauceLabs?
    https://docs.saucelabs.com/basics/acct-team-mgmt/adding-deactivating-users/
    Jakub T. Jankiewicz
    @jcubic
    Do you have an account or do you want invitation? Which email should I use?
    Sean Poulter
    @seanpoulter
    I don't have an account but I can make one quick if that'll work. My email address is in your DM.
    Jakub T. Jankiewicz
    @jcubic
    No, I can invite you and you will be able to create account without the need to confirm your email, so it will probably be faster
    invitation sent
    Sean Poulter
    @seanpoulter
    Thanks. That'll help test a hypothesis.
    I found a SauceLabs support article that says it could be the test runner timing out for a given test. We do change the test timeout but it may not apply to every test.
    I'll open a PR to change it globally and also see if I can find more info in the logs while you're out.
    Sorry in advance. You'll probably get a lot of email as I retrigger the pipeline.
    Jakub T. Jankiewicz
    @jcubic
    Now when you have account you can also try to contact SauseLabs support
    Sean Poulter
    @seanpoulter
    Yea, I can take that on for us too.
    Jakub T. Jankiewicz
    @jcubic
    You probably will explain it better what is issue is
    Sean Poulter
    @seanpoulter
    Want me to follow up with them about that proxy deprecation issue too?
    Jakub T. Jankiewicz
    @jcubic
    Yes, you can ask about all the issues that we have with automated tests, maybe you can also mention async package
    Maybe they already have experience with those issues
    Sean Poulter
    @seanpoulter
    I've signed in and can see the test results. Hooray, more pieces to the puzzle. :)
    Well now I feel silly. There aren't any test failures there for Android. That runs in BrowserStack. 🤦‍♀️
    https://github.com/isomorphic-git/isomorphic-git/blob/main/karma.conf.cjs#L101-L108
    I'm having a look at the test results from May 15th here
    https://app.saucelabs.com/dashboard/tests/vdc
    Sean Poulter
    @seanpoulter
    Good luck to us all!
    isomorphic-git/isomorphic-git#1587