Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Dan Allen
    @mojavelinux
    it may just be that my Node 10 is out of date.
    nope, still happens with the latest Node 10 release.
    Dan Allen
    @mojavelinux
    I filed an issue an submitted a PR with a proposed fix.
    William Hilton
    @wmhilton
    I just understood that using any CORS proxy I use can see my tokens 🙀😭
    yes, this is the great tragedy of our times! put some pressure on the major git hosting providers to allow browsers to interact directly
    William Hilton
    @wmhilton
    @mojavelinux hit me up in a Github issue about the antora tests. i actually looked at the antora tests before making that change funnily enough and thought "oh good, this won't be difficult to fix" lol
    Dan Allen
    @mojavelinux
    @wmhilton thanks. I definitely will. I'm going to be looking at in the next week or so. I'm not too concerned about how hard it will be to fix the tests...I just want to make sure the fix doesn't weaken any assertions
    Dan Allen
    @mojavelinux
    @wmhilton it turned out to be a relatively minor change to get the Antora tests working with isomorphic-git 0.65. Antora itself doesn't read the index, so it was just the test helper that needed the update. See https://gitlab.com/antora/antora/merge_requests/357/diffs#diff-content-5dfaa498c615742430124be386a49b71c6895fa9
    William Hilton
    @wmhilton
    Hooray! Good, sorry a breaking-ish change snuck in. The worst-case performance benefited from the caching so much though (cut statusMatrix time from over a minute to sub-second for large repos) I deemed it critical to fix ASAP. Glad it was an easy fix!
    Dan Allen
    @mojavelinux
    no problem, really. the fact that the fs is pluggable made it a breeze. I just needed to understand where the change fit. and it only affected the test suite, as you said it might. Antora itself remains unaffected. so it's not really breaking at all.
    Brett Zamir
    @brettz9
    Hi... I'm having a problem pushing on Node (with no URL but a dir). I'm getting a RemoteUrlParseError error as a result of the fact that config() get a URL of this format: git@github.com:brettz9/update-packages.git which is not understood by parseRemoteUrl (called via GitRemoteManager.getRemoteHelperFor) as the regex it expects is /(\w+)(:\/\/|::)(.*)/ which the git@ type URL doesn't fit. I suppose I can convert it with github-url-converter but thought it should be handled within. File an issue?
    Brett Zamir
    @brettz9
    As I recall, I had to use this form of URL at one point for the sake of a proxy or other service I was using in China.
    Praveen Bisht
    @prvnbist_twitter
    Does isomorphic-git supports cherry-pick command?
    Ilya Radchenko
    @knownasilya
    I clone, checkout and fetch, and then do console.log(yield git.listFiles({ dir: '/' })); and get a bunch of files. I don't expect to have any files in staging after cloning and not making any changes. Any ideas?
    I'm assuming I'm doing something wrong..
    Stéphane GINER
    @sginer
    How to compare local repos commit with remote repo commit ? For remote repos I can use getRemoteInfo to get all commit on a branch but I dont find the same for the local repos !
    Stéphane GINER
    @sginer
    Ok log method give info about commit history ! I have all I need :)
    Guy Romm
    @guyromm_gitlab
    hi everyone. has anyone tried isomorphic-git within a chrome extension, sans the corsProxy?
    Jakub T. Jankiewicz
    @jcubic
    There is chrome extension that allow to disable CORS checks (actually it enable cors headers for every request) you can check if it's open source and if yes check it's source code how it was implemented, if it's not open source you can ask on StackOverflow how to enable CORS in chrome extension
    Jakub T. Jankiewicz
    @jcubic
    Not sure if it will work with fetch but chrome extension can add permission to url https://developer.chrome.com/extensions/xhr#requesting-permission if you want access git hosting like GitHub or GitLab there should be no problem
    safiyabegam
    @safiyabegam
    Hi Can anyone help how filesystem works for browser using lightningFs? am keep on getting error called "Uncaught (in promise) Error: EEXIST" . I want to emulate FS for browser but then unable to achieve with lightningFs. Tried with examples also as given in isomorphic guide
    jonahnewman
    @jonahnewman
    I'm using isomorphic-git in a browser extension, and I'm a bit confused about security with respect to authorization. I know storing passwords/access tokens in plaintext on a server-side application is a very bad idea, but is the same thing true for doing it within the user's own browser?
    William Hilton
    @wmhilton
    @jonahnewman Storing user credentials in client-side storage (such as localStorage or IndexedDB) can be OK as long as your site has no third-party script tags running on it which might try to steal the credentials. The best solution is to use the browser's own Credential Management API - the downside of that being it's poorly supported at the moment (https://caniuse.com/#feat=credential-management)
    Anton Strogonoff
    @strogonoff
    Is there a way to import GitError class in a TS project?
    somehow import { GitError } from 'isomorphic-git/internal-apis'; seems to fail
    sh0rtwave
    @sh0rtwave
    Question: I'm trying to pull/fetch on an existing repo that works great from the console, but I'm getting a 401 from within my app. I suspect (because the error is 401, and it's bitbucket) that this is because my (non-standard) key for bitbucket isn't being loaded. How does one solve this?
    Jakub T. Jankiewicz
    @jcubic
    @sh0rtwave 401 is authentication required error, so if you have private repo you need user/password or user/token
    sh0rtwave
    @sh0rtwave
    What if you're using a username + public key?
    That's what my repo currently uses, at least.
    So what I was looking at was seeing if it's possible to configure isomorphic-git (currently, if not, I will add it) to be able to specify a username + a public key? I know I can go the token route, however for the workflow I intend for my app, that is obviously not ideal.
    sh0rtwave
    @sh0rtwave
    Also: If I'm importing from a regular git repo, my url error looks like: message: 'Cannot parse remote URL: "git@bitbucket.org:<myUser>/<myRepo>.git"',
    The 401 emerges when I override the imported git url with an https:// style formatted URL. Because the id_bitbucket isn't the default .ssh key for <whatever part of the system electron-bundled nodejs imports from>.
    Otherwise, I'm deeply in love with this project for making it so simple to manipulate git's object graph.
    sh0rtwave
    @sh0rtwave
    If I had a clue where to manipulate the bundled-with-electron-version-of-chromium's keystore, I could solve this problem double quick.
    but regardless of that, I need an app-configurable method of importing a private/public keypair and using it for authentication for pulling.
    Jakub T. Jankiewicz
    @jcubic
    @sh0rtwave If I understand correctly if you have public key you also need private ssh key on your system, if so I don't know if isomorphic git support ssh, I think it only supports https
    Latn Black
    @LatnBlack_twitter
    Hi, I hope someone can help, perhaps I'm just doing something wrong. I need the equivalent of git checkout -b branch-name, and I thought the branchcommand with checkout: true would give me what I wanted (a new branch at the same commit as the branch I just switched from), but it doesn't
    The scenario is: I've created a remote repo, I clone it , create a bunch of files on master, commit these changes and push them to the remote, then attempt to checkout a new branch.
    The result is that the new branch only has the initial commit; i.e. it's in the same state that the master branch was at the point that it was cloned. The latest commit isn't present. The files are there, but they're all treated as new
    Am I using the wrong command (checkout/fastCheckout seem to depend on the remote branch existing already) or is there no equivalent of git checkout -b ...?
    Jakub T. Jankiewicz
    @jcubic
    and the files are on remote, can you confirm on web interface? maybe you didn't add them and you pushed empty commit, not sure if this is possible with isomorphic git
    Latn Black
    @LatnBlack_twitter
    @jcubic No, files are definitely on remote. I thought the same but I've checked and verified all new files are in master on remote
    jonahnewman
    @jonahnewman
    Whenever I try to use git.add or git.status I get the following:
    Uncaught (in promise) TypeError: Cannot read property 'byteLength' of null
    at Function.wrap (background.bundle.js:19065)
    at hashObject$1 (background.bundle.js:28127)
    at getWorkdirOid (background.bundle.js:28485)
    at async Module.status (background.bundle.js:28524)
    This makes me think that I'm giving it bad arguments, but I've checked and i'm sure they're correct. Is there some other possible explanation?
    jonahnewman
    @jonahnewman
    Never mind. I've determined that it's finding the file correctly but that the contents of the file are giving it trouble. I'm not sure why this is but I'll figure it out eventually.
    sh0rtwave
    @sh0rtwave
    On the node side, I'm sure ssh isn't that hard to work with. I'm gonna poke meh nose into it.
    Latn Black
    @LatnBlack_twitter
    Does anyone have any other ideas on the problem I posted?
    I'll be working on it again this morning and will let you know if I make any progress.