Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Kevin Altman
@itsthatguy
I think you will have to, right?
when you do though, it will break some tests
Oren Farhi
@orizens
@itsthatguy after gulp compile, i'm still getting the theme files with broken paths rendered as: "Theme - itg.flat/assets/"
instead of getting slash /
Kevin Altman
@itsthatguy
that’s likely because you don’t actually ahve latest master
Oren Farhi
@orizens
i fetched the lastest changes..
Kevin Altman
@itsthatguy
did that help?
Oren Farhi
@orizens
i'm trying that right noe
Kevin Altman
@itsthatguy
ok
Oren Farhi
@orizens
update: only 2 tests are failing
i'm not sure why
Kevin Altman
@itsthatguy
which ones?
Oren Farhi
@orizens
"Mustache generates the expected itg.flat.light.sublime-theme:"
"Mustache generates the expected itg.flat.dark.sublime-theme:"
Kevin Altman
@itsthatguy
yes, those two should fail
"yes. after you update the mustache file, you’ll need to add the generated changes to the test/templates files"
Oren Farhi
@orizens
ok.
i solved that
and pushed to master
Kevin Altman
@itsthatguy
did the push succeed? I’m not seeing the change
Oren Farhi
@orizens
minute.. adding last changes..
just pushed
Kevin Altman
@itsthatguy
ok, I made a few comments, some might not be warranted
(my comments might just be wrong)
Oren Farhi
@orizens
some of your comments are for lines that i didn't change..
Kevin Altman
@itsthatguy
are you familiar with rebasing?
this is a pretty large PR that should be rebased
there are alot of unnecessary commits, that change things, then change them back, then change them again
Oren Farhi
@orizens
sorry...not that familiar with rebase.
i
i'll just fix those
Oren Farhi
@orizens
pushed an update
Kevin Altman
@itsthatguy
@orizens I left a comment, I can’t rebase all of the changes
can you please fork fresh from master, and make a minimal amount of changes
it’s worth noting, you’ve also removed some of the mustaches, was that intentional?
you made some things hardcoded, which were originally passed in via the JS
or maybe not, It kept showing up while i was trying to rebase
Oren Farhi
@orizens
ok. it seems like the right thing to do. i'll start from scratch and update the relevant files.
i apologize for the mess
Kevin Altman
@itsthatguy
np
ty for doing all this
Matt Avinger
@venetianthief
pokes head in Go team! GOOOOO! ;)
Oren Farhi
@orizens
@itsthatguy - i can't seem to test the changes i'm doing. has something changed in latest sublime version 3?
the way used to test the changes: i copy the github repo to my user directory, do the changes there, in sublime, and watch the changes apply in place.
Now, i do the changes - but can't see them. sublime package control somehow download a copy of itg-theme to the "installed-packages" directory and doesn't apply the changes.
any idea how to test my changes?
Kevin Altman
@itsthatguy
uninstall the package from sublime-text
using remove package
Oren Farhi
@orizens
i did that, however package control installs automatically a package it finds
Kevin Altman
@itsthatguy
packages can be in 2 different folders, ones it finds for the package control it will, the other it will not
Harris Thompson
@HarrisJT
update?
Kevin Altman
@itsthatguy
@HJThompson?