Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Arthur Clemens
@ArthurClemens
I try to update Polythene to work with Webpack 4, but I keep getting the error
Can't import the named export 'prefixPlugin' from non EcmaScript module (only default export is available)
Pierre-Yves Gérardy
@pygy
Let me look...
Arthur Clemens
@ArthurClemens
Webpack 4 is a bit of a struggle, but I have it working (with that one exception) by using an extension less main file, and the module name using mjs:
"main": "dist/project",
"module": "dist/project.mjs”,
Webpack 4 only could use the extension less main file, but Rollup needs “module”. Because Webpack gives precedence to .mjs, this combination works for both.
Pierre-Yves Gérardy
@pygy

It looks like I have a v1.0.7 that I forgot to publish, with 

  "main": "dist/j2c-plugin-prefix-browser.commonjs.js",
  "module": "src/plugin.js",

Whereas the current v1.0.6 still has

  "main": "dist/j2c-plugin-prefix-browser.commonjs.js",
  "jsnext:main": "src/plugin.js",
And, actually, the module should have pointed to main.js that only exports the public function, the other exports in plugin.js are meant for testing IIRC
Is mjs mandatory for modules with Webpack 4?
@ArthurClemens
Arthur Clemens
@ArthurClemens
Webpack 4 supports multiple types
it is useful to offer at least one esm file
Arthur Clemens
@ArthurClemens
Webpack 4 can figure out which file is which, so you can also use an esm file with .js extension, but Rollup needs the .mjs extension to know
Arthur Clemens
@ArthurClemens
(extension in package.json)
Pierre-Yves Gérardy
@pygy
re. Rollup, that's surprising, they don't seem to mention mjs in the docs...
I'll look into this tomorrow.
Pierre-Yves Gérardy
@pygy
@ArthurClemens I just published v1.0.7 with a module where the jsnext:main field was, could you give it a look?
Arthur Clemens
@ArthurClemens
I’ll look tomorrow
Pierre-Yves Gérardy
@pygy
:+1: good night!
Off to bed as well
Arthur Clemens
@ArthurClemens
I am getting the same error: Can't import the named export 'prefixPlugin' from non EcmaScript module (only default export is available)
I can get my code working with:
import { prefixPlugin } from "j2c-plugin-prefix-browser/dist/j2c-plugin-prefix-browser.commonjs”;
Pierre-Yves Gérardy
@pygy
Could you post your rollup/webpack settings in a gist?
Arthur Clemens
@ArthurClemens
I have them here: https://github.com/ArthurClemens/polythene/tree/next/scripts
Packages are bundled by Rollup. The demo application runs using Webpack.
The package.json for the css package
Pierre-Yves Gérardy
@pygy
Thanks, I'll investigate
Stefan Thon
@smuemd
Das b
Odh
BR ,kbviz p
Z DMjvdm h
G
Pierre-Yves Gérardy
@pygy
@smuemd you cat/kid stepped on your keyboard :-D
... or did you fall asleep?
Arthur Clemens
@ArthurClemens
:point_up: March 22, 2018 8:55 AM Perhaps easier if I create a PR?
Pierre-Yves Gérardy
@pygy
One year later :-)
Yes, please shoot me a PR :-)
Arthur Clemens
@ArthurClemens
:thumbsup:
j2c is still the most flexible css-in-js for me