well, i essentially have a dict of conditions upon the triggering of which a list of not necessarily unique actions is to be invoked. i now want conditions to be created such that no action is duplicated between different conditions. as such i have to or the conditions together and accumulate the elements according to the correct ORing of the condition. this is equivalent to simply adding all that i had in my original dict to a multibimap and then ORing the conditions and taking all the values for those new conditions as the actions to be triggered for them. you can of course do it without such a data structure, it just looks like this(which probably is still easier to read than my attempt at an explanation):
def reduce_or_add(d, reduce):
seen = {}
ret = defaultdict(set)
for k, vs in d.items():
for v in vs:
if v in seen:
ret[seen[v]].remove(v)
seen[v] = reduce(k, seen[v])
ret[seen[v]].add(v)
else:
ret[k].add(v)
seen[v] = k
return ret
https://github.com/sushobhit27/bimap
i found this, but it does not appear to be updated, had multiple bugs when i downloaded it and features not exactly what i d call a user friendly interface
i found this, but it does not appear to be updated, had multiple bugs when i downloaded it and features not exactly what i d call a user friendly interface
@JeWe37 Sorry I havent had time to look into this yet. But in the meantime, just wanted to make sure you’ve seen the https://bidict.readthedocs.io/extending.html docs in case that could be useful to you.
@/all, I just released bidict v0.21.0, the first version to support type hints! ⌨️ ✅ See https://bidict.rtfd.io/en/v0.21.0/changelog.html for the full changelog. Please upgrade when you can and let me know if you have any issues!
I used this to get tox working on my local machine, perhaps this would be interesting for other new contributors: https://gist.github.com/mbarkhau/d38a4bf5d1b0c7b0f7f10c4bbd699e39
(equally cross-platform but more minimal - just python versions and not a whole parallel universe)
And welcome @/all to today's bidict Hack Day, great to see you here! If you'd like to follow my first suggestion for something to work on today, of adding property-based tests with Hypothesis, and you're new to the subject, you can start reading about it here: http://hypothesis.rtfd.io/
I can demo an example of adding a new property-based test for everyone on a screenshare at 10am Eastern. Join via https://meet.google.com/ouf-syai-xvv at that time if interested.
If you're interested in working on something else, let me know and I'll look forward to helping in any way I can!
Also check out https://bidict.readthedocs.io/contributors-guide.html and let me know if you have any issues setting up a development environment.
You may also wish to spend some time taking the "guided tour" through bidict's code that starts here: https://github.com/jab/bidict/blob/master/bidict/__init__.py (see the comment starting with "Welcome to the bidict source code" in the header)
Btw, someone please remind me to ask y'all if anyone wants to present at the Hack Day show-and-tell on Tuesday!
@jab Some minor quick q:
- I noticed that https://github.com/jab/bidict/blob/07c2dcf1a75642af169da400bb40b59fe01fe3dd/tests/properties/test_properties.py#L354 is under
test_propertiesbut is it a property test? - On https://github.com/jab/bidict/blob/07c2dcf1a75642af169da400bb40b59fe01fe3dd/tests/properties/test_properties.py#L267, is there a reason it is written that way with the pylint disable instead of
assert hasattr(bi, "_isinv")
@jab just getting familiar with bidict dev environment and hypothesis. One quick question on the env setup: I'm getting this error running pip install, are you missing
wheel in requirements? Building wheels for collected packages: py-cpuinfo
Running setup.py bdist_wheel for py-cpuinfo ... error
Complete output from command /home/tuananh/projects/bidict/venv/bin/python3.6 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-03qu3tgi/py-cpuinfo/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/tmpeq9k47vbpip-wheel- --python-tag cp36:
usage: -c [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
or: -c --help [cmd1 cmd2 ...]
or: -c --help-commands
or: -c cmd --help
error: invalid command 'bdist_wheel'
----------------------------------------
Failed building wheel for py-cpuinfo
Running setup.py clean for py-cpuinfo
Failed to build py-cpuinfo
Hey @neiltiwari, sorry I just saw your questions!
- Good eye, that's not a hypothesis-powered property-based test -- there's no
@given(...)feeding hypothesis-generated input into it. I deliberately threw it into test_properties.py nonetheless to keep it together with the other property-based tests for that function, but I at least should have added a comment to make it clearer this was intentional (not missing a@givenor something). - Just that
bi._isinvmore clearly and concisely expresses the intent there, in my opinion.
@hvtuananh, sorry to hear you hit this! I've never seen that before. IIUC
wheel should not need to be in setup_requires.
I'm down to dig into why you're hitting this later, but just to get your development environment set up more quickly, for now would you like to try passing
--no-binary=:all: to your pip install command?
Great you worked around it already! (If/when interested in following up, could be worth comparing your environment to environments where this is working. e.g. On Travis-CI's Xenial image,
pip install Just Works, and pip list includes wheel, see e.g. https://travis-ci.org/github/jab/bidict/jobs/730242994 (search for "pip list" in the console output) – but definitely for another time since this is exactly the kind of nonsense that can otherwise easily burn a whole hack day:)
Could be to do with the OS (which venv can't do anything about).
e.g. on macOS, it looks like
wheel isn't even a transitive dependency.
Something interesting, in poking around to find where the invariants might break, I found that by adding
HASHABLES = ATOMS | st.functions()this causes test_pickle_roundtrips to fail because functions cannot be pickled. One can, amusedly create bidicts with functions as keys
bidict({print: print}).inv[print]("Hello world")
@given(st.MUTABLE_BIDICTS, booleans)
def test_dup_keyError(bi, val):
"""raise dup key error"""
for b in (bi, bi.inv):
b[val] = not val
try:
b[val] = val
except KeyDuplicationError as ex:
assert len(b) == len(b.inv)
else:
raise Exception("Dup not picked up")
def test_dup_keyError(bi, val):
"""raise dup key error"""
for b in (bi, bi.inv):
b[val] = not val
try:
b[val] = val
except KeyDuplicationError as ex:
assert len(b) == len(b.inv)
else:
raise Exception("Dup not picked up")
How's everyone doing? Ready to reconvene in https://meet.google.com/ouf-syai-xvv or want a little more time?
Thanks @/all who joined for the sprint today, it was great hacking with you! I'm not sure I'll be able to make the show-and-tell on Tuesday (I have a training all next week), but if any of you want to present something at the show-and-tell, please coordinate here, and thank you for presenting! If there's anything you'd like me to review in advance, I'll be happy to try to take a look this weekend. Great collaborating with you all again, and looking forward to next time!
Hi @/all, I recently made a number of improvements to bidict: https://bidict.readthedocs.io/en/main/changelog.html#not-yet-released -- and I'm psyched to release them soon! Before I do, I'd love another pair of eyes to review the code in case I missed something. If you have time, please take a look, starting with https://github.com/jab/bidict/blob/main/bidict/__init__.py and following the path given by the "code review nav" comments at the top, and send me a PR with any proposed changes or even just a DM here. Thanks, and looking forward to releasing the best version of bidict yet.