Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Wagner Amaral
    @wamaral
    yeah, I was using fish then it was complaining about not using env before variables, so I switched to a new user with bash as default
    somehow running 'make test` from bash still calls fish
    Jack Angers
    @jacktasia
    what about just cask exec ert-runner?
    Wagner Amaral
    @wamaral
    Unsupported use of '='. To run 'grep' with a modified environment, please use 'env LANG=C grep…'
    the fish error, even though I'm on bash
    so I settled on running on a new user :p
    Jack Angers
    @jacktasia
    ah, ok
    it just dawned on me that the test that runs the grep tests may need to set dumb-jump-force-grep to t
    Wagner Amaral
    @wamaral
    well it does
    line 145
    Jack Angers
    @jacktasia
    ha, whoops!
    Wagner Amaral
    @wamaral
    it's identical to the previous test except for that line :p
    Jack Angers
    @jacktasia
    yeah not sure what i was thinking :flushed:
    Wagner Amaral
    @wamaral
    haha no problem, I just have that exact line open right now :)
    Jack Angers
    @jacktasia
    is the test that was failing above passing now that you've made a new user?
    Wagner Amaral
    @wamaral
    nope, when I run with my user it fails with the fish error, and when I run on the new user with bash it fails with "grep: \(defun\s+another-fake-function($|[^\w-]): No such file or directory"
    Jack Angers
    @jacktasia
    and this is the branch with your changes or master or both?
    Wagner Amaral
    @wamaral
    I'm stupid, didn't test on master, hold on :)
    yeah on master that one passes, two others fail
    guess I broke something :(
    no wait
    wrong master
    yeah, all pass
    Jack Angers
    @jacktasia
    is this the clojure one?
    Wagner Amaral
    @wamaral
    yeah
    it was my mistake :p
    Jack Angers
    @jacktasia
    sounds like the failures were because of the other changes
    Wagner Amaral
    @wamaral
    yup, that was the mistake
    thought I was in another branch
    Jack Angers
    @jacktasia
    :+1:
    Wagner Amaral
    @wamaral
    also stupid emacs keeps reindenting everything
    there we go! now the clojure branch is green
    Jack Angers
    @jacktasia
    awesome, thanks!
    Wagner Amaral
    @wamaral
    now to fix the ruby one :)
    Wagner Amaral
    @wamaral
    the test suite is still trying to run grep on the regexes I set as :supports ("ag") :(
    Jack Angers
    @jacktasia
    hmm
    i will take a look
    Jack Angers
    @jacktasia
    ok, my bad. should be fixed now jacktasia/dumb-jump@cfe4998
    Wagner Amaral
    @wamaral
    nice! let me try again
    Jack Angers
    @jacktasia
    travis should be retrying your PR again
    Wagner Amaral
    @wamaral
    oh cool
    Jack Angers
    @jacktasia
    looks all green now
    Wagner Amaral
    @wamaral
    success :)
    Jack Angers
    @jacktasia
    all merged. thanks again for the PRs!
    Wagner Amaral
    @wamaral
    yeah no problem :) thanks for releasing the plugin, it's very useful
    Jack Angers
    @jacktasia
    np, happy to hear that
    jason
    @aslijiasheng
    hello guys, how to install dumb-jump in spacemacs?
    Jack Angers
    @jacktasia
    @aslijiasheng I don't use spacemacs but it should be as easy as this: http://spacemacs.org/doc/DOCUMENTATION.html#orgheadline21
    jason
    @aslijiasheng
    @jacktasia ok thank you