These are chat archives for jacktasia/dumb-jump

7th
Jun 2016
Jack Angers
@jacktasia
Jun 07 2016 06:35
@wamaral #23 is now merged in so your current PRs should only need :supports ("ag") for all your new rules
Wagner Amaral
@wamaral
Jun 07 2016 19:36
that's great! :) I saw the code, only a few changes did it :)
Jack Angers
@jacktasia
Jun 07 2016 19:37
:smile:
Wagner Amaral
@wamaral
Jun 07 2016 19:37
I'm trying to make all tests pass, but there's this one that keeps failing on me :(
`RUNNING CMD ’"LANG=C grep -REn --exclude-dir -e '\(defun\s+another-fake-function($|[^\w-])' -e '\(defvar\b\s+another-fake-function($|[^\w-])' -e '\(defcustom\b\s+another-fake-function($|[^\w-])' -e '\(setq\b\s+another-fake-function($|[^\w-])' -e '\(another-fake-function\s+' -e '\(defun\s+.+\(?\sanother-fake-function($|[^\w-])\s\)?'
/home/wamaral/dev/dumb-jump/test/data/proj2-elisp"’ RESULTS: "grep: \(defun\s+another-fake-function($|[^\w-]): No such file or directory`
dumb-jump-run-grep-cmd-test
any clues what it could be?
Jack Angers
@jacktasia
Jun 07 2016 19:38
ohhh, yeah
one sec
do you know what kind of shell you're using? echo $0?
Wagner Amaral
@wamaral
Jun 07 2016 19:41
yeah, I was using fish then it was complaining about not using env before variables, so I switched to a new user with bash as default
somehow running 'make test` from bash still calls fish
Jack Angers
@jacktasia
Jun 07 2016 19:43
what about just cask exec ert-runner?
Wagner Amaral
@wamaral
Jun 07 2016 19:43
Unsupported use of '='. To run 'grep' with a modified environment, please use 'env LANG=C grep…'
the fish error, even though I'm on bash
so I settled on running on a new user :p
Jack Angers
@jacktasia
Jun 07 2016 19:45
ah, ok
it just dawned on me that the test that runs the grep tests may need to set dumb-jump-force-grep to t
Wagner Amaral
@wamaral
Jun 07 2016 19:46
well it does
line 145
Jack Angers
@jacktasia
Jun 07 2016 19:47
ha, whoops!
Wagner Amaral
@wamaral
Jun 07 2016 19:47
it's identical to the previous test except for that line :p
Jack Angers
@jacktasia
Jun 07 2016 19:49
yeah not sure what i was thinking :flushed:
Wagner Amaral
@wamaral
Jun 07 2016 19:50
haha no problem, I just have that exact line open right now :)
Jack Angers
@jacktasia
Jun 07 2016 19:51
is the test that was failing above passing now that you've made a new user?
Wagner Amaral
@wamaral
Jun 07 2016 19:52
nope, when I run with my user it fails with the fish error, and when I run on the new user with bash it fails with "grep: \(defun\s+another-fake-function($|[^\w-]): No such file or directory"
Jack Angers
@jacktasia
Jun 07 2016 19:54
and this is the branch with your changes or master or both?
Wagner Amaral
@wamaral
Jun 07 2016 19:56
I'm stupid, didn't test on master, hold on :)
yeah on master that one passes, two others fail
guess I broke something :(
no wait
wrong master
yeah, all pass
Jack Angers
@jacktasia
Jun 07 2016 20:02
is this the clojure one?
Wagner Amaral
@wamaral
Jun 07 2016 20:03
yeah
it was my mistake :p
sounds like the failures were because of the other changes
Wagner Amaral
@wamaral
Jun 07 2016 20:04
yup, that was the mistake
thought I was in another branch
Jack Angers
@jacktasia
Jun 07 2016 20:05
:+1:
Wagner Amaral
@wamaral
Jun 07 2016 20:05
also stupid emacs keeps reindenting everything
there we go! now the clojure branch is green
Jack Angers
@jacktasia
Jun 07 2016 20:18
awesome, thanks!
Wagner Amaral
@wamaral
Jun 07 2016 20:19
now to fix the ruby one :)
Wagner Amaral
@wamaral
Jun 07 2016 20:37
the test suite is still trying to run grep on the regexes I set as :supports ("ag") :(
Jack Angers
@jacktasia
Jun 07 2016 20:56
hmm
i will take a look
Jack Angers
@jacktasia
Jun 07 2016 21:19
ok, my bad. should be fixed now jacktasia/dumb-jump@cfe4998
Wagner Amaral
@wamaral
Jun 07 2016 21:20
nice! let me try again
Jack Angers
@jacktasia
Jun 07 2016 21:20
travis should be retrying your PR again
Wagner Amaral
@wamaral
Jun 07 2016 21:21
oh cool
Jack Angers
@jacktasia
Jun 07 2016 21:23
looks all green now
Wagner Amaral
@wamaral
Jun 07 2016 21:24
success :)
Jack Angers
@jacktasia
Jun 07 2016 21:26
all merged. thanks again for the PRs!
Wagner Amaral
@wamaral
Jun 07 2016 21:27
yeah no problem :) thanks for releasing the plugin, it's very useful
Jack Angers
@jacktasia
Jun 07 2016 21:28
np, happy to hear that