Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Mischievous Meerkat
    @jarun
    that would help us discuss in a more shared way
    Krazy Bug
    @Krazybug
    Good initiative. I will join
    Mischievous Meerkat
    @jarun
    rachamdani takes care of testing areas but he is very good in python and is our last line of defense in many areas ;)
    Krazy Bug
    @Krazybug
    ok it's cool. As you can see i tried so specify the specification of the change because I'm a BDD addict and thought about testing my change with this lib : https://github.com/pytest-dev/pytest-bdd + your current test suite Take care of you and your family
    Mischievous Meerkat
    @jarun
    hehe
    I see the team feature needs an enterprise subscription of Github
    so we have to stick to gitter
    anyway the Buku room works for me
    Krazy Bug
    @Krazybug
    Ok. Eventually you can create a new room "dev" under the same project in Gitter. and this one will be used for users only
    Mischievous Meerkat
    @jarun
    okk
    Krazy Bug
    @Krazybug
    I just updated the issue with your previous comments. Best regards
    Mischievous Meerkat
    @jarun
    awesome!
    Krazy Bug
    @Krazybug
    Now let's code ;-)
    Mischievous Meerkat
    @jarun
    yep!
    Andrew Szeto
    @jabagawee_twitter
    is there a specific design decision to keep buku into a single file? i've tried searching around the github, wiki, and even the git history but it seems that there was never a specific reason for such
    Mischievous Meerkat
    @jarun
    hi there
    I think it's time to modularize it
    I would be glad if you can pick it up
    Andrew Szeto
    @jabagawee_twitter
    sounds good
    Mischievous Meerkat
    @jarun
    cool
    try to keep it separate based on each class and then helper APIs
    Andrew Szeto
    @jabagawee_twitter
    yup
    should i create a source directory
    or a buku/ directory right at the top level
    seems to be the standard among python packages
    also do you run your tests locally? i think that the tox.ini file doesn't work with the latest few versions of tox
    since 2012, tox has not really allowed the pipe character "|" in its commands
    Mischievous Meerkat
    @jarun
    There's another contributor who was into the refactoring
    I pinged him now
    added you
    wait for a day or two and then you can start
    if you find anything outdated, please fix
    I don't run tests locally, but rachmadani might
    but still, if the issue is obvious just fi it and move on to the next ;)
    Andrew Szeto
    @jabagawee_twitter
    how do you run tests?
    Mischievous Meerkat
    @jarun
    travis integrated
    all pushes go through automated testing
    I gotta run now
    if you have any other queries, just list them here
    I will respond when I am back
    it's early morning here and I have to take care of the kid
    but I do keep checking the laptop frequently
    so it won't be long
    Andrew Szeto
    @jabagawee_twitter
    sounds good
    Mischievous Meerkat
    @jarun
    cool
    thanks!
    Ramesh Mandaleeka
    @rameshm_twitter
    I imported bunch of bookmarks in to Buku. However, some of the URL’s are bit.ly like url shortened urls. Buku -u only updates the title and description. Is there a way to update the bit.ly urls to the final url(redirected to url)?
    Mischievous Meerkat
    @jarun
    Hi, no it doesn't derefer. You can open all the bookmarks in one go in browser from buku search results. Then you can add them back from address bar individually.
    Configure a keyboard shortcut to add directly from address bar.