These are chat archives for jasonLaster/backbone.marionette

3rd
Nov 2016
Jason Laster
@jasonLaster
Nov 03 2016 15:22
heya @bomsy
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:12
hey
hey @jasonLaster
Jason Laster
@jasonLaster
Nov 03 2016 16:14
Hey
Thanks for the outlines PR
reading your comments now
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:15
i had a look a the search addon for codemirror
Jason Laster
@jasonLaster
Nov 03 2016 16:15
yeah - that makes sense.
this PR blew my mind when i first saw it
taking another look
it looks like codemirror is pretty well setup for this usecase
is overlay for this?
ooh, or is it for just outlining one match, but now we're overriding that to do all matches?
lol - none of this makes any sense :) sorry
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:18
it uses overlay for this
Jason Laster
@jasonLaster
Nov 03 2016 16:20
ahh that helps
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:20
so we are kind of hooking into the parser
Jason Laster
@jasonLaster
Nov 03 2016 16:21
yeah - token is neat
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:21
and looking at each token, to decide if it needs to be highlighted
return "selecting" just tells codemirror the class to add
Jason Laster
@jasonLaster
Nov 03 2016 16:22
ahh - overlay makes sense when looking at it
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:22
cm-selecting
Jason Laster
@jasonLaster
Nov 03 2016 16:22
is that the current one?
currently selected?
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:23
no thats all the highlighted
Jason Laster
@jasonLaster
Nov 03 2016 16:23
ahh - okay
Hubert Boma Manilla
@bomsy
Nov 03 2016 16:23
i sec i'll find the codemirror example
its the example i used
Jason Laster
@jasonLaster
Nov 03 2016 16:25
nice
thanks.
Hubert Boma Manilla
@bomsy
Nov 03 2016 17:37
Heya @jasonLaster
i've got a question
in the normal search does it support regexp
?
cos i noticed , if u type $ it won't find the character, unless u do \$