by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Bartosz Walacik
    @bartoszwalacik
    @dh0271 this is the contributors room. If you have a question, ask at stackoverflow. If you think you found a bug, follow the https://github.com/javers/javers/blob/master/CONTRIBUTING.md#guidelines-for-bug-reporting
    qwiskyRobert
    @qwiskyRobert
    data is not saving to jv_commit_property table . how to fix this?
    qwiskyRobert
    @qwiskyRobert
    JaversException NOT_INSTANCE_OF: Can't create InstanceId for EntityType
    Bartosz Walacik
    @bartoszwalacik
    @qwiskyRobert please read the title of this room
    راشد عبد الرشید
    @rashidbsit_twitter
    Hello Bartosz
    we are facing one issue
    we have two table parent and child
    first we add parent
    it create entry on snapshot table
    after that we add child with it, it create 2 entries one for parent and one for child
    parent entry is update type
    and child is create type
    now the issue is that in update entry of parent have not show any change
    راشد عبد الرشید
    @rashidbsit_twitter
    @bartoszwalacik can you please check my issue
    راشد عبد الرشید
    @rashidbsit_twitter
    any one in this room can answer to my question
    Bartosz Walacik
    @bartoszwalacik
    this is the contributors room, questions should be asked at stack
    Arsalan Siddiq
    @arsalansiddiq
    Hi there, I am facing issue COMMITTING_TOP_LEVEL_VALUES_NOT_SUPPORTED javer spring boot while passing String (_id) with Domain model
    Bartosz Walacik
    @bartoszwalacik
    we are not answering questins here
    Ketan Nabera
    @K10Codes
    I want to propose a change to add @Order(0) to JaversSpringDataAuditableRepositoryAspect.java.
    Why ?
    This aspect contains advices that run for all save/delete operations in
    the application but since there is no order present with it. It takes
    the default order which is highest precedence as it is using after-
    advices. So giving it order 0 would help if some other advice needed to
    execute before this.
    Please let me know your thoughts on the same.
    Bartosz Walacik
    @bartoszwalacik
    Yes, I have seen your PR, the change seems fine, I will merge it soon
    Bartosz Walacik
    @bartoszwalacik
    but I'm not sure why setting 0 is better than max_int, why first is better than last, both options are not flexible
    maybe we should set sth like 10
    to give user more flexibility
    Ketan Nabera
    @K10Codes
    @bartoszwalacik .. The current implementation doesn't have any order defined and thus it takes by default Ordered.LOWEST_PRECEDENCE , which would mean its order is Integer.MIN_VALUE. Now, since all the advices in that Aspect are 'AfterReturning' advices, and these types of advices run in reverse order... Meaning if i write 5 more advices in different @Aspect classes and give them order 1,2...5 , then the order of execution would be 5,4,...0. I still want the javers code to run at the very end as that is the final expected behavior which i want (its a wonderful implementation there bdw). That is the reason i gave this one a 0 order, as its in the center of the entire integer range. Users can go from 0 to Integer.MAX_VALUE for all the advices they want to run before this Aspect and from 0 to Integer.MIN_VALUE for all that they want to run after . I just feel more comfortable with 0 as a coder. :)
    Let me know your thoughts on the same. Happy to discuss it through before we conclude on anything. :)
    Bartosz Walacik
    @bartoszwalacik
    ok, 0 is fine if you can set negative numbers also, I didn't konw that
    Ketan Nabera
    @K10Codes
    @bartoszwalacik sounds great ! Looking forward to this. Thank you 😊
    Ketan Nabera
    @K10Codes
    @bartoszwalacik Hello, with the recent changes in 5.9.2 , i see spring boot and mongo driver versions also got updated. That is not backward compatible anymore as now it expects MongoClient from com.mongodb.client.MongoClient and for an application that provides MongoClient bean for com.mongodb.MongoClient class it won't work. Would it be possible to create different releases for the two changes in this release, as it has one change from me related to @Order annotation on aspects and i was hoping it would run well with the current stack of my application.
    Bartosz Walacik
    @bartoszwalacik
    hi, I understand your issue
    but current CI/CD flow is based on releasing from master
    i need to check if releasing javers/javers@f29eabd is possible
    Bartosz Walacik
    @bartoszwalacik
    I will try to release the next version, which will be compatible with both mongo clients
    Bartosz Walacik
    @bartoszwalacik
    Ketan Nabera
    @K10Codes
    @bartoszwalacik Thanks for the update. I was also trying to do a local run by building this branch and include the dependency in my project. The application boots up successfully but when i change some data for an auditable entity.. I get this exception java.lang.NoSuchMethodError: com.mongodb.client.MongoCollection.insertOne(Ljava/lang/Object;) from org.javers.repository.mongo.MongoRepository.lambda$persistSnapshots$3.
    It got my head spinning as that code is the same and i feel its maybe because of the mongo driver update which javers run on but the application's mongo driver version is different. I am just guessing this now !
    Ketan Nabera
    @K10Codes
    I dug more into this exception and this seems to be coming as a result of mongoDriver update from 3.11.2 to 4.0.3 in the latest release.
    Bartosz Walacik
    @bartoszwalacik
    which version of Spring Boot do you use?
    Bartosz Walacik
    @bartoszwalacik
    looks like you have both mongo drivers (3 & 4) on your classpath
    Ketan Nabera
    @K10Codes
    Things worked fine before this release on 5.9.2-SNAPSHOT actually, just about the time when i made the change. Thus i am assuming it has something to do with the mongo driver update from within javers since my application's stack has not changed during this time
    Ketan Nabera
    @K10Codes
    image.png

    i am using springBootVersion = '2.1.5.RELEASE' and
    mongoDriverVersion = '3.11.2'.

    I also looked up the application build path and i find the following dependencies :

    Bartosz Walacik
    @bartoszwalacik
    looks like you are forced to upgrade to Spring Boot 2.3
    I can't see any other solution
    Ketan Nabera
    @K10Codes
    Yes, that's what i have started to realize. I am not sure if i can ask this but is there any way to split those two commits which created 5.9.2 so that i will be able to pull my changes atleast and in future when i update the application version I can then move back to the javers latest release. I see lot of potential issues with this driver update for existing users and was hoping if this can come handy.
    Bartosz Walacik
    @bartoszwalacik
    seems reasonable
    Bartosz Walacik
    @bartoszwalacik
    I will try to do it tomorrow
    Bartosz Walacik
    @bartoszwalacik
    @K10Codes grab 5.9.4
    Ketan Nabera
    @K10Codes
    Thank you @bartoszwalacik (y) . Much appreciated.