Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Geoffrey De Smet
    @ge0ffrey
    @jonbullock:matrix.org It's ready for review!
    jonbullock
    @jonbullock:matrix.org
    [m]
    Excellent thanks @ge0ffrey ancho
    Geoffrey De Smet
    @ge0ffrey
    If the 740 PR is too big to review (it contains all maven plugin history too), I can split it up into 2 PRs for your convenience: one that just do the git history move and one that does our additional changes to integrate it in the build (many thanks to ancho for contributing to this)
    jonbullock
    @jonbullock:matrix.org
    [m]
    Did you still want the JReleaser PR merged in first?
    Geoffrey De Smet
    @ge0ffrey
    No, not needed
    I hope they don't merge conflict - with the "upgrade to gradle 7" changes, they might
    Once PR 740 is merged, I can start the same process for the jbake-gradle-plugin
    Geoffrey De Smet
    @ge0ffrey
    @jonbullock:matrix.org If you merge 740, don't forgot to go to the settings of https://github.com/jbake-org/jbake-maven-plugin and first change the description to "moved into jbake repo" and then mark it as "archived" in github settings.
    jonbullock
    @jonbullock:matrix.org
    [m]
    I was expecting a merge conflict, but I reviewed Andres' PR again and the changes are small in comparison so I can always resolve manually.
    Thanks for the reminder @ge0ffrey
    Just reviewed the PR and just 1 question about an optional flag that has been dropped.
    Geoffrey De Smet
    @ge0ffrey
    That one slipped through, let me fix that.
    Fixed :)
    jonbullock
    @jonbullock:matrix.org
    [m]
    Happy new year everyone! 🥳🎉
    ancho
    @ancho:matrix.cirk2.de
    [m]
    Happy new year 😉
    Geoffrey De Smet
    @ge0ffrey
    Happy new year!
    Manik Magar
    @manikmagar:matrix.org
    [m]
    Happy New year all! Hope this new year brings more happiness and prosperity to you and your family!
    Geoffrey De Smet
    @ge0ffrey
    So, now that the maven plugin is merged in, I guess it's time for the gradle plugin.
    And as far as I can tell there one open discussion: which gradle version is it build with.
    Jbake is build with gradle 7 now. This means the plugin would be build with gradle 7 too. Is that a problem? Would it still run on gradle 6?
    @jonbullock:matrix.org @ancho:matrix.cirk2.de What do you think?
    ancho
    @ancho:matrix.cirk2.de
    [m]
    The open PR is not that important. We can take care of it later. The answer to the question if it will still build on gradle 7 is as always: it depends 😉
    If the used plugins are compatible it propably works.
    Geoffrey De Smet
    @ge0ffrey
    so we just start doing it and then see if it still runs with gradle 6 on the freemarker example?
    ancho
    @ancho:matrix.cirk2.de
    [m]

    basically yes. the plugin itself has integration tests that make sure it works with different versions of gradle. the question is if the plugin itself is compatible with gradle 7 as it uses some gradle api features like whe WorkAction api now.

    see https://github.com/jbake-org/jbake-gradle-plugin/blob/master/src/test/groovy/org/jbake/gradle/JbakeIntegrationSpec.groovy#L38
    and https://github.com/jbake-org/jbake-gradle-plugin/blob/master/src/main/groovy/org/jbake/gradle/impl/JBakeWorkAction.groovy

    Benjamin Marwell
    @bmarwell
    hi! I set content.rootpath, but somehow is is empty in my freemarker templates. I think this is unintended.
    1 reply
    Benjamin Marwell
    @bmarwell
    Another thing that I'd like to mention: Having a LOT of static assets (and I mean a LOT, a few tenthousand files) will make jbake:inline VERY slow and cumbersome, because one template or page change will make jbake re-copy all files.
    mhberger
    @mhberger
    That is a lot. Is that by some chance a node_modules directory?
    Benjamin Marwell
    @bmarwell
    No, it's javadoc we keep from older versions. https://github.com/apache/shiro-site/tree/jbake/jbake/assets
    We can offload bootstrap and highlightjs. But I'd like to serve from the same domain.
    Then, there's all the old sites+javadocs in assets/static (plus a missing link: latest or current to the actual version which jbake doesn't support either).
    Tobias Roeser
    @lefou
    I used to build sites with a build tool and a JBake plugin. That way, you can offload the asset copy job to the build tool, which is able to do it more efficiently, e.g. only when needed.
    Benjamin Marwell
    @bmarwell
    Tried it, but that will make jbake:inline not work anymore.
    Nils Breunese
    @breun
    Hi, I'm trying to convert my blog from Jekyll to JBake. One thing I'm running into is that the documentation for the metadata header only shows a date field, but I also have the time of day in my old posts. If I copy these values as is (e.g. 2003-02-02 12:49:57 +0100) into the date field, then JBake can still generate the static site, but it seems the time of day isn't used for the order of the posts. My blog's first post is now the second post in JBake's ordering. Is it possible to have JBake also consider the post time of day?
    16 replies
    Nils Breunese
    @breun
    Also, according to https://jbake.org/news/jbake-v2.7.0-release-candidate.html JBake 2.7.0 and later will have a matching version of jbake-maven-plugin. I see there are release candidate artifacts for jbake-core 2.7.0 available on Maven Central (https://search.maven.org/artifact/org.jbake/jbake-core), but is it correct that there are no matching release candidate versions of jbake-maven-plugin on Maven Central (https://search.maven.org/artifact/org.jbake/jbake-maven-plugin) yet?
    4 replies
    Benjamin Marwell
    @bmarwell
    @breun yes
            <groupId>org.jbake</groupId>
            <artifactId>jbake-maven-plugin</artifactId>
            <version>0.3.6-rc.2</version>
    but there's basically no support for jbake. Issues are not even being responded to and I am not even getting help where to start so I could create PRs myself.
    The data feature from jbake 2.7 is immature, too. Arrays work fine, but if you try to use hashes (maps), you get a class class com.orientechnologies.orient.core.db.record.OTrackedMap returned instead :(
    2 replies
    The maven plugin will not work as expected: the jbake:inline call stops when a freemarker error occurs (when it shouldn't).
    sourceuri has the wrong content
    Benjamin Marwell
    @bmarwell
    Large assets folders will be copied one-by-one, there is no link method or unfiltered copy.
    Benjamin Marwell
    @bmarwell
    @jonbullock see https://gitter.im/jbake-org/jbake?at=620958ed51bd8b580ca0c0b4 please. I would really like to help out! But everytime I ask something specific, I somehow do not seem to get an answer.
    4 replies
    nerdusan
    @nerdusan
    I added an entry for JBAKE_HOME/bin on my computer but it's not working? Someone help please
    I am using a windows machined
    nerdusan
    @nerdusan
    Done
    jonbullock
    @jonbullock:matrix.org
    [m]
    @nerdusan: Did you add the entry to the PATH environment variable? If so, what version of Java do you have installed?
    Tobias Roeser
    @lefou

    I'd like to re-ask my very old but still current question first asked here: https://gitter.im/jbake-org/jbake?at=5c68865080df6804a1b83744

    In the mood of updating JBake plugins for SBuild, sbt and newly writing one for mill, I noticed, that since 2.6.2 it is not possible to serve a local site when there is no subfolder "output".
    E.g. jbake -s dest/pathalways assumes, that my contents root is dest/path/output, which is not.
    This was not the case for jbake versions prior to 2.6.2.

    Tobias Roeser
    @tobiasroeser:matrix.org
    [m]
    jonbullock: Can you shed some light about the current state. My above reported issue, which has even a PR from 2019 is still not merged. It is targeted to 2.8.0, although the issue was a compatibility breakage in 2.6.2, so the fix should also went into the next 2.6.x release. I'd argue, just cutting a new 2.6.x release just with this fix would be appropriate
    jonbullock
    @jonbullock:matrix.org
    [m]
    Sorry recently started a new job @lefou I thought I'd added notes to that issue but obviously not, from what I remember the PR created other issues which is why it hasn't been merged in. I'll review the situation and add notes to that issue.
    Tobias Roeser
    @tobiasroeser:matrix.org
    [m]
    jonbullock: Congrat to the new job. In the meantime, I've found a workaround, which I already posted here: https://github.com/jbake-org/jbake/issues/594#issuecomment-1124924835
    The clue is to explicitly specify an source and destination directory.
    I think the issue started with the change of the cli parser.