I am not sure how will I write unittest for "write" functionality...
As the feature is to write to a file, would it make sense to read the written file?
If it does then, for project types like Maven where we use mvn help:evaluate -Dexpression=project.version command to read the version, a parser for pom.xml would be needed just for the test...
@adi10hero:matrix.org , after your PR #85 will be merged do you want I do the same feature for NPM ?
2 replies
@philippart-s: Reviewed your PR, just 1 minor change from my side which helped passing tests (locally).
2 replies
Apart from that, the only problem I saw was when I put incrementPreRelease information and the version did not have preRelease info.
Yes I understand that this doesn't make a lot of sense to do but what I am trying to say is that we need to add some checks or error handling/logging in the near future
Yes I understand that this doesn't make a lot of sense to do but what I am trying to say is that we need to add some checks or error handling/logging in the near future
3 replies
Shall I go ahead and merge Stéphane Philippart 's jenkinsci/conventional-commits-plugin#75?
Asking as review is requested + it's a big feature so in case we missed something :)
Asking as review is requested + it's a big feature so in case we missed something :)
Thank you @garethjevans for reviewing.. Feels a lot more confident now :)
Stéphane Philippart: I wanted some help wrt your comment
How do I check with what params was the processHelper called?
How do I check with what params was the processHelper called?
6 replies
I am facing issues when I am writing the following tests:
- Unsupported project type with writeVersion called: In this case there's only a single log message written to the console.. how do I test that?
- Writing a jenkins tests with a sample maven project with the writeVersion parameter as "true" times out :( Any solution around that?
(I am stuck for hours now 😅)
5 replies
Writing a jenkins tests with a sample maven project with the writeVersion parameter as "true" times out :( Any solution around that?
(I am stuck for hours now 😅)
It's in the JenkinsTest class or in a Jenkins Job ?
10 replies
@garethjevans: I will be available at the usual time for our weekly meeting
Hi everyone esp. @adi10hero:matrix.org , please make sure you participate in the poll on slack regarding the final demo. Thanks in advance!
Hi, I've just finished the PR #91 and I have some questions :
- why do we set version 8 for the JDK and not 11 ?
- when I run
mvn hpi-runand create a pipeline job to test the plugin I've the following error :Cannot run program "git" (in directory "/home/stephane/Developpements/oss/conventional-commits-plugin/work/workspace/test.Obviously git is installed on my device, do I run the test plugin in a real Jenkins instance ? - for integration tests we can't test a real call to the external program (like npm, helm, ...) I choose to use mock to reproduce the real comportment, is it ok for you ? Is there another way to do an integration test with real command (docker, install the CLI on the CI environment, in the tests, ...) ?
2 replies
In this week, I was planning to complete tasks like updating the GSoC project page, submit final evaluation, update presentation slides, etc
Will it be fine if I do code related tasks after I am done with these?
Will it be fine if I do code related tasks after I am done with these?
Getting the blog post in early makes it much easier to do reviews and scheduling\
Ah yes, 2nd blog needs to be written as well.. Thank you for reminding @kwhetstone :)
@mentors, What would be a good work submission for the final evaluation? (Guidelines: https://developers.google.com/open-source/gsoc/help/work-product). Reading the 3rd point, will the GitHub repo of the plugin be sufficient?
https://doodle.com/poll/edepxx6g9w4izzir?utm_source=poll&utm_medium=link -> here's the doodle poll for picking a time for the presentation
1 reply
I have submitted the work (GitHub repository) and the student evaluation.
I am not sure what I should add in GSoC final presentation PPT..
I changed the next steps part (easy) and new features could be demoed..
Can we add anything else in the PPT?
Got it! I will add that. Would it be okay to write steps to add a package/project type... Eg.
- Add the type in the factory class
- Create a public class...
Yes I think big picture steps are enough, just to help potential contributor where to look at
1 reply
too much documentation is not always a good idea as it has to be maintained, and outdate documentation is really bad
Woops.. The CD failed :(
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project conventional-commits: Failed to deploy artifacts: Could not transfer artifact io.jenkins.plugins:conventional-commits:hpi:0.7.3 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): authentication failed for https://repo.jenkins-ci.org/releases/io/jenkins/plugins/conventional-commits/0.7.3/conventional-commits-0.7.3.hpi, status: 401 Unauthorized -> [Help 1]
Hello @MarkEWaite, No, It isn't the first run and yeah we are using automated CD, which is exactly why I was surprised at it failing 😅
Hi all, just starting the issue #81 and I have a question : I'm less familiar with gradle than maven, for me there is non command line to write back to the build.gradle sot I write the next version with Java code . Is it ok for you or did I miss a magic gradle option ? 😉
3 replies
I haven't been around a lot and I am sorry for that. I wanted to let y'all know -- I just graduated (didn't even get a farewell thanks to covid :/ ). A lot of my time was invested in looking for a job and simultaneously apply for Masters (next fall). I would really like to take some time for masters applications. So, the frequency of contribution would be low for some time. 😅
3 replies
Hi (again :wink:), do you think that we'll must update maintenaires members (I don't know if I have the level but I can help for this role if you want). And another question : do you think this plugin can be proposed to hacktoberfest or we don't have enough issues ?
2 replies
Thanks for yours answers, I'll try the process to join the maintainers list ! For hacktoberfest I think that will be a good "boost" for the project, I'll try this week-end to create issues and read how to propose this project to hacktoberfest 😉
Before i request the access I see there is another maintainers (I didn't know there is already 5 maintainers), is it ok for you @garethjevans , olblak , @kwhetstone and @Dohbedoh that I do this kind of demand. The goal was to help the plugin to live as kuro has less time but perhaps you are enough as maintainers ?