Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 06 11:58
    dependabot[bot] synchronize #254
  • Feb 06 11:57
    dependabot[bot] synchronize #252
  • Feb 06 11:57

    dependabot[bot] on maven

    chore(deps-dev): bump mockito-c… (compare)

  • Feb 06 11:57

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • Feb 06 11:57
    dependabot[bot] edited #254
  • Feb 06 11:57
    dependabot[bot] edited #252
  • Feb 06 11:57
    dependabot[bot] edited #254
  • Feb 06 11:57
    dependabot[bot] edited #252
  • Feb 06 11:57

    garethjevans on maven

    (compare)

  • Feb 06 11:57

    garethjevans on main

    chore(deps): bump checkstyle fr… Merge pull request #255 from je… (compare)

  • Feb 06 11:57
    garethjevans closed #255
  • Feb 06 02:03
    github-actions[bot] labeled #254
  • Feb 06 02:03
    github-actions[bot] labeled #255
  • Feb 06 01:47
    dependabot[bot] labeled #255
  • Feb 06 01:47
    dependabot[bot] labeled #255
  • Feb 06 01:47
    dependabot[bot] opened #255
  • Feb 06 01:47

    dependabot[bot] on maven

    chore(deps): bump checkstyle fr… (compare)

  • Feb 06 01:47

    dependabot[bot] on maven

    (compare)

  • Feb 06 01:47
    dependabot[bot] closed #253
  • Feb 06 01:47
    dependabot[bot] commented #253
olblak
@olblak:matrix.org
[m]
I am open to other suggestion, I guess it goes to notice or debug
3 replies
kuro
@adi10hero:matrix.org
[m]
Made PR for reading from build.gradle :) Please review.
I will be working next on reading from package.json... What project type shall we call it? 😅
Please let me know if I shall work on anything else (eg. breaking change fix) first
2 replies
Kristin Whetstone
@kwhetstone
Hm, good question on the package.json. Those types of files are found in node.js so I'd go with node
1 reply
@adi10hero:matrix.org I think you're going in the right direction! The most important thing right now is adding all the support for the different types of projects.
You shouldn't have too many PRs open at once, so let's get the "BREAKING CHANGES" footer closed this week.
Kristin Whetstone
@kwhetstone
The first check in period is 12 July. At the start of next week, let's get a feel for how much work is left in this first milestone period. I think you're on track to have all the types done, and their tests. I think, mentors chime in here with votes, after you have the other project types finished, at the end of next week, you will be able to release a new version of the plugin which will be fully downloadable from the Jenkins plugin website. Having something useable and demoable is going to be a great milestone achievement. What does everyone think?
That way the week of the evaluations, you can do documentation and even write a blog post (I think we're required to do that for Jenkins GSoC this year, so with the fully released version of the plugin, you won't have to worry about it)
1 reply
Gareth Evans
@garethjevans
@adi10hero:matrix.org are you ok for our catchup tomorrow morning (for me)?
I'll send a link out before hand
kuro
@adi10hero:matrix.org
[m]
Yes, I will be there (if its okay with you)
Gareth Evans
@garethjevans
Kristin Whetstone
@kwhetstone
There's a build failure for the gradle pr. I think if you fix that you can merge and start working on the next type!
4 replies
kuro
@adi10hero:matrix.org
[m]
@garethjevans: A new contributor wants to work on package.json issue, he's asking whether he can work on it, tagged me as well, I had just created a new branch, did not really work anything, what should be done?
Gareth Evans
@garethjevans
@adi10hero:matrix.org awesome, the more the merrier! if you can get them to assign the issue to them that would be great, and if you'd like to take charge of the reviews that would help out - also feel free to invite them to this channel if they want to chat about it
Stéphane Philippart
@philippart-s
Hi everybody ! I'm the "new contributor wants to work on package.json issue" :wink:
I'm a "newcomer contributor" but a senior Java developer. In my job I'm in charge of develop Jenkins pipeline as code (groovy in shared lib).
Glad you accept my contribution, I done a similar feature in a Jenkins pipeline (thus with Groovy code).
To summarize I'm using the npm version command to "compute" next version.
If it's ok for you I open a PR to discuss of the best way to do the feature (not necessarily by using npm version command, it was just an idea :wink:)
olblak
@olblak:matrix.org
[m]
Hi @philippart-s That's sound a super idea, in the context of Gsoc, kuro is working on the plugin and I think that every collaboration is more than welcome
Stéphane Philippart
@philippart-s
cool :smiley: , I'll create the PR as soon as possible.
Another question : I'did not found any coding rule or .editorconfig to format code. Is it free or do you use external standards (like Oracle conventions for example), I think for new contributors (like me) it's a good think to have these kind of resources / documentation.
I don't know if I have to create an issue for this "internal" feature proposal or initiate a dedicated PR.
Kristin Whetstone
@kwhetstone
@philippart-s it probably would be easiest to create an issue to track what you're working on
1 reply
@adi10hero:matrix.org With the coding phase 1 coming to a close soon, we want to make sure that you can have a new release of the plugin out for the initial review. Is there anything we can help you with?
kuro
@adi10hero:matrix.org
[m]
Actually, yes, testing is taking time, it will be really helpful if I get an example of what is needed (my weekend + Monday got wasted due to bad health), once the basic testing framework is in place, rest PRs would come quickly
6 replies
Stéphane Philippart
@philippart-s
hi, I've pushed the PR (still in progress, in case you want to take a look) : jenkinsci/conventional-commits-plugin#52. If I understand it's just the reading of the version number that it be done, not the compute of the next version ? There is few code comments, it's my comprehension of the code :wink:
5 replies
Stéphane Philippart
@philippart-s
Hi all,
PR is ready to review : jenkinsci/conventional-commits-plugin#52
I think when PR will be approve I can do the same dev for Chart.yaml (issue #20).
kuro
@adi10hero:matrix.org
[m]
hello @philippart-s , I reviewed your PR, it looks good to me :)
Would merge, waiting for a mentor to go over it once (just to be sure)
kuro
@adi10hero:matrix.org
[m]
Finallyy... Mocking Successful! Thank you so much @garethjevans, your example PR really helped (and I learnt a lot too, research + trial and error took around 5 hours yesterday, after your PR it was done under 1 hour :) )
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org If it's ok for you, you can assign me the #20 issue in order to I start the conception / dev :)
3 replies
Gareth Evans
@garethjevans
@philippart-s there are some conflicts that need to be resolved after I merged another PR, it may require a slight change to the code to use the newly introduced ProcessHelper to aid mocking
Stéphane Philippart
@philippart-s
@garethjevans I check to merge and resolve conflicts from main to my branch and update my PR :wink:
adi10hero
@adi10hero:matrix.org
[m]
@all, I would be working on reading current version from Makefile, doing some research on it, I have some doubts..
  1. Makefile doesn't really has a convention for writing version, it can be VERSION= or VERSION:= I also saw, version:= (lower case)
  2. version may or may not be "static", variables might be used to denote the version, for example" version := $(command)
Handling 1. is easy, but for 2, I did not find any CLI command to print out (evaluate) the version, there are some which change the Makefile to add a print section to the Makefile and then run make print to evaluate version.
2 replies
For such a case, would it make sense to:
  1. Copy the Makefile
  2. Add the print section
  3. get the version
  4. delete the copy Makefile
In my proposal, I had put using j4make but it is not what I expected it to be :(
Gareth Evans
@garethjevans
@adi10hero:matrix.org I'll be online tomorrow at the usual time if you can make it?
kuro
@adi10hero:matrix.org
[m]
Yes, I will be there :)
Gareth Evans
@garethjevans
great
Gareth Evans
@garethjevans
@adi10hero:matrix.org I'm on https://us02web.zoom.us/j/87686139913
Stéphane Philippart
@philippart-s
@garethjevans the merge from main is done for the PR #18
kuro
@adi10hero:matrix.org
[m]
@garethjevans: I've written basic "PythonProjectType" class, not making the PR now, as it'll anyway conflict when codestyle PR (#60) get's merged. Also there are 2 issues regarding python project type and I plan to fix each with a separate PR, is that fine?
kuro
@adi10hero:matrix.org
[m]
@mentors, There's only one issue left in Milestone1 (reading from helm.yaml), @philippart-s is working on it, so I started with "reading from python's setup.cfg" issue (#48), does it make sense to continue working on it or am I expected to do something else (other than filling the feedback form) as Phase 1 is ending?
Stéphane Philippart
@philippart-s
I was off this week end but I think I can end the development fot the mid of the next week.
Stéphane Philippart
@philippart-s
just init the PR : jenkinsci/conventional-commits-plugin#65 :wink: , still in progress
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org I think what's going to help the most is driving the plugin towards a releasable version
Kristin Whetstone
@kwhetstone
Let's get the codestyle PR merged (there's a failing test???) to allow you get the Python stuff in. After that, I think that your focus should be on getting the plugin ready to release a new version so people can try it out
kuro
@adi10hero:matrix.org
[m]
hello @kwhetstone actually, I made the python PR, I had also pushed codestyle fixes (150+) in another PR (which showed 0 errors) but I guess it was using some old config.
Would it okay for us to merge the python PR and other PRs as well and then I can finally fix the remaining codestyle errors and do the release? :)
Stéphane Philippart
@philippart-s
Hi, PR #65 for Helm chart is ready to review but CI failed with error on the junit step like the PR #55 . Is there a CI configuration problem ?
Stéphane Philippart
@philippart-s
ok I find the pb : Require upper bound dependencies error for org.yaml:snakeyaml:1.27, try to find a solution to avoid this conflict, set the PR to draft again
Stéphane Philippart
@philippart-s
PR #65 is ok now, I exclude the snakeyaml dependency from the jakson dependency. I assume that in a real Jenkins that the snakeyaml version is the same that the workflow-aggregator dependency