Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:42
    github-actions[bot] labeled #239
  • 01:34
    dependabot[bot] labeled #239
  • 01:34
    dependabot[bot] labeled #239
  • 01:34
    dependabot[bot] opened #239
  • 01:34

    dependabot[bot] on maven

    chore(deps): bump checkstyle fr… (compare)

  • Nov 21 18:45
  • Nov 21 11:02
    dependabot[bot] synchronize #238
  • Nov 21 11:02

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • Nov 21 11:02
    dependabot[bot] edited #238
  • Nov 21 11:01
    dependabot[bot] edited #238
  • Nov 21 11:01

    garethjevans on maven

    (compare)

  • Nov 21 11:01
    garethjevans closed #237
  • Nov 21 11:01

    garethjevans on main

    chore(deps-dev): bump mockito-c… Merge pull request #237 from je… (compare)

  • Nov 21 02:07
    github-actions[bot] labeled #237
  • Nov 21 02:07
    github-actions[bot] labeled #238
  • Nov 21 01:41

    dependabot[bot] on maven

    (compare)

  • Nov 21 01:41
    dependabot[bot] closed #236
  • Nov 21 01:41
    dependabot[bot] commented #236
  • Nov 21 01:41
    dependabot[bot] labeled #238
  • Nov 21 01:41
    dependabot[bot] labeled #238
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org With the coding phase 1 coming to a close soon, we want to make sure that you can have a new release of the plugin out for the initial review. Is there anything we can help you with?
kuro
@adi10hero:matrix.org
[m]
Actually, yes, testing is taking time, it will be really helpful if I get an example of what is needed (my weekend + Monday got wasted due to bad health), once the basic testing framework is in place, rest PRs would come quickly
6 replies
Stéphane Philippart
@philippart-s
hi, I've pushed the PR (still in progress, in case you want to take a look) : jenkinsci/conventional-commits-plugin#52. If I understand it's just the reading of the version number that it be done, not the compute of the next version ? There is few code comments, it's my comprehension of the code :wink:
5 replies
Stéphane Philippart
@philippart-s
Hi all,
PR is ready to review : jenkinsci/conventional-commits-plugin#52
I think when PR will be approve I can do the same dev for Chart.yaml (issue #20).
kuro
@adi10hero:matrix.org
[m]
hello @philippart-s , I reviewed your PR, it looks good to me :)
Would merge, waiting for a mentor to go over it once (just to be sure)
kuro
@adi10hero:matrix.org
[m]
Finallyy... Mocking Successful! Thank you so much @garethjevans, your example PR really helped (and I learnt a lot too, research + trial and error took around 5 hours yesterday, after your PR it was done under 1 hour :) )
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org If it's ok for you, you can assign me the #20 issue in order to I start the conception / dev :)
3 replies
Gareth Evans
@garethjevans
@philippart-s there are some conflicts that need to be resolved after I merged another PR, it may require a slight change to the code to use the newly introduced ProcessHelper to aid mocking
Stéphane Philippart
@philippart-s
@garethjevans I check to merge and resolve conflicts from main to my branch and update my PR :wink:
adi10hero
@adi10hero:matrix.org
[m]
@all, I would be working on reading current version from Makefile, doing some research on it, I have some doubts..
  1. Makefile doesn't really has a convention for writing version, it can be VERSION= or VERSION:= I also saw, version:= (lower case)
  2. version may or may not be "static", variables might be used to denote the version, for example" version := $(command)
Handling 1. is easy, but for 2, I did not find any CLI command to print out (evaluate) the version, there are some which change the Makefile to add a print section to the Makefile and then run make print to evaluate version.
2 replies
For such a case, would it make sense to:
  1. Copy the Makefile
  2. Add the print section
  3. get the version
  4. delete the copy Makefile
In my proposal, I had put using j4make but it is not what I expected it to be :(
Gareth Evans
@garethjevans
@adi10hero:matrix.org I'll be online tomorrow at the usual time if you can make it?
kuro
@adi10hero:matrix.org
[m]
Yes, I will be there :)
Gareth Evans
@garethjevans
great
Gareth Evans
@garethjevans
@adi10hero:matrix.org I'm on https://us02web.zoom.us/j/87686139913
Stéphane Philippart
@philippart-s
@garethjevans the merge from main is done for the PR #18
kuro
@adi10hero:matrix.org
[m]
@garethjevans: I've written basic "PythonProjectType" class, not making the PR now, as it'll anyway conflict when codestyle PR (#60) get's merged. Also there are 2 issues regarding python project type and I plan to fix each with a separate PR, is that fine?
kuro
@adi10hero:matrix.org
[m]
@mentors, There's only one issue left in Milestone1 (reading from helm.yaml), @philippart-s is working on it, so I started with "reading from python's setup.cfg" issue (#48), does it make sense to continue working on it or am I expected to do something else (other than filling the feedback form) as Phase 1 is ending?
Stéphane Philippart
@philippart-s
I was off this week end but I think I can end the development fot the mid of the next week.
Stéphane Philippart
@philippart-s
just init the PR : jenkinsci/conventional-commits-plugin#65 :wink: , still in progress
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org I think what's going to help the most is driving the plugin towards a releasable version
Kristin Whetstone
@kwhetstone
Let's get the codestyle PR merged (there's a failing test???) to allow you get the Python stuff in. After that, I think that your focus should be on getting the plugin ready to release a new version so people can try it out
kuro
@adi10hero:matrix.org
[m]
hello @kwhetstone actually, I made the python PR, I had also pushed codestyle fixes (150+) in another PR (which showed 0 errors) but I guess it was using some old config.
Would it okay for us to merge the python PR and other PRs as well and then I can finally fix the remaining codestyle errors and do the release? :)
Stéphane Philippart
@philippart-s
Hi, PR #65 for Helm chart is ready to review but CI failed with error on the junit step like the PR #55 . Is there a CI configuration problem ?
Stéphane Philippart
@philippart-s
ok I find the pb : Require upper bound dependencies error for org.yaml:snakeyaml:1.27, try to find a solution to avoid this conflict, set the PR to draft again
Stéphane Philippart
@philippart-s
PR #65 is ok now, I exclude the snakeyaml dependency from the jakson dependency. I assume that in a real Jenkins that the snakeyaml version is the same that the workflow-aggregator dependency
Kristin Whetstone
@kwhetstone
I think @adi10hero:matrix.org I think you can fix this too? jenkinsci/conventional-commits-plugin#55 -> I just "synced with the main branch"
The dependabot merges can go in after the python pr too. I'm looking at that now :)
kuro
@adi10hero:matrix.org
[m]
Gotcha! :) Thank you @kwhetstone
Stéphane Philippart
@philippart-s
I know my PR is not yet reviewed but if you want I can work on another issue (#23, #24 or #51 but for this one I think there is already PR with checkstyle)
kuro
@adi10hero:matrix.org
[m]
Hello @philippart-s , I saw your PR, looks good to me, but it is now conflicting because of other merges, can you please update it. Also with respect to #51, what IDE configurations can we have? (would like your help in this part). Checkstyle is technically not an IDE config right, more like a project config.
olblak
@olblak:matrix.org
[m]
kuro: the problem with @garethjevans formatting pr, is we must first fix formatting issues detected by his PR
that's the problem when you introduce such tool when you already have acode base
kuro
@adi10hero:matrix.org
[m]
Ah yes, I will do that next (once my python PR and @philippart-s 's PR is merged)
But olblak , that formatting PR wouldn't be the reason why CD (on the main branch) is failing right?
olblak
@olblak:matrix.org
[m]
no cd is failing because we try to push a version that already exist
because we introduce new feature, it tries to publish a release on 0.3.0
It's a setting on repo.jenkins-ci.org to disallow overriding published artifacts
olblak
@olblak:matrix.org
[m]
and the problem is that version is now published on every mirrors https://get.jenkins.io/plugins/conventional-commits/0.3.0/conventional-commits.hpi?mirrorlist
1 reply
I need to double check but we should create a new empty github release named 0.3.0, @garethjevans any opinions?
olblak
@olblak:matrix.org
[m]
kuro: don't worry that kind of mistake happen, I need a break and then I'll create an empty release 0.3.0 on github
kuro
@adi10hero:matrix.org
[m]
Okay olblak, thank you so much, is there anything we (I) can do to avoid such mistakes in the future?
olblak
@olblak:matrix.org
[m]
Nope the cd pipeline is just broken :D