Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 08 13:39
    rcjames commented #209
  • Aug 08 13:38
    rcjames commented #209
  • Aug 03 20:29
    philippart-s commented #209
  • Aug 03 11:07
    dependabot[bot] synchronize #212
  • Aug 03 11:07

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • Aug 03 11:07
    dependabot[bot] edited #212
  • Aug 03 11:07
    dependabot[bot] edited #212
  • Aug 03 11:06

    garethjevans on maven

    (compare)

  • Aug 03 11:06

    garethjevans on main

    chore(deps): bump gson from 2.9… Merge branch 'main' into depend… Merge pull request #210 from je… (compare)

  • Aug 03 11:06
    garethjevans closed #210
  • Aug 03 10:58
    garethjevans auto_merge_enabled #210
  • Aug 03 10:58
    dependabot[bot] synchronize #212
  • Aug 03 10:58

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • Aug 03 10:58
    dependabot[bot] edited #212
  • Aug 03 10:58
    dependabot[bot] edited #210
  • Aug 03 10:58
    garethjevans synchronize #210
  • Aug 03 10:58

    garethjevans on maven

    chore(deps): bump checkstyle fr… Merge pull request #211 from je… Merge branch 'main' into depend… (compare)

  • Aug 03 10:58
    dependabot[bot] edited #210
  • Aug 03 10:58
    dependabot[bot] edited #212
  • Aug 03 10:57

    garethjevans on maven

    (compare)

Kristin Whetstone
@kwhetstone
Let's get the codestyle PR merged (there's a failing test???) to allow you get the Python stuff in. After that, I think that your focus should be on getting the plugin ready to release a new version so people can try it out
kuro
@adi10hero:matrix.org
[m]
hello @kwhetstone actually, I made the python PR, I had also pushed codestyle fixes (150+) in another PR (which showed 0 errors) but I guess it was using some old config.
Would it okay for us to merge the python PR and other PRs as well and then I can finally fix the remaining codestyle errors and do the release? :)
Stéphane Philippart
@philippart-s
Hi, PR #65 for Helm chart is ready to review but CI failed with error on the junit step like the PR #55 . Is there a CI configuration problem ?
Stéphane Philippart
@philippart-s
ok I find the pb : Require upper bound dependencies error for org.yaml:snakeyaml:1.27, try to find a solution to avoid this conflict, set the PR to draft again
Stéphane Philippart
@philippart-s
PR #65 is ok now, I exclude the snakeyaml dependency from the jakson dependency. I assume that in a real Jenkins that the snakeyaml version is the same that the workflow-aggregator dependency
Kristin Whetstone
@kwhetstone
I think @adi10hero:matrix.org I think you can fix this too? jenkinsci/conventional-commits-plugin#55 -> I just "synced with the main branch"
The dependabot merges can go in after the python pr too. I'm looking at that now :)
kuro
@adi10hero:matrix.org
[m]
Gotcha! :) Thank you @kwhetstone
Stéphane Philippart
@philippart-s
I know my PR is not yet reviewed but if you want I can work on another issue (#23, #24 or #51 but for this one I think there is already PR with checkstyle)
kuro
@adi10hero:matrix.org
[m]
Hello @philippart-s , I saw your PR, looks good to me, but it is now conflicting because of other merges, can you please update it. Also with respect to #51, what IDE configurations can we have? (would like your help in this part). Checkstyle is technically not an IDE config right, more like a project config.
olblak
@olblak:matrix.org
[m]
kuro: the problem with @garethjevans formatting pr, is we must first fix formatting issues detected by his PR
that's the problem when you introduce such tool when you already have acode base
kuro
@adi10hero:matrix.org
[m]
Ah yes, I will do that next (once my python PR and @philippart-s 's PR is merged)
But olblak , that formatting PR wouldn't be the reason why CD (on the main branch) is failing right?
olblak
@olblak:matrix.org
[m]
no cd is failing because we try to push a version that already exist
because we introduce new feature, it tries to publish a release on 0.3.0
It's a setting on repo.jenkins-ci.org to disallow overriding published artifacts
olblak
@olblak:matrix.org
[m]
and the problem is that version is now published on every mirrors https://get.jenkins.io/plugins/conventional-commits/0.3.0/conventional-commits.hpi?mirrorlist
1 reply
I need to double check but we should create a new empty github release named 0.3.0, @garethjevans any opinions?
olblak
@olblak:matrix.org
[m]
kuro: don't worry that kind of mistake happen, I need a break and then I'll create an empty release 0.3.0 on github
kuro
@adi10hero:matrix.org
[m]
Okay olblak, thank you so much, is there anything we (I) can do to avoid such mistakes in the future?
olblak
@olblak:matrix.org
[m]
Nope the cd pipeline is just broken :D
If you want to learn you can open a PR or I can help :)
1 reply
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org fixes for my PR and merge from main are push. For the #51 I think that configurations like spaces instead tab, line length, end of line, ... are the minimal configurations that helm review and be compatible with almost IDE (VScode, Eclispe, Intellij and Netbeans). THe PR will be the place where we discuss what formatting parameters we want to add :wink:
I can also work on #23 or #24 if you want
kuro
@adi10hero:matrix.org
[m]
@philippart-s: got it, makes sense to that :) Also please feel free to work on any issue you like ^^ I will take the other one :)
1 reply
olblak
@olblak:matrix.org
[m]
@kuro Apparently I am wrong, I am currently looking
@kuro https://meet.google.com/erp-dmcj-sut we are currently debugging it if you want to join
kuro
@adi10hero:matrix.org
[m]
Requested to join
Shall I merge #65 and #66?
olblak
@olblak:matrix.org
[m]
Yes you can but it won't release
we must create a tag to the correct git commit that correspond to what was published on repo.jenkins-ci.org
then we will be able to create a new release 0.4.0 with PR push after that tag 0.30
0.3.0
kuro
@adi10hero:matrix.org
[m]
Ok, got it, so it is better to wait for a 0.3.0 tag push
The meeting got over?
olblak
@olblak:matrix.org
[m]
yes meeting is over, I am taking a lunch break but we probably have to create a git tag on jenkinsci/conventional-commits-plugin@dd8604e
create a new release reusing the git tag 0.3.0 and then run release-drafter again to pick up changes published after tag 0.3.0
kuro
@adi10hero:matrix.org
[m]
Ooh okay ( I wish I saw it sooner), so git tag 0.3.0 && git push --tags and then re-run that job?
olblak
@olblak:matrix.org
[m]
we can create the tag from github interface but we need to be sure on which git commit
The problem is we have an artifact on repo.jenkins-ci.org for the version 0.3.0
so we need to identify the commit related to that artifact so next time we run the cd job it picks up the PR that were created after 0.3.0
3 replies
It's probably getting late for you now so tomorrow, we can take 15min to review this workflow together
kuro
@adi10hero:matrix.org
[m]
I will be available tomorrow anytime after 9 am UTC (before that I have a small test)
olblak
@olblak:matrix.org
[m]
Sound good to me
2 replies