Hello @philippart-s , I saw your PR, looks good to me, but it is now conflicting because of other merges, can you please update it. Also with respect to #51, what IDE configurations can we have? (would like your help in this part). Checkstyle is technically not an IDE config right, more like a project config.
that's the problem when you introduce such tool when you already have acode base
Ah yes, I will do that next (once my python PR and @philippart-s 's PR is merged)
But olblak , that formatting PR wouldn't be the reason why CD (on the main branch) is failing right?
the latest release according github is https://github.com/jenkinsci/conventional-commits-plugin/releases/tag/0.2.1
because we introduce new feature, it tries to publish a release on 0.3.0
but someone published artifacts 5 days https://repo.jenkins-ci.org/releases/io/jenkins/plugins/conventional-commits/0.3.0/
It's a setting on repo.jenkins-ci.org to disallow overriding published artifacts
and the problem is that version is now published on every mirrors https://get.jenkins.io/plugins/conventional-commits/0.3.0/conventional-commits.hpi?mirrorlist
1 reply
I need to double check but we should create a new empty github release named 0.3.0, @garethjevans any opinions?
kuro: don't worry that kind of mistake happen, I need a break and then I'll create an empty release 0.3.0 on github
If you want to learn you can open a PR or I can help :)
1 reply
the problem is here https://github.com/jenkinsci/conventional-commits-plugin/blob/main/.github/workflows/cd.yaml#L46L54
1 reply
@adi10hero:matrix.org fixes for my PR and merge from main are push. For the #51 I think that configurations like spaces instead tab, line length, end of line, ... are the minimal configurations that helm review and be compatible with almost IDE (VScode, Eclispe, Intellij and Netbeans). THe PR will be the place where we discuss what formatting parameters we want to add :wink:
I can also work on #23 or #24 if you want
I can also work on #23 or #24 if you want
@philippart-s: got it, makes sense to that :) Also please feel free to work on any issue you like ^^ I will take the other one :)
1 reply
@kuro https://meet.google.com/erp-dmcj-sut we are currently debugging it if you want to join
we must create a tag to the correct git commit that correspond to what was published on repo.jenkins-ci.org
then we will be able to create a new release 0.4.0 with PR push after that tag 0.30
0.3.0
The meeting got over?
yes meeting is over, I am taking a lunch break but we probably have to create a git tag on jenkinsci/conventional-commits-plugin@dd8604e
create a new release reusing the git tag 0.3.0 and then run release-drafter again to pick up changes published after tag 0.3.0
Ooh okay ( I wish I saw it sooner), so
git tag 0.3.0 && git push --tags and then re-run that job?
we can create the tag from github interface but we need to be sure on which git commit
The problem is we have an artifact on repo.jenkins-ci.org for the version 0.3.0
so we need to identify the commit related to that artifact so next time we run the cd job it picks up the PR that were created after 0.3.0
3 replies
It's probably getting late for you now so tomorrow, we can take 15min to review this workflow together
I will be available tomorrow anytime after 9 am UTC (before that I have a small test)
Hello kuro olblak I've put my notes of the conventionnal-commit plugin diagnosis around the failing release for info: https://gist.github.com/dduportal/4f41a48ff32e7a5c3fbcc2114378b326 . i'll update it later with how to remediate
Also @adi10hero:matrix.org did you see the note from Kara? You have to create a set of slides and a demo for the presentation. You also need to fill in the abstract here: https://docs.google.com/document/d/1rqp6NL_g4FklFAYIBEtYccHIRA2zCvZRxahJaJyZeVM/edit#heading=h.70pshge9rsvx If you create your slides, and we can review them for you before you send them to Kara!
Ah yes, @kwhetstone I am on it, yesterday I brought this point up in the office hours, I forgot to mention it here, sorry for that, I will paste the link here, I would really like to get your feedbacks on it
Link to the slides: https://docs.google.com/presentation/d/1RW206FmdsrQYctPxhiCaVmJGVV5gVK0Glq9Ikbol_a0/edit?usp=sharing
It's still at an embryonic stage, I did ask Mark for reusing the slides & assets, he was okay with it.
It's still at an embryonic stage, I did ask Mark for reusing the slides & assets, he was okay with it.
I was thinking to talk about these points:
- What are Conventional Commits
- Why Conventional Commits
- Plugin Development (max time here)
- Demo
- Q&A
Is there anything I should add/remove from this?
