Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 08 13:39
    rcjames commented #209
  • Aug 08 13:38
    rcjames commented #209
  • Aug 03 20:29
    philippart-s commented #209
  • Aug 03 11:07
    dependabot[bot] synchronize #212
  • Aug 03 11:07

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • Aug 03 11:07
    dependabot[bot] edited #212
  • Aug 03 11:07
    dependabot[bot] edited #212
  • Aug 03 11:06

    garethjevans on maven

    (compare)

  • Aug 03 11:06

    garethjevans on main

    chore(deps): bump gson from 2.9… Merge branch 'main' into depend… Merge pull request #210 from je… (compare)

  • Aug 03 11:06
    garethjevans closed #210
  • Aug 03 10:58
    garethjevans auto_merge_enabled #210
  • Aug 03 10:58
    dependabot[bot] synchronize #212
  • Aug 03 10:58

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • Aug 03 10:58
    dependabot[bot] edited #212
  • Aug 03 10:58
    dependabot[bot] edited #210
  • Aug 03 10:58
    garethjevans synchronize #210
  • Aug 03 10:58

    garethjevans on maven

    chore(deps): bump checkstyle fr… Merge pull request #211 from je… Merge branch 'main' into depend… (compare)

  • Aug 03 10:58
    dependabot[bot] edited #210
  • Aug 03 10:58
    dependabot[bot] edited #212
  • Aug 03 10:57

    garethjevans on maven

    (compare)

kuro
@adi10hero:matrix.org
[m]
But olblak , that formatting PR wouldn't be the reason why CD (on the main branch) is failing right?
olblak
@olblak:matrix.org
[m]
no cd is failing because we try to push a version that already exist
because we introduce new feature, it tries to publish a release on 0.3.0
It's a setting on repo.jenkins-ci.org to disallow overriding published artifacts
olblak
@olblak:matrix.org
[m]
and the problem is that version is now published on every mirrors https://get.jenkins.io/plugins/conventional-commits/0.3.0/conventional-commits.hpi?mirrorlist
1 reply
I need to double check but we should create a new empty github release named 0.3.0, @garethjevans any opinions?
olblak
@olblak:matrix.org
[m]
kuro: don't worry that kind of mistake happen, I need a break and then I'll create an empty release 0.3.0 on github
kuro
@adi10hero:matrix.org
[m]
Okay olblak, thank you so much, is there anything we (I) can do to avoid such mistakes in the future?
olblak
@olblak:matrix.org
[m]
Nope the cd pipeline is just broken :D
If you want to learn you can open a PR or I can help :)
1 reply
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org fixes for my PR and merge from main are push. For the #51 I think that configurations like spaces instead tab, line length, end of line, ... are the minimal configurations that helm review and be compatible with almost IDE (VScode, Eclispe, Intellij and Netbeans). THe PR will be the place where we discuss what formatting parameters we want to add :wink:
I can also work on #23 or #24 if you want
kuro
@adi10hero:matrix.org
[m]
@philippart-s: got it, makes sense to that :) Also please feel free to work on any issue you like ^^ I will take the other one :)
1 reply
olblak
@olblak:matrix.org
[m]
@kuro Apparently I am wrong, I am currently looking
@kuro https://meet.google.com/erp-dmcj-sut we are currently debugging it if you want to join
kuro
@adi10hero:matrix.org
[m]
Requested to join
Shall I merge #65 and #66?
olblak
@olblak:matrix.org
[m]
Yes you can but it won't release
we must create a tag to the correct git commit that correspond to what was published on repo.jenkins-ci.org
then we will be able to create a new release 0.4.0 with PR push after that tag 0.30
0.3.0
kuro
@adi10hero:matrix.org
[m]
Ok, got it, so it is better to wait for a 0.3.0 tag push
The meeting got over?
olblak
@olblak:matrix.org
[m]
yes meeting is over, I am taking a lunch break but we probably have to create a git tag on jenkinsci/conventional-commits-plugin@dd8604e
create a new release reusing the git tag 0.3.0 and then run release-drafter again to pick up changes published after tag 0.3.0
kuro
@adi10hero:matrix.org
[m]
Ooh okay ( I wish I saw it sooner), so git tag 0.3.0 && git push --tags and then re-run that job?
olblak
@olblak:matrix.org
[m]
we can create the tag from github interface but we need to be sure on which git commit
The problem is we have an artifact on repo.jenkins-ci.org for the version 0.3.0
so we need to identify the commit related to that artifact so next time we run the cd job it picks up the PR that were created after 0.3.0
3 replies
It's probably getting late for you now so tomorrow, we can take 15min to review this workflow together
kuro
@adi10hero:matrix.org
[m]
I will be available tomorrow anytime after 9 am UTC (before that I have a small test)
olblak
@olblak:matrix.org
[m]
Sound good to me
2 replies
dduportal
@dduportal:matrix.org
[m]
Cross posting:
Hello kuro olblak I've put my notes of the conventionnal-commit plugin diagnosis around the failing release for info: https://gist.github.com/dduportal/4f41a48ff32e7a5c3fbcc2114378b326 . i'll update it later with how to remediate
Kristin Whetstone
@kwhetstone
Thank you!
Kristin Whetstone
@kwhetstone
Also @adi10hero:matrix.org did you see the note from Kara? You have to create a set of slides and a demo for the presentation. You also need to fill in the abstract here: https://docs.google.com/document/d/1rqp6NL_g4FklFAYIBEtYccHIRA2zCvZRxahJaJyZeVM/edit#heading=h.70pshge9rsvx If you create your slides, and we can review them for you before you send them to Kara!
kuro
@adi10hero:matrix.org
[m]
Ah yes, @kwhetstone I am on it, yesterday I brought this point up in the office hours, I forgot to mention it here, sorry for that, I will paste the link here, I would really like to get your feedbacks on it
Link to the slides: https://docs.google.com/presentation/d/1RW206FmdsrQYctPxhiCaVmJGVV5gVK0Glq9Ikbol_a0/edit?usp=sharing
It's still at an embryonic stage, I did ask Mark for reusing the slides & assets, he was okay with it.
kuro
@adi10hero:matrix.org
[m]

I was thinking to talk about these points:

  1. What are Conventional Commits
  2. Why Conventional Commits
  3. Plugin Development (max time here)
  4. Demo
  5. Q&A

Is there anything I should add/remove from this?

Stéphane Philippart
@philippart-s
Hi all, simple question : is it to me to delete branch after merge or not ?
Olivier Vernin
@olblak

Hi all, simple question : is it to me to delete branch after merge or not ?

It depends on the repository policy, I don't think we enabled it here, so it's better to handle it yourself for now or ask that we automatically delete merged branches :D

2 replies
Olivier Vernin
@olblak
olblak
@olblak:matrix.org
[m]
Olivier Vernin
@olblak
As requested by @philippart-s I enabled automatically delete head branches after PR merged