Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 16 06:10

    philippart-s on main

    chore(deps): bump release-draft… (compare)

  • May 16 06:10

    philippart-s on github_actions

    (compare)

  • May 16 06:10
    philippart-s closed #193
  • May 16 02:01
    github-actions[bot] labeled #193
  • May 16 01:25
    dependabot[bot] labeled #193
  • May 16 01:25
    dependabot[bot] labeled #193
  • May 16 01:25
    dependabot[bot] opened #193
  • May 16 01:25

    dependabot[bot] on github_actions

    chore(deps): bump release-draft… (compare)

  • May 12 18:28

    philippart-s on github_actions

    (compare)

  • May 12 18:28

    philippart-s on main

    chore(deps): bump actions/setup… (compare)

  • May 12 18:28
    philippart-s closed #192
  • May 09 02:11
    github-actions[bot] labeled #192
  • May 09 02:03
    dependabot[bot] labeled #192
  • May 09 02:03
    dependabot[bot] labeled #192
  • May 09 02:03
    dependabot[bot] opened #192
  • May 09 02:03

    dependabot[bot] on github_actions

    chore(deps): bump actions/setup… (compare)

  • May 02 06:07
    philippart-s synchronize #164
  • May 02 06:07

    philippart-s on maven

    chore(deps): bump actions/setup… chore(deps): bump checkstyle fr… chore(deps-dev): bump mockito-c… and 2 more (compare)

  • May 02 06:03

    philippart-s on github_actions

    (compare)

  • May 02 06:03

    philippart-s on main

    chore(deps): bump actions/setup… (compare)

Olivier Vernin
@olblak
As requested by @philippart-s I enabled automatically delete head branches after PR merged
I made some suggestion to your slide
kuro
@adi10hero:matrix.org
[m]
Thank you so much for it, I will expand on your suggestions, I just wanted to clarify that, the content of the slide are to be removed (my bad that it got copied along with the template)
kuro
@adi10hero:matrix.org
[m]
@garethjevans: would you be available for a meeting tomorrow (7:00 am UTC) as usual
Gareth Evans
@garethjevans
@adi10hero:matrix.org yep, will be there usual time, was just turning on the laptop to message you the same thing!
kuro
@adi10hero:matrix.org
[m]
Hahah I was first to message this time :P
Kristin Whetstone
@kwhetstone
Great! :thumbsup:
Gareth Evans
@garethjevans
@adi10hero:matrix.org ^^^
Stéphane Philippart
@philippart-s
Hi all, if it's ok for you I'd like to work on the @garethjevans proposition in the #23 to add prerelease information. If your are agree can you assign to me the issue please ?
kuro
@adi10hero:matrix.org
[m]
Done @philippart-s
Stéphane Philippart
@philippart-s
thks
kuro
@adi10hero:matrix.org
[m]
@garethjevans, I have some difficulties while running the plugin, can we please have a discussion tomorrow. Also, can we have the meeting a little later than the usual time? I need to go collect my laptop in the morning, so I am unsure when I will be back or how much time it will take, I am expecting to be back by 8-9 am UTC
Gareth Evans
@garethjevans
@adi10hero:matrix.org no problem, i've got a few meetings that start in 10 mins, but will be able to have some time after that
did you get anywhere with setting up some test github projects?
1 reply
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org good luck for your presentation (if I well understand it's tomorrow) ! 🤞💪
1 reply
kuro
@adi10hero:matrix.org
[m]
PS: The reason I did not go with Make, Node or Gradle was, I primarily use Windows so I am not really comfortable with Make & as far as Node and Gradle go, they take a lot of time to build :P
2 replies
kuro
@adi10hero:matrix.org
[m]
Good news, CD is working 🎉
Thank you @all :D
kuro
@adi10hero:matrix.org
[m]
@garethjevans: Using this repo (https://github.com/ADI10HERO/maven-sample-cc) for demo
Making a python project now
1 reply
Gareth Evans
@garethjevans
@adi10hero:matrix.org I can be online for the next 30mins if you want a catch up?
1 reply
Gareth Evans
@garethjevans
i only have 5 mins, maybe less
Gareth Evans
@garethjevans
@adi10hero:matrix.org great presentation and demo. demoing live is always nervous especially when a process takes slightly longer than you expect. Tara's suggestion was really interesting, I'm not sure how we'd do that but it could be something to look into in the future
1 reply
Stéphane Philippart
@philippart-s
yes @adi10hero:matrix.org good work 💪👏
1 reply
olblak
@olblak:matrix.org
[m]
@ADI10HERO: I agree with @garethjevans you presentation was really great and you successfully managed the live demo part, congrats
1 reply
Stéphane Philippart
@philippart-s
Hi all, can you tell me what is the purpose of the fields outputFormat and startTag in the NextVersionStep please ?
4 replies
kuro
@adi10hero:matrix.org
[m]
@garethjevans: Can we have a meeting at the usual time tomorrow?
I was working on the blog post, plan was to make a draft a little earlier than the deadline (31st july)
kuro
@adi10hero:matrix.org
[m]
@philippart-s: I was reviewing the pre-release PR and just wanted to check my understanding...
If there's a minor version bump on previously tagged: 0.1.0-alpha, then it would become 0.2.0-alpha, right?
9 replies
Gareth Evans
@garethjevans
@adi10hero:matrix.org yep, ill be around tomorrow at the usual time
Gareth Evans
@garethjevans
@adi10hero:matrix.org - https://us02web.zoom.us/j/83148383460
Things I plan to add:
  1. link to the presentation video
  2. discourse link update
  3. Try to think of a good "start" of the blog (after the opengraph image) which establishes a few things like its a gsoc project, mentions the mentors, maybe a summary of the whole blog.
PS: docker is not working on both windows and linux boot so couldn't really test using the site generator. So please let me know in case something doesn't look right.
Stéphane Philippart
@philippart-s
I've just create this bug #76 , perhaps it's me that don't understand well how the plugin must be works :wink:
Stéphane Philippart
@philippart-s

@garethjevans & @adi10hero:matrix.org

Before go further I think we'll need to discuss on the strategy to bump version with prerelease information already existing or not.

Here is the use cases and what I have understand with our conversations and what I propose for other cases :

current version Breaking change commit msg Feature commit msg Other or empty commit msg prerelease option preservePreRelease Output
0.1.0 X - - - - 1.0.0
0.1.0 - X - - - 0.2.0
0.1.0 - - X - - 0.1.1
0.1.0 X - - alpha - 1.0.0-alpha
0.1.0 - X - alpha - 0.2.0-alpha
0.1.0 - - X alpha - 0.1.1-alpha
0.1.0-alpha X - - - - 1.0.0
0.1.0-alpha - X - - - 0.1.0
0.1.0-alpha - - X - - 0.1.1
0.1.0-alpha X - - - X 1.0.0-alpha
0.1.0-alpha - X - - X 0.2.0-alpha
0.1.0-alpha - - X - X 0.1.1-alpha
0.1.0-alpha X - - beta - 1.0.0-beta
0.1.0-alpha - X - beta - 0.2.0-beta
0.1.0-alpha - - X beta - 0.1.1-beta

There is also the possibility to increment the prelease version : 0.1.0-alpha :arrow_right: 0.1.0-alpha.1.
It can be an alternative for the case where there is no commit message and the version is with a prerelease version (line 12 of the table).

12 replies
kuro
@adi10hero:matrix.org
[m]
@mentors, PR for buildmetadata made (jenkinsci/conventional-commits-plugin#78), ready to be reviewed
kuro
@adi10hero:matrix.org
[m]
@philippart-s: I am unable to add your name under "Request Reviews"
3 replies
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org for the blog, you can open a PR against jenkins.io and we can make comments there!
kuro
@adi10hero:matrix.org
[m]
Ohh actually unfortunately I wasn't able to get my docker working so could not test the changeslocally 😅
kuro
@adi10hero:matrix.org
[m]
@all, Shall we start a discourse discussion which introduces conventional commits plugin? If yes, what shall the body of the post contain?
1 reply
kuro
@adi10hero:matrix.org
[m]
@garethjevans: Is there a convention for "chore bumping"? My google searches say: chore — for updates that do not require a version bump (.gitignore, comments, etc.)
So just wanted to confirm whether there exists a convention where chore messages bump version.. (reference: Comment on the blog PR
Stéphane Philippart
@philippart-s

I've a little question about the transient fields for the parameters of the step (https://github.com/jenkinsci/conventional-commits-plugin/blob/7e5e791119287e6e72587836b6205bcf67da650b/src/main/java/io/jenkins/plugins/conventionalcommits/NextVersionStep.java#L111) : why do we put these fields transient ?

And bonus question, after merging code from 0.5.0 I saw that the buildMetadata field is not declared as transient (https://github.com/jenkinsci/conventional-commits-plugin/blob/7e5e791119287e6e72587836b6205bcf67da650b/src/main/java/io/jenkins/plugins/conventionalcommits/NextVersionStep.java#L121)? Is there any reason or is it an oversight ?

Thanks :wink:

4 replies
Mark Waite
@MarkEWaite
@adi10hero:matrix.org I believe that the blog post jenkins-infra/jenkins.io#4475 is ready to merge. You had set its merge date for today. Would you like it merged today or would you like to update the publish date for tomorrow and we'll publish it tomorrow?
kuro
@adi10hero:matrix.org
[m]
Hello @MarkEWaite , I just saw kwhetstone (Kristin Whetstone)'s comment I would like to push 1 more commit with those changes
That would be done today (in the next hour probably).. Do you still suggest that we update the publish date?
kuro
@adi10hero:matrix.org
[m]
:point_up: Edit: Hello @MarkEWaite I've updated the publish date to make it 30-07-2021. I hope it gets merged today...