Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 06 01:45
    github-actions[bot] labeled #151
  • Dec 06 01:15
    dependabot[bot] labeled #151
  • Dec 06 01:15
    dependabot[bot] labeled #151
  • Dec 06 01:15
    dependabot[bot] opened #151
  • Dec 06 01:15

    dependabot[bot] on maven

    chore(deps-dev): bump pipeline-… (compare)

  • Nov 29 02:08
    github-actions[bot] labeled #150
  • Nov 29 01:21
    dependabot[bot] labeled #150
  • Nov 29 01:21
    dependabot[bot] labeled #150
  • Nov 29 01:21
    dependabot[bot] opened #150
  • Nov 29 01:21

    dependabot[bot] on maven

    chore(deps): bump checkstyle fr… (compare)

  • Nov 22 13:38
    slim-patchy commented #118
  • Nov 22 12:56
    philippart-s assigned #118
  • Nov 22 12:56
    philippart-s commented #118
  • Nov 22 01:15
    github-actions[bot] labeled #149
  • Nov 22 01:14
    dependabot[bot] labeled #149
  • Nov 22 01:14
    dependabot[bot] labeled #149
  • Nov 22 01:14
    dependabot[bot] opened #149
  • Nov 22 01:14

    dependabot[bot] on maven

    chore(deps-dev): bump mockito-c… (compare)

olblak
@olblak:matrix.org
[m]
@ADI10HERO: I agree with @garethjevans you presentation was really great and you successfully managed the live demo part, congrats
1 reply
Stéphane Philippart
@philippart-s
Hi all, can you tell me what is the purpose of the fields outputFormat and startTag in the NextVersionStep please ?
4 replies
kuro
@adi10hero:matrix.org
[m]
@garethjevans: Can we have a meeting at the usual time tomorrow?
I was working on the blog post, plan was to make a draft a little earlier than the deadline (31st july)
kuro
@adi10hero:matrix.org
[m]
@philippart-s: I was reviewing the pre-release PR and just wanted to check my understanding...
If there's a minor version bump on previously tagged: 0.1.0-alpha, then it would become 0.2.0-alpha, right?
9 replies
Gareth Evans
@garethjevans
@adi10hero:matrix.org yep, ill be around tomorrow at the usual time
Gareth Evans
@garethjevans
@adi10hero:matrix.org - https://us02web.zoom.us/j/83148383460
Things I plan to add:
  1. link to the presentation video
  2. discourse link update
  3. Try to think of a good "start" of the blog (after the opengraph image) which establishes a few things like its a gsoc project, mentions the mentors, maybe a summary of the whole blog.
PS: docker is not working on both windows and linux boot so couldn't really test using the site generator. So please let me know in case something doesn't look right.
Stéphane Philippart
@philippart-s
I've just create this bug #76 , perhaps it's me that don't understand well how the plugin must be works :wink:
Stéphane Philippart
@philippart-s

@garethjevans & @adi10hero:matrix.org

Before go further I think we'll need to discuss on the strategy to bump version with prerelease information already existing or not.

Here is the use cases and what I have understand with our conversations and what I propose for other cases :

current version Breaking change commit msg Feature commit msg Other or empty commit msg prerelease option preservePreRelease Output
0.1.0 X - - - - 1.0.0
0.1.0 - X - - - 0.2.0
0.1.0 - - X - - 0.1.1
0.1.0 X - - alpha - 1.0.0-alpha
0.1.0 - X - alpha - 0.2.0-alpha
0.1.0 - - X alpha - 0.1.1-alpha
0.1.0-alpha X - - - - 1.0.0
0.1.0-alpha - X - - - 0.1.0
0.1.0-alpha - - X - - 0.1.1
0.1.0-alpha X - - - X 1.0.0-alpha
0.1.0-alpha - X - - X 0.2.0-alpha
0.1.0-alpha - - X - X 0.1.1-alpha
0.1.0-alpha X - - beta - 1.0.0-beta
0.1.0-alpha - X - beta - 0.2.0-beta
0.1.0-alpha - - X beta - 0.1.1-beta

There is also the possibility to increment the prelease version : 0.1.0-alpha :arrow_right: 0.1.0-alpha.1.
It can be an alternative for the case where there is no commit message and the version is with a prerelease version (line 12 of the table).

12 replies
kuro
@adi10hero:matrix.org
[m]
@mentors, PR for buildmetadata made (jenkinsci/conventional-commits-plugin#78), ready to be reviewed
kuro
@adi10hero:matrix.org
[m]
@philippart-s: I am unable to add your name under "Request Reviews"
3 replies
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org for the blog, you can open a PR against jenkins.io and we can make comments there!
kuro
@adi10hero:matrix.org
[m]
Ohh actually unfortunately I wasn't able to get my docker working so could not test the changeslocally 😅
kuro
@adi10hero:matrix.org
[m]
@all, Shall we start a discourse discussion which introduces conventional commits plugin? If yes, what shall the body of the post contain?
1 reply
kuro
@adi10hero:matrix.org
[m]
@garethjevans: Is there a convention for "chore bumping"? My google searches say: chore — for updates that do not require a version bump (.gitignore, comments, etc.)
So just wanted to confirm whether there exists a convention where chore messages bump version.. (reference: Comment on the blog PR
Stéphane Philippart
@philippart-s

I've a little question about the transient fields for the parameters of the step (https://github.com/jenkinsci/conventional-commits-plugin/blob/7e5e791119287e6e72587836b6205bcf67da650b/src/main/java/io/jenkins/plugins/conventionalcommits/NextVersionStep.java#L111) : why do we put these fields transient ?

And bonus question, after merging code from 0.5.0 I saw that the buildMetadata field is not declared as transient (https://github.com/jenkinsci/conventional-commits-plugin/blob/7e5e791119287e6e72587836b6205bcf67da650b/src/main/java/io/jenkins/plugins/conventionalcommits/NextVersionStep.java#L121)? Is there any reason or is it an oversight ?

Thanks :wink:

4 replies
Mark Waite
@MarkEWaite
@adi10hero:matrix.org I believe that the blog post jenkins-infra/jenkins.io#4475 is ready to merge. You had set its merge date for today. Would you like it merged today or would you like to update the publish date for tomorrow and we'll publish it tomorrow?
kuro
@adi10hero:matrix.org
[m]
Hello @MarkEWaite , I just saw kwhetstone (Kristin Whetstone)'s comment I would like to push 1 more commit with those changes
That would be done today (in the next hour probably).. Do you still suggest that we update the publish date?
kuro
@adi10hero:matrix.org
[m]
:point_up: Edit: Hello @MarkEWaite I've updated the publish date to make it 30-07-2021. I hope it gets merged today...
Mark Waite
@MarkEWaite
Thanks @adi10hero:matrix.org . We will publish the blog today, tweet the blog link, and post an article about it on LinkedIn. Timing is good since tweets about technical topics seem to have better results during the North America morning hours.
1 reply
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org the blog looks great!
1 reply
@philippart-s I love the extra documentation provided in your recent PR. Having the table makes it so much easier to explain what happens with each change
1 reply
Mark Waite
@MarkEWaite
The blog post at jenkins-infra/jenkins.io#4475 has been merged. It will be visible on https://www.jenkins.io/blog/ in about 15 minutes. Once it is visible, I'll propose the tweet announcement in the Advocacy and Outreach gitter channel
1 reply
kuro
@adi10hero:matrix.org
[m]

@all, After pre-release is merged according to my proposal I had planned to do the following:

  1. some "integration" i.e. using it in a CI/CD pipeline (That time I did not know how easy it is to use a plugin in a Jenkins Pipeline), so can I assume this is done?
  2. And then using the plugin in JEP-229 (I am still not sure what I mean by this, need help)
  3. And finally some time for bug fixes

Apart from this there were some Stretch Goals:

  1. writing the next version back in the configuration files
  2. Using the plugin in a GitHub Actions workflow as well
  3. REST API (if it makes sense)
9 replies
What would be a good next step?
Kristin Whetstone
@kwhetstone
Just in case it didn't make it here: @garethjevans and @olblak:matrix.org do you think that to have the plugin integrate with JEP-229, it would need to be able to write the version back to the pom.xml file?
3 replies
kuro
@adi10hero:matrix.org
[m]
I have created a jenkinsci/conventional-commits-plugin#85 for the WriteVersion base class and writeVersion method in MavenProjectType...
kuro
@adi10hero:matrix.org
[m]

I am not sure how will I write unittest for "write" functionality...

As the feature is to write to a file, would it make sense to read the written file?

If it does then, for project types like Maven where we use mvn help:evaluate -Dexpression=project.version command to read the version, a parser for pom.xml would be needed just for the test...

Stéphane Philippart
@philippart-s
Finally I ending the coding of the PR #75 (issue #23). Lot of combinations, I hope I haven't forgot some 🤞
1 reply
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org , after your PR #85 will be merged do you want I do the same feature for NPM ?
2 replies
Gareth Evans
@garethjevans
@adi10hero:matrix.org are you around tomorrow? usual time?
2 replies
Gareth Evans
@garethjevans
kuro
@adi10hero:matrix.org
[m]
@philippart-s: Reviewed your PR, just 1 minor change from my side which helped passing tests (locally).
2 replies
Apart from that, the only problem I saw was when I put incrementPreRelease information and the version did not have preRelease info.
Yes I understand that this doesn't make a lot of sense to do but what I am trying to say is that we need to add some checks or error handling/logging in the near future
3 replies
kuro
@adi10hero:matrix.org
[m]
Shall I go ahead and merge Stéphane Philippart 's jenkinsci/conventional-commits-plugin#75?
Asking as review is requested + it's a big feature so in case we missed something :)
kuro
@adi10hero:matrix.org
[m]
Thank you @garethjevans for reviewing.. Feels a lot more confident now :)
Stéphane Philippart
@wildagsx:matrix.org
[m]
Thks 😉
kuro
@adi10hero:matrix.org
[m]
Stéphane Philippart: I wanted some help wrt your comment
How do I check with what params was the processHelper called?
6 replies
kuro
@adi10hero:matrix.org
[m]
I am facing issues when I am writing the following tests:
  1. Unsupported project type with writeVersion called: In this case there's only a single log message written to the console.. how do I test that?
  2. Writing a jenkins tests with a sample maven project with the writeVersion parameter as "true" times out :( Any solution around that?
    (I am stuck for hours now 😅)
5 replies
Stéphane Philippart
@wildagsx:matrix.org
[m]

Writing a jenkins tests with a sample maven project with the writeVersion parameter as "true" times out :( Any solution around that?
(I am stuck for hours now 😅)

It's in the JenkinsTest class or in a Jenkins Job ?

10 replies
Martin d'Anjou
@martinda
@adi10hero:matrix.org I just want to say that I just joined the admin team to assist in the next few weeks with blog and work product reviews. Maybe I will do technical reviews if I find myself to be qualified enough :-).
1 reply
kuro
@adi10hero:matrix.org
[m]
@kwhetstone: Can you please give some direction on how to proceed with this..
2 replies
kuro
@adi10hero:matrix.org
[m]
Surprisingly @MarkEWaite if you see this same code, the directory is correct!
kuro
@adi10hero:matrix.org
[m]
@garethjevans: I will be available at the usual time for our weekly meeting
Gareth Evans
@garethjevans