Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:12
    github-actions[bot] labeled #136
  • 02:12
    github-actions[bot] labeled #137
  • 01:20
    dependabot[bot] labeled #137
  • 01:20
    dependabot[bot] labeled #137
  • 01:20
    dependabot[bot] opened #137
  • 01:20

    dependabot[bot] on maven

    chore(deps): bump plugin from 4… (compare)

  • 01:19
    dependabot[bot] labeled #136
  • 01:19
    dependabot[bot] labeled #136
  • 01:19
    dependabot[bot] opened #136
  • 01:19

    dependabot[bot] on github_actions

    chore(deps): bump actions/check… (compare)

  • Oct 17 14:15
    philippart-s ready_for_review #135
  • Oct 17 14:09
    philippart-s opened #135
  • Oct 17 11:10
    sshiv5768 commented #118
  • Oct 17 10:54
    philippart-s commented #117
  • Oct 17 10:54
    philippart-s commented #118
  • Oct 17 10:53
    philippart-s commented #122
  • Oct 17 09:21
    philippart-s synchronize #122
  • Oct 15 15:19
  • Oct 15 07:39
    philippart-s synchronize #122
  • Oct 15 07:39
    philippart-s synchronize #122
kuro
@adi10hero:matrix.org
[m]
Hello @MarkEWaite , I just saw kwhetstone (Kristin Whetstone)'s comment I would like to push 1 more commit with those changes
That would be done today (in the next hour probably).. Do you still suggest that we update the publish date?
kuro
@adi10hero:matrix.org
[m]
:point_up: Edit: Hello @MarkEWaite I've updated the publish date to make it 30-07-2021. I hope it gets merged today...
Mark Waite
@MarkEWaite
Thanks @adi10hero:matrix.org . We will publish the blog today, tweet the blog link, and post an article about it on LinkedIn. Timing is good since tweets about technical topics seem to have better results during the North America morning hours.
1 reply
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org the blog looks great!
1 reply
@philippart-s I love the extra documentation provided in your recent PR. Having the table makes it so much easier to explain what happens with each change
1 reply
Mark Waite
@MarkEWaite
The blog post at jenkins-infra/jenkins.io#4475 has been merged. It will be visible on https://www.jenkins.io/blog/ in about 15 minutes. Once it is visible, I'll propose the tweet announcement in the Advocacy and Outreach gitter channel
1 reply
kuro
@adi10hero:matrix.org
[m]

@all, After pre-release is merged according to my proposal I had planned to do the following:

  1. some "integration" i.e. using it in a CI/CD pipeline (That time I did not know how easy it is to use a plugin in a Jenkins Pipeline), so can I assume this is done?
  2. And then using the plugin in JEP-229 (I am still not sure what I mean by this, need help)
  3. And finally some time for bug fixes

Apart from this there were some Stretch Goals:

  1. writing the next version back in the configuration files
  2. Using the plugin in a GitHub Actions workflow as well
  3. REST API (if it makes sense)
9 replies
What would be a good next step?
Kristin Whetstone
@kwhetstone
Just in case it didn't make it here: @garethjevans and @olblak:matrix.org do you think that to have the plugin integrate with JEP-229, it would need to be able to write the version back to the pom.xml file?
3 replies
kuro
@adi10hero:matrix.org
[m]
I have created a jenkinsci/conventional-commits-plugin#85 for the WriteVersion base class and writeVersion method in MavenProjectType...
kuro
@adi10hero:matrix.org
[m]

I am not sure how will I write unittest for "write" functionality...

As the feature is to write to a file, would it make sense to read the written file?

If it does then, for project types like Maven where we use mvn help:evaluate -Dexpression=project.version command to read the version, a parser for pom.xml would be needed just for the test...

Stéphane Philippart
@philippart-s
Finally I ending the coding of the PR #75 (issue #23). Lot of combinations, I hope I haven't forgot some 🤞
1 reply
Stéphane Philippart
@philippart-s
@adi10hero:matrix.org , after your PR #85 will be merged do you want I do the same feature for NPM ?
2 replies
Gareth Evans
@garethjevans
@adi10hero:matrix.org are you around tomorrow? usual time?
2 replies
Gareth Evans
@garethjevans
kuro
@adi10hero:matrix.org
[m]
@philippart-s: Reviewed your PR, just 1 minor change from my side which helped passing tests (locally).
2 replies
Apart from that, the only problem I saw was when I put incrementPreRelease information and the version did not have preRelease info.
Yes I understand that this doesn't make a lot of sense to do but what I am trying to say is that we need to add some checks or error handling/logging in the near future
3 replies
kuro
@adi10hero:matrix.org
[m]
Shall I go ahead and merge Stéphane Philippart 's jenkinsci/conventional-commits-plugin#75?
Asking as review is requested + it's a big feature so in case we missed something :)
kuro
@adi10hero:matrix.org
[m]
Thank you @garethjevans for reviewing.. Feels a lot more confident now :)
Stéphane Philippart
@wildagsx:matrix.org
[m]
Thks 😉
kuro
@adi10hero:matrix.org
[m]
Stéphane Philippart: I wanted some help wrt your comment
How do I check with what params was the processHelper called?
6 replies
kuro
@adi10hero:matrix.org
[m]
I am facing issues when I am writing the following tests:
  1. Unsupported project type with writeVersion called: In this case there's only a single log message written to the console.. how do I test that?
  2. Writing a jenkins tests with a sample maven project with the writeVersion parameter as "true" times out :( Any solution around that?
    (I am stuck for hours now 😅)
5 replies
Stéphane Philippart
@wildagsx:matrix.org
[m]

Writing a jenkins tests with a sample maven project with the writeVersion parameter as "true" times out :( Any solution around that?
(I am stuck for hours now 😅)

It's in the JenkinsTest class or in a Jenkins Job ?

10 replies
Martin d'Anjou
@martinda
@adi10hero:matrix.org I just want to say that I just joined the admin team to assist in the next few weeks with blog and work product reviews. Maybe I will do technical reviews if I find myself to be qualified enough :-).
1 reply
kuro
@adi10hero:matrix.org
[m]
@kwhetstone: Can you please give some direction on how to proceed with this..
2 replies
kuro
@adi10hero:matrix.org
[m]
Surprisingly @MarkEWaite if you see this same code, the directory is correct!
kuro
@adi10hero:matrix.org
[m]
@garethjevans: I will be available at the usual time for our weekly meeting
Gareth Evans
@garethjevans
kuro
@adi10hero:matrix.org
[m]
@garethjevans: jenkinsci/conventional-commits-plugin#76 slipped my mind in today's meeting
Martin d'Anjou
@martinda
Hi everyone esp. @adi10hero:matrix.org , please make sure you participate in the poll on slack regarding the final demo. Thanks in advance!
kuro
@adi10hero:matrix.org
[m]
Thank you for the reminder @martinda :)
Stéphane Philippart
@wildagsx:matrix.org
[m]
Hi, I've just finished the PR #91 and I have some questions :
  • why do we set version 8 for the JDK and not 11 ?
  • when I run mvn hpi-run and create a pipeline job to test the plugin I've the following error : Cannot run program "git" (in directory "/home/stephane/Developpements/oss/conventional-commits-plugin/work/workspace/test. Obviously git is installed on my device, do I run the test plugin in a real Jenkins instance ?
  • for integration tests we can't test a real call to the external program (like npm, helm, ...) I choose to use mock to reproduce the real comportment, is it ok for you ? Is there another way to do an integration test with real command (docker, install the CLI on the CI environment, in the tests, ...) ?
2 replies
kuro
@adi10hero:matrix.org
[m]
In this week, I was planning to complete tasks like updating the GSoC project page, submit final evaluation, update presentation slides, etc
Will it be fine if I do code related tasks after I am done with these?
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org yep!
Getting the blog post in early makes it much easier to do reviews and scheduling\
kuro
@adi10hero:matrix.org
[m]
Ah yes, 2nd blog needs to be written as well.. Thank you for reminding @kwhetstone :)
kuro
@adi10hero:matrix.org
[m]
@mentors, What would be a good work submission for the final evaluation? (Guidelines: https://developers.google.com/open-source/gsoc/help/work-product). Reading the 3rd point, will the GitHub repo of the plugin be sufficient?
Kristin Whetstone
@kwhetstone
@adi10hero:matrix.org yes because all the work you've been doing is there
Kristin Whetstone
@kwhetstone
Did that help?
1 reply
https://doodle.com/poll/edepxx6g9w4izzir?utm_source=poll&utm_medium=link -> here's the doodle poll for picking a time for the presentation
1 reply
kuro
@adi10hero:matrix.org
[m]
I have submitted the work (GitHub repository) and the student evaluation.
kuro
@adi10hero:matrix.org
[m]

I am not sure what I should add in GSoC final presentation PPT..
I changed the next steps part (easy) and new features could be demoed..
Can we add anything else in the PPT?

Link to the ppt

olblak
@olblak:matrix.org
[m]
kuro: I think it would be nice to highlight that it could easily be extended to other packaging maybe with a quick description about how to add additional package
kuro
@adi10hero:matrix.org
[m]
olblak: By additional package do you mean project types? (maven, etc..)
olblak
@olblak:matrix.org
[m]
kuro: exactly, the idea is to encourage the person who's interested by the plugin but doesn't find a specific package
kuro
@adi10hero:matrix.org
[m]
Got it! I will add that. Would it be okay to write steps to add a package/project type... Eg.
  1. Add the type in the factory class
  2. Create a public class...
olblak
@olblak:matrix.org
[m]
Yes I think big picture steps are enough, just to help potential contributor where to look at
1 reply
too much documentation is not always a good idea as it has to be maintained, and outdate documentation is really bad
Gareth Evans
@garethjevans
@adi10hero:matrix.org are you around tomorrow for a catch up? I forgot, am on holiday on friday
4 replies
Gareth Evans
@garethjevans