Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 02:08
    github-actions[bot] labeled #150
  • 01:21
    dependabot[bot] labeled #150
  • 01:21
    dependabot[bot] labeled #150
  • 01:21
    dependabot[bot] opened #150
  • 01:21

    dependabot[bot] on maven

    chore(deps): bump checkstyle fr… (compare)

  • Nov 22 13:38
    slim-patchy commented #118
  • Nov 22 12:56
    philippart-s assigned #118
  • Nov 22 12:56
    philippart-s commented #118
  • Nov 22 01:15
    github-actions[bot] labeled #149
  • Nov 22 01:14
    dependabot[bot] labeled #149
  • Nov 22 01:14
    dependabot[bot] labeled #149
  • Nov 22 01:14
    dependabot[bot] opened #149
  • Nov 22 01:14

    dependabot[bot] on maven

    chore(deps-dev): bump mockito-c… (compare)

  • Nov 21 13:47
    slim-patchy commented #118
  • Nov 15 09:36
  • Nov 15 08:49
    garethjevans closed #148
  • Nov 15 08:49

    garethjevans on github_actions

    (compare)

  • Nov 15 08:49

    garethjevans on main

    chore(deps): bump jenkins-x-plu… Merge branch 'main' into depend… Merge pull request #148 from je… (compare)

  • Nov 15 08:40
    garethjevans auto_merge_enabled #148
olblak
@olblak:matrix.org
[m]
kuro: exactly, the idea is to encourage the person who's interested by the plugin but doesn't find a specific package
kuro
@adi10hero:matrix.org
[m]
Got it! I will add that. Would it be okay to write steps to add a package/project type... Eg.
  1. Add the type in the factory class
  2. Create a public class...
olblak
@olblak:matrix.org
[m]
Yes I think big picture steps are enough, just to help potential contributor where to look at
1 reply
too much documentation is not always a good idea as it has to be maintained, and outdate documentation is really bad
Gareth Evans
@garethjevans
@adi10hero:matrix.org are you around tomorrow for a catch up? I forgot, am on holiday on friday
4 replies
Gareth Evans
@garethjevans
kuro
@adi10hero:matrix.org
[m]
Woops.. The CD failed :(
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project conventional-commits: Failed to deploy artifacts: Could not transfer artifact io.jenkins.plugins:conventional-commits:hpi:0.7.3 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): authentication failed for https://repo.jenkins-ci.org/releases/io/jenkins/plugins/conventional-commits/0.7.3/conventional-commits-0.7.3.hpi, status: 401 Unauthorized -> [Help 1]
Mark Waite
@MarkEWaite
Is this the first run of the CD process? I thought that you'd using the automated CD process before.
kuro
@adi10hero:matrix.org
[m]
Hello @MarkEWaite, No, It isn't the first run and yeah we are using automated CD, which is exactly why I was surprised at it failing 😅
Stéphane Philippart
@wildagsx:matrix.org
[m]
Hi all, just starting the issue #81 and I have a question : I'm less familiar with gradle than maven, for me there is non command line to write back to the build.gradle sot I write the next version with Java code . Is it ok for you or did I miss a magic gradle option ? 😉
3 replies
kuro
@adi10hero:matrix.org
[m]
I haven't been around a lot and I am sorry for that. I wanted to let y'all know -- I just graduated (didn't even get a farewell thanks to covid :/ ). A lot of my time was invested in looking for a job and simultaneously apply for Masters (next fall). I would really like to take some time for masters applications. So, the frequency of contribution would be low for some time. 😅
3 replies
olblak
@olblak:matrix.org
[m]
@kuro congratulation for :)
Stéphane Philippart
@wildagsx:matrix.org
[m]
Hi all, what do you think for the #76 issue ? Do we just add in the documentation that only annotated tags are supported or do we add an option to activate the support of non annotated tag (false by default) ?
1 reply
Stéphane Philippart
@wildagsx:matrix.org
[m]
Hi (again :wink:), do you think that we'll must update maintenaires members (I don't know if I have the level but I can help for this role if you want). And another question : do you think this plugin can be proposed to hacktoberfest or we don't have enough issues ?
2 replies
Stéphane Philippart
@wildagsx:matrix.org
[m]
Thanks for yours answers, I'll try the process to join the maintainers list ! For hacktoberfest I think that will be a good "boost" for the project, I'll try this week-end to create issues and read how to propose this project to hacktoberfest 😉
Stéphane Philippart
@wildagsx:matrix.org
[m]
Before i request the access I see there is another maintainers (I didn't know there is already 5 maintainers), is it ok for you @garethjevans , olblak , @kwhetstone and @Dohbedoh that I do this kind of demand. The goal was to help the plugin to live as kuro has less time but perhaps you are enough as maintainers ?
Stéphane Philippart
@wildagsx:matrix.org
[m]
as I've no response I'll try to propose my PR to became maintainer of the plugin 😉
olblak
@olblak:matrix.org
[m]
Stéphane Philippart: I support you as maintainer, we are maintainers because we were Gsoc maintainer helping kuro
Stéphane Philippart
@wildagsx:matrix.org
[m]
Stéphane Philippart
@wildagsx:matrix.org
[m]
Hi (again 😉), in addition of the IT and UT in the project I want to test in a real Jenkins instance the plugin. I have a local instance on my laptop but I'm wonder if it exist a centralize instance where we can do such tests ?
olblak
@olblak:matrix.org
[m]
Hi Stephane, I don't think we provide that, maybe @MarkEWaite knows more about that
1 reply
Stéphane Philippart
@wildagsx:matrix.org
[m]
ok thanks ! I continue to use my own instance 😉
Stéphane Philippart
@wildagsx:matrix.org
[m]
another question (sorry for my noob questions) : the 0.7.3 release has several features or bugs, the last release 0.7.4 that has only the last PR that I merge. how regroup several PR in a release ?
I've checked the github action and I saw that if the draft release has feat / bug entries the release is automatically fired. If I understand well this release (0.7.3) has several entries because the previous build phase exit with error status ?
Apparently it's the same explanation for the 0.4.0 : the release stage is on error until that it was success and get the previous merged PR.
olblak
@olblak:matrix.org
[m]
Once releases are published, you can go back :) (at least not a good practice) considering that releases are automated, you can't regroup PR for a specific release
Better to have a PR that solve a specific problem which can be merged as soon as possible
Stéphane Philippart
@wildagsx:matrix.org
[m]
agree with you, it's just to avoid multiple releases and group features when there no urgency 😉, but it's cool I prefer automation vs manual !
olblak
@olblak:matrix.org
[m]
Yep unfortunately we can't have everything :D most of the time, I also prefer automation :D
Mark Waite
@MarkEWaite
@wildagsx:matrix.org and @adi10hero:matrix.org are you interested in including the conventional commits plugin in the Jenkins Hacktoberfest efforts? Are there items that would be well suited to a first time contributor helping with a relatively simple task?
kuro
@adi10hero:matrix.org
[m]
Yes, I think we are interested, regarding items being well suited, I am not sure for first time contributors...
I propose this:
  • Add more project types (Go, Scala, etc)
  • WriteVersion for remaining project types (Python, Make, etc)
  • Unit tests wherever needed
Stéphane Philippart
@wildagsx:matrix.org
[m]
yes I think it's a good idea, if I've time I'll create issues (like those mentioned by kuro ) this WE. Is there another tasks to do to enroll the plugin in Hacktoberfest ?
Mark Waite
@MarkEWaite
Would you and others be willing to review pull requests from new contributors? If so, then add the "Hacktoberfest" topic to the GitHub repository for the plugin.
1 reply
screencapture-github-jenkinsci-git-client-plugin-2021-09-24-08_17_16-edit.png
Stéphane Philippart
@wildagsx:matrix.org
[m]
I'll just to take time to create issues this week-end 😉
Stéphane Philippart
@wildagsx:matrix.org
[m]
hi all, just added some few issues (with label good first issue to help to for newcommers) and added the hacktoberfest label 😉. Is there another thing to do for hacktoberfest compliant ?
Stéphane Philippart
@wildagsx:matrix.org
[m]
I added Hacktoberfest label to issues as the documentation explain it : https://hacktoberfest.digitalocean.com/resources/maintainers
Mark Waite
@MarkEWaite
I think that's the right approach @wildagsx:matrix.org
Stéphane Philippart
@wildagsx:matrix.org
[m]
Hi, is there any rules for the topics on the github repository ? When I look other plugins it's seems quite open 😉
olblak
@olblak:matrix.org
[m]
Stéphane Philippart: it's open :)
kuro
@adi10hero:matrix.org
[m]

Talk at DevOps world was live some time back, got some nice questions and suggestions in the QnA... so I thought I will share here..

Q. Does this plugin support generic VERSION file which maintains the semver? We adopted that to keep a single source of truth for version info that is used by Jenkinsfile, makefile, git-tags etc Thanks! ( @SohamJ asked this)

  • I feel this can be done, maybe another optional parameter? Thoughts?Stéphane Philippart , @garethjevans
7 replies
Gareth Evans
@garethjevans
@adi10hero:matrix.org i like the idea of a generic VERSION file, would make it usable for anything weve not thought about
kuro
@adi10hero:matrix.org
[m]
Is there a preferred contributing.md format/template used in jenkins? (I saw different styles in various projects but would like to confirm)
If there isn't then I think this looks good (jenkinsci/conventional-commits-plugin#121) for the conventional commits plugin
1 reply
Stéphane Philippart
@wildagsx:matrix.org
[m]
kuroto have o contribution page for Hacktoberfest I think we can merge
I just ask to the committer to add a link in the README file and link the generic CONTRIBUTING
kuro
@adi10hero:matrix.org
[m]
As of now, Stéphane Philippart , when there's an ambiguity, the latest version is taken intro consideration i.e max(tag, config file) so can we do the same with version file?
Stéphane Philippart
@wildagsx:matrix.org
[m]
OK so we are ok for git tag > version > config file ?
1 reply
Stéphane Philippart
@wildagsx:matrix.org
[m]
I update the issue with this information
Stéphane Philippart
@wildagsx:matrix.org
[m]
Sorry to ask again this question (I don't think I got an answer, sorry if i already had it ) but I don't understand the role of startTag and outputFormat ? @garethjevans (or anybody 😉) can you explain me ? I'm coding the currentVersion step and it will be help me 😉
olblak
@olblak:matrix.org
[m]
Stéphane Philippart: Unfortunately I can't really help, maybe @MarkEWaite does?
Stéphane Philippart
@wildagsx:matrix.org
[m]
if there anybody to review the PR #144 before I'll merge it don't hesitate ! 😉