Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Alex Earl
    @slide
    Oleg Nenashev
    @oleg-nenashev
    :+1: will we need to patch all other images?
    Alex Earl
    @slide
    No, I think I had added that to my PR's for Windows changes already, but let me check
    Yes, the ssh-agent and inbound-agent have the tag stuff already
    Oleg Nenashev
    @oleg-nenashev
    Nice, thanks!
    So... 4.3-4 then? :)
    Alex Earl
    @slide
    Sure :)
    You want me to merge that PR?
    Oleg Nenashev
    @oleg-nenashev
    @slide go for it, I will get to the laptop only in 2 hours or so. If you do the release for jenkins/agent, I will try to do the remaining work for downstream images afterwards
    Alex Earl
    @slide
    Ok, I'll try and follow the youtube video :)
    Oleg Nenashev
    @oleg-nenashev
    There is a lot of blah-blah-blah there. Just cut a release from GitHub, and let robots do the rest :)
    Once the release is done you may need to manually launch the repo scan and then to trigger the tag build for Windows @slide
    Alex Earl
    @slide
    oh, that's a bummer, can't we have that done automatically?
    Shouldn't release drafter pick up my changes automatically and create notes in the unreleased version?
    Tim Jacomb
    @timja
    i assume trusted isn't reachable from the internet
    Alex Earl
    @slide
    not directly, no
    Alex Earl
    @slide
    ok, we'll see if I got the release right...
    Oleg Nenashev
    @oleg-nenashev
    Edited the changelog a bit, but should be fine overall
    @slide while we are here, what do we do with the SSH images? jenkins/ssh-agent or jenkins/ssh-build-agent?
    If we take the first name, I will need to drop Windows builds as well there
    ... tags
    Alex Earl
    @slide
    I'm fine either way, I can make the Windows changes if needed
    Tim Jacomb
    @timja
    RE: release drafter, it will but the SaaS app is slow sometimes, github action ones are instant though
    Alex Earl
    @slide
    ah
    Oleg Nenashev
    @oleg-nenashev
    yes, we might switch all major repos later
    @slide I will proceed with ssh-agent. I have the IDE open, so I will do it quickly
    Alex Earl
    @slide
    :+1:
    Alex Earl
    @slide
    tags should be pushed for the windows stuff on dockerhub for jenkins/agent
    Oleg Nenashev
    @oleg-nenashev
    cool
    verifying tags and then updating my PR for inbound agents
    Alex Earl
    @slide
    woot!
    Oleg Nenashev
    @oleg-nenashev
    Just a sec, I am calculating votes in the feedback
    @slide This is what we got actually
    • "ssh-agent" - (Tim, Jesse - in PR, Alex)
    • "ssh-build-agent" - (Daniel, Mark, Oleg, Tim - in PR, Alex - in PR)
    • "sshd-agent" - (Ivan, Mark, Gavin)
    Tim Jacomb
    @timja
    #1 pref for me is ssh-agent :)
    but just needs to be consistent
    Alex Earl
    @slide
    agreed
    I think sshd-agent seems a bit weird and ssh-build-agent doesn't match with the other docker images
    Tim Jacomb
    @timja
    ssh is ssh daemon
    which it isn't
    Alex Earl
    @slide
    I don't think ssh-agent conflicts with the plugin since it's a docker image
    and the repos are different regardless
    Oleg Nenashev
    @oleg-nenashev
    the problem was rather with an ssh-agent CLI tool. But again, not a big deal for a Docker image
    Alex Earl
    @slide
    yeah, that's true
    Oleg Nenashev
    @oleg-nenashev
    I have never been using these SSH images FWIW. Not sure why I should really care about the renaming
    Alex Earl
    @slide
    I use them
    they work really well
    Oleg Nenashev
    @oleg-nenashev
    So you make the final decision then :)
    Alex Earl
    @slide
    ssh-agent works for me