by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Alex Earl
    @slide
    I use them
    they work really well
    Oleg Nenashev
    @oleg-nenashev
    So you make the final decision then :)
    Alex Earl
    @slide
    ssh-agent works for me
    :D
    oleg-nenashev @oleg-nenashev summons @MarkEWaite
    Alex Earl
    @slide
    Mark definitely uses them too
    Oleg Nenashev
    @oleg-nenashev
    Mark is also a maintainer. I will get inbound agents over the line and then return back to this topic
    Mark Waite
    @MarkEWaite
    ssh-agent is fine with me. I understand the desire for consistency with other docker image names. Safe to assume that my world of eval $(ssh-agent) is not the usual world
    3 replies
    Oleg Nenashev
    @oleg-nenashev
    Uhm, teeests
    [2020-04-13T20:05:24.964Z] + make test
    [2020-04-13T20:05:24.964Z] Cloning into 'bats-core'...
    [2020-04-13T20:05:26.268Z] HEAD is now at c706d14 Bats 1.1.0
    [2020-04-13T20:05:29.544Z] 1..4
    [2020-04-13T20:05:29.544Z] ok 1 [8 alpine] build image
    [2020-04-13T20:05:32.819Z] ok 2 [8 alpine] image has installed jenkins-agent in PATH
    [2020-04-13T20:06:07.169Z] ok 3 [8 alpine] image starts jenkins-agent correctly (slow test)
    [2020-04-13T20:06:07.169Z] not ok 4 [8 alpine] use build args correctly
    [2020-04-13T20:06:07.169Z] # (in test file tests/tests.bats, line 94)
    [2020-04-13T20:06:07.169Z] #   `docker build \' failed
    [2020-04-13T20:06:07.169Z] # Sending build context to Docker daemon  8.704kB
    [2020-04-13T20:06:07.169Z] # Step 1/10 : ARG version=4.3-4-alpine
    [2020-04-13T20:06:07.169Z] # Step 2/10 : FROM jenkins/agent:$version
    [2020-04-13T20:06:07.169Z] # manifest for jenkins/agent:3.36-1-alpine not found: manifest unknown: manifest unknown
    [2020-04-13T20:06:07.169Z] Makefile:31: recipe for target 'test-alpine' failed
    [2020-04-13T20:06:07.169Z] make: *** [test-alpine] Error 1
    Alex Earl
    @slide
    doh
    Oleg Nenashev
    @oleg-nenashev
    Well, at least they work
    pushed the fix
    Alex Earl
    @slide
    I like to back out changes after adding a test and make sure my tests actually catch the issue, so there you go :)
    Oleg Nenashev
    @oleg-nenashev
    @slide @timja w.r.t https://github.com/jenkinsci/docker-ssh-agent/releases , should we keep the versioning scheme with v, or should I switch it to semver without prefixes for the new repo?
    I would vote for the latter one
    Tim Jacomb
    @timja
    i would remove v, it's easier for scripts if you're getting the release from the tagname
    Alex Earl
    @slide
    Yes, I agree
    Oleg Nenashev
    @oleg-nenashev
    OK, will do
    @slide FYI https://github.com/jenkinsci/docker-inbound-agent tries to publish from ci.jenkins.io as well. I;d guess the same will apply to the SSH one
    Alex Earl
    @slide
    It should be publishing to jenkins4eval when running on ci.j.io
    14:24:38 The push refers to repository [docker.io/jenkins4eval/inbound-agent]
    Oleg Nenashev
    @oleg-nenashev
    oops
    I will create repos
    You already did it for the inbound agent @slide :)
    Alex Earl
    @slide
    ssh-agent should already be there
    Oleg Nenashev
    @oleg-nenashev
    I will cut the ssh-agent release. Tested the Linux image locally, looks good
    Alex Earl
    @slide
    nice!
    Oleg Nenashev
    @oleg-nenashev
    Oleg Nenashev
    @oleg-nenashev
    Tag build is running on /job/Containers/job/Windows/job/docker/job/docker-ssh-agent/view/tags/job/2.0.0/1/console
    Alex Earl
    @slide
    did you publish the tag on docker-inbound-agent?
    Oleg Nenashev
    @oleg-nenashev
    Not yet
    Alex Earl
    @slide
    k
    do you want me to, or are you waiting for something?
    Oleg Nenashev
    @oleg-nenashev
    Nope, I am doing it now
    Was just cleaning up minor bits
    Alex Earl
    @slide
    cool
    Oleg Nenashev
    @oleg-nenashev
    Both Linux and Windows containers are OKish
    Alex Earl
    @slide
    ish?
    Oleg Nenashev
    @oleg-nenashev
    clicking the ship-it buttons
    ish because I just did a smoke test
    I do not anticipate many problems until we announce the new images FTR
    So I am more or less relaxed
    Alex Earl
    @slide
    Yeah, agreed :)
    Tag build: /job/Containers/job/Windows/job/docker/job/docker-inbound-agent/view/tags/job/4.3-2/
    Alex Earl
    @slide
    can we clean up the branches after all the tags are successfully pushed? :)
    Oleg Nenashev
    @oleg-nenashev
    Done, you should not need to wait for builds