by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Oleg Nenashev
    @oleg-nenashev
    pushed the fix
    Alex Earl
    @slide
    I like to back out changes after adding a test and make sure my tests actually catch the issue, so there you go :)
    Oleg Nenashev
    @oleg-nenashev
    @slide @timja w.r.t https://github.com/jenkinsci/docker-ssh-agent/releases , should we keep the versioning scheme with v, or should I switch it to semver without prefixes for the new repo?
    I would vote for the latter one
    Tim Jacomb
    @timja
    i would remove v, it's easier for scripts if you're getting the release from the tagname
    Alex Earl
    @slide
    Yes, I agree
    Oleg Nenashev
    @oleg-nenashev
    OK, will do
    @slide FYI https://github.com/jenkinsci/docker-inbound-agent tries to publish from ci.jenkins.io as well. I;d guess the same will apply to the SSH one
    Alex Earl
    @slide
    It should be publishing to jenkins4eval when running on ci.j.io
    14:24:38 The push refers to repository [docker.io/jenkins4eval/inbound-agent]
    Oleg Nenashev
    @oleg-nenashev
    oops
    I will create repos
    You already did it for the inbound agent @slide :)
    Alex Earl
    @slide
    ssh-agent should already be there
    Oleg Nenashev
    @oleg-nenashev
    I will cut the ssh-agent release. Tested the Linux image locally, looks good
    Alex Earl
    @slide
    nice!
    Oleg Nenashev
    @oleg-nenashev
    Oleg Nenashev
    @oleg-nenashev
    Tag build is running on /job/Containers/job/Windows/job/docker/job/docker-ssh-agent/view/tags/job/2.0.0/1/console
    Alex Earl
    @slide
    did you publish the tag on docker-inbound-agent?
    Oleg Nenashev
    @oleg-nenashev
    Not yet
    Alex Earl
    @slide
    k
    do you want me to, or are you waiting for something?
    Oleg Nenashev
    @oleg-nenashev
    Nope, I am doing it now
    Was just cleaning up minor bits
    Alex Earl
    @slide
    cool
    Oleg Nenashev
    @oleg-nenashev
    Both Linux and Windows containers are OKish
    Alex Earl
    @slide
    ish?
    Oleg Nenashev
    @oleg-nenashev
    clicking the ship-it buttons
    ish because I just did a smoke test
    I do not anticipate many problems until we announce the new images FTR
    So I am more or less relaxed
    Alex Earl
    @slide
    Yeah, agreed :)
    Tag build: /job/Containers/job/Windows/job/docker/job/docker-inbound-agent/view/tags/job/4.3-2/
    Alex Earl
    @slide
    can we clean up the branches after all the tags are successfully pushed? :)
    Oleg Nenashev
    @oleg-nenashev
    Done, you should not need to wait for builds
    I am keeping jdk11 and alpine branches for historical reasons (before DockerHub added support of custom Dockerfile names), but the rest is cleaned
    Alex Earl
    @slide
    thanks :)
    Oleg Nenashev
    @oleg-nenashev
    @slide Looks like ssh-agent doest not publish releases for Windows after all
    Alex Earl
    @slide
    let me look
    Oleg Nenashev
    @oleg-nenashev
    For this image we use another format, and hence the block is just skipped
    Alex Earl
    @slide
    ok, I can fix that up
    I should have thought of that...
    Oleg Nenashev
    @oleg-nenashev
    nws
    Also, I made a mistake in https://hub.docker.com/r/jenkins/inbound-agent DockerHub configuration. We might need a 4.3-3 tag to retrigger publishing
    Better to verify /job/Containers/job/Windows/job/docker/job/docker-inbound-agent/view/tags/job/4.3-2/1/console first, of course
    Alex Earl
    @slide
    it's at the testing stage right now