by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Sule Olanrewaju
    @LarrySul
    Yes help with the git commands
    Gavin Mogan
    @halkeye
    image.png
    Mark Waite
    @MarkEWaite
    First step is to bring in the latest changes from the upstream master branch. Since you have hub installed, you should be able to use the commands:
    • hub sync
    • git checkout slave-master-access
    • git merge master
    Gavin Mogan
    @halkeye
    progress!
    Mark Waite
    @MarkEWaite
    Nice @halkeye ! Tabs for the plugin site?
    @halkeye is that reading from GitHub releases?
    Gavin Mogan
    @halkeye
    yea
    and yea
    https://dev.gavinmogan.com/git/ (i'll push a demo to netlify in a bit)
    Mark Waite
    @MarkEWaite
    Another compelling reason for plugins to use release drafter. Not only easier for the developer but now easier for Jenkins users and Jenkins administrators
    @LarrySul let me know when you've completed that step, then we can review how to move the file from one location to another
    Sule Olanrewaju
    @LarrySul
    Sorry for the delay my network is down for a moment
    Mark Waite
    @MarkEWaite
    No problem. Since git is a distributed version control system, we can skip that remote sync and let you do it later. If you'd like to interrupt the hub sync, then we can perform the move locally (no network access required).
    Sule Olanrewaju
    @LarrySul
    Ok
    Gavin Mogan
    @halkeye
    actually i'll deploy during this game so i don't need my server running
    i need a lot of cleanup on the api code, but it looks sweet
    Mark Waite
    @MarkEWaite
    @LarrySul We can find the destination directory for the page by navigating the Jenkins.io site to find https://www.jenkins.io/doc/developer/guides/ . That page is the top level table of contents for the developer guide. At the bottom left of that page is a link "Improve this page". When you click "Improve this page", it opens https://github.com/jenkins-infra/jenkins.io/edit/master/content//doc/developer/guides.html.haml . That's the pointer we need to the general area for those pages
    Sule Olanrewaju
    @LarrySul
    Ok noted
    Mark Waite
    @MarkEWaite
    Opening one of the security pages with the same technique (for instance, "Preventing Cross-Site Scripting in Jelly views") shows that the security pages are in https://github.com/jenkins-infra/jenkins.io/edit/master/content//doc/developer/security/
    We need to move the page content/doc/book/using/agent-master-access-control.adoc to content/doc/developer/security/
    The command to do that move is:
    • git mv content/doc/book/using/agent-master-access-control.adoc content/doc/developer/security/
    Mark Waite
    @MarkEWaite

    We also need to "undo" the change that was made to the chapter contents of the "Using Jenkins" chapter. The git command for that is:

    • git checkout master -- content/doc/book/using/_chapter.yml

    That is a useful command in general, since it allows you to copy the contents of a specific file (in this case content/doc/book/using/_chapter.yml) from another branch into this branch. That command makes the file content/doc/book/using/_chapter.yml on the current branch have the same contents as the file on the master branch.

    @LarrySul once you completed those steps, you can commit the changes, then proceed to reduce the contents of content/doc/developer/security/agent-master-access-control.adoc to be only the content that is relevant to developers.
    Sule Olanrewaju
    @LarrySul
    Moved
    Mark Waite
    @MarkEWaite
    @halkeye That is great! Are you at the point where you want to allow others to see it in prototype or does it need the API refinements first?
    @LarrySul I have some work that I need to do on the git plugin. I'm going to leave the chat system for a while so that I can focus on the git plugin.
    Sule Olanrewaju
    @LarrySul
    @MarkEWaite alright
    Sule Olanrewaju
    @LarrySul

    The command whitelisting section is already included in https://www.jenkins.io/doc/book/managing/security/#customizing-access .

    Since it has already been included I guess it's safe to remove the section right ?

    Mark Waite
    @MarkEWaite
    @LarrySul anything that is already on an existing page should be removed from the pull request
    Gavin Mogan
    @halkeye
    Sule Olanrewaju
    @LarrySul
    @MarkEWaite how do I make this link point back to jenkins.io , currently goes to wiki
    See http://jenkins-ci.org/security-144 for more details
    Mark Waite
    @MarkEWaite
    @LarrySul we'll apply a redirect on the wiki as is described in the step of wiki migration section at https://github.com/jenkins-infra/jenkins.io/blob/master/CONTRIBUTING.adoc#moving-documentation-from-jenkins-wiki . Look at step viii.
    Sule Olanrewaju
    @LarrySul
    Ok
    Mark Waite
    @MarkEWaite
    @LarrySul we'll also use this as the excuse to learn more about www.jenkins.io content redirects. I understand that they exist, but I've not found any documentation that describes how to create them, maintain them, or test them
    If you open https://www.jenkins.io/redirect/security-144 , you'll see a page appear briefly that then redirects to a different page. I believe that redirect is defined by content/redirect/security-144.adoc, but my attempt to define a new content redirect did not work as I had hoped it would. I will need to ask someone with more experience
    Sule Olanrewaju
    @LarrySul
    @MarkEWaite I have been able to make some file modifications as discussed and initiated a PR for review now
    Gavin Mogan
    @halkeye
    I've also updated the relative times for plugin and releases to https://www.npmjs.com/package/react-time-ago so it has a tooltip for the full date
    Tim Jacomb
    @timja
    Nice work @halkeye, I think the container is taking up too much room on mobile on the releases tab
    It would be cool if the GitHub usernames could be linked as well
    And pull request / issue numbers
    Not all emojis are working :( :boom: isn’t
    Gavin Mogan
    @halkeye
    Yea need a parser that matches GitHub. I might see what else is out there.
    And I guess i can't upload via mobile but works for me :)
    matrixbot
    @matrixbot
    halkeye (@halkeye:g4v.dev) posted an image: Screenshot_20200530-234311.png
    Gavin Mogan
    @halkeye
    Yea
    Mark Waite
    @MarkEWaite
    @halkeye the tabs site looks great! Would love to have issues in the view, just as you've done, but will that be a large addition to site generation time for the plugins site?
    matrixbot
    @matrixbot
    halkeye (@halkeye:g4v.dev) The two extra tabs right now are runtime and on demand so no impact to build tume