Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Gavin Mogan
    @halkeye
    some of the main.css css modules stuff is still loading in the wrong order, but I got the top level search box rendering - https://jenkins-plugins.g4v.dev/
    do you all think /categories/$category and /search are safe urls? or should I prefix them with something?
    Tim Jacomb
    @timja
    what are you worried about?
    Gavin Mogan
    @halkeye
    A plugin having the same name
    I could see something being called search-plugin or categories-plugin
    Tim Jacomb
    @timja
    shouldn't plugin be the one prefixed then?
    Gavin Mogan
    @halkeye
    Timja: yes but that would break every existing link
    Tim Jacomb
    @timja
    :thumbsup:
    YAGNI maybe ?
    if it isn't a problem now dw about it?
    Gavin Mogan
    @halkeye
    well right now search and categories don't have urls, they are all browser side on the front page
    Tim Jacomb
    @timja
    hmm, /ui/search?
    or /api/search
    Gavin Mogan
    @halkeye
    yea, ui-plugin seems very unlikely
    Gavin Mogan
    @halkeye
    oh my, everything in main.css seems messy, overriding eachother
    Tim Jacomb
    @timja
    not surprised
    Gavin Mogan
    @halkeye
    gonna move things (search) to flexbox, which should also help mobile. Also use react emotion library so all the css are with each component so its easier to maintain, the css is all over the place
    Tim Jacomb
    @timja
    :thumbsup:
    Gavin Mogan
    @halkeye
    image.png
    defiantly making some progress
    Tim Jacomb
    @timja
    :D
    Gavin Mogan
    @halkeye
    https://github.com/jenkins-infra/plugin-site/blob/master/app/styles/Main.css#L261 <-- "postion" not "position", so if i fix it, is that bad or good? needs to actually run through tooling to catch these types of mistakes
    Tim Jacomb
    @timja
    lol
    does fix mean remove it?
    as its currently doing nothing?
    Gavin Mogan
    @halkeye
    I donno. I'll was intending to just switch over to gastby, but I've had to massage things because of the new data source. So now I'm pretty much rewriting the search page. So I'll probably toss a lot of the old CSS when I'm done
    Tim Jacomb
    @timja
    hehe, slack is the second highest plugin searched for on google to get to the plugin site
    highest is maven integration
    and slack is the most viewed page excluding the index
    Oleg Nenashev
    @oleg-nenashev
    Notably, Maven plugin docs migration has not been completed yet. There is a pending PR by @olamy from yesterday
    Gavin Mogan
    @halkeye
    Gavin Mogan
    @halkeye
    image.png
    so apparently we are adding + in the html, and in the css
    image.png
    image.png
    aww, gitter won't let me post a screenshot
    on the search results page
    Tim Jacomb
    @timja
    easier to hide rather than delete?
    Gavin Mogan
    @halkeye
    its one line of html
    so /shrug
    Zbynek Konecny
    @zbynek
    @halkeye Main gets included through JS (with obfuscated classnames), base directly. Why they both exist? No idea.
    Zbynek Konecny
    @zbynek
    Gavin Mogan
    @halkeye
    @zbynek infra irc channel or infra ticket
    Gavin Mogan
    @halkeye
    https://jenkins-plugins.g4v.dev/ui/search <3 its getting more and more mobile friendly
    Stefan Wolf
    @wolfs
    I just published a new version of the Gradle plugin, and now the plugin site is changing between "No documentation for this plugin could be found" and the documentation of the previous version.
    Any ideas what is going on there? The plugin documentation is in the readme on Github.
    Stefan Wolf
    @wolfs
    @oleg-nenashev Any ideas? :point_up:
    Stefan Wolf
    @wolfs
    Now the new version seems to be there. So it was only a matter of time?
    Oleg Nenashev
    @oleg-nenashev
    @wolfs I also noticed it today. I suspect it is somehow related to the Infra instabilities we have today. If the Update Center query fails, you may have a "no docs" warning for a while