It seems no major issues yet
which is awesome
@oleg-nenashev that is the plan, I went through https://www.jenkins.io/doc/developer/publishing/releasing/ , and only the last step is remaining.
It is perfectly fine if you have to drop early, I think it should be quick
whatever works
Waiting for checks to pass :P
Do i need to add this
-DignoreSnapshots=true ?
@oleg-nenashev I think I should remove the
version from the redis plugin POM?
Starting the meeting in 1 min at https://us04web.zoom.us/j/79229579437?pwd=cmI2RVdlSytZNUhSdEhWTHJzZm5UZz09. Agenda: https://docs.google.com/document/d/1_0lH_s5NpV860NjLmZT8cKd26Z4GrtXpgkBydDt103M/edit#
I can see redis-fingerprint-storage.hpi here : https://updates.jenkins.io/experimental/latest/
Would that mean it came through?
So I was thinking how fingerprint cleanup would work in a system with external storage configured, as well as some old fingerprints lying around on disk. In such case, we can either:
- Run the cleanup ONLY on external storage. Gradually some fingerprints would get migrated when used, but others would remain there for eternity.
- Run the fingerprint cleanup on both external and file system storage. But here, on the first run of fingerprint cleanup, the entire fingerprint base would get migrated in one go.
5 replies
Would love some thoughts and opinions :)
@oleg-nenashev @afalko @mikecirioli
According to me second option looks better
I was looking into dealing with passing a virtual file to a method which needs
java.io.File (think SaveableListener). I found https://stackoverflow.com/questions/4317035/how-to-convert-inputstream-to-virtual-file which suggests basically creating a temp file on disk. One interesting answer is https://stackoverflow.com/a/17595282/8461040 (first comment on this) which suggests using an Apache Commons VFS RAM file as a way to have an in memory file. But it seems like it cannot be converted to a java.io.File as mentioned here : https://stackoverflow.com/questions/58140765/use-apache-commons-vfs-ram-file-to-avoid-using-file-system-with-api-requiring-a
I am not sure if creating a temporary file on disk is the right answer because that creates dependence on disk @oleg-nenashev @afalko @mikecirioli
@stellargo I doubt it is a right answer for 'SaveableListener'. We used temporary files to retain binary compatibility for Artifact and Log APIs, but in those cases this was a temporary solution. File-based APIs were deprecated. For SaveableListener such approach may work as well, but we never know whether the file would be modified by the listener. So such workaround may require you to also check tmo files, and propagate changes to the storage. It is doable, but a lot of overhead. IMHO it is better to start designing for non-File saveable objects
1 reply
I can take this topic for the next coding phase, IMHO it makes sense to design the new API together
VFS basically requires switching to another API as well. Path API from Java 7+ is more friendly to cirtualization, but also not ideal
Meanwhile, the blog is published now: https://www.jenkins.io/blog/2020/06/27/external-fingerprint-storage/
2 replies
LinkedIn post is out: https://www.linkedin.com/feed/update/urn:li:activity:6683312813370331136
We will be starting the meeting at https://us04web.zoom.us/j/79625174132?pwd=THJGaGMwaFBCLzVnc3p3Y1Bwb3Zwdz09 in about 9 minutes. The agenda for the meeting is: https://docs.google.com/document/d/1_0lH_s5NpV860NjLmZT8cKd26Z4GrtXpgkBydDt103M/edit#
@oleg-nenashev as you would suggest I am fine with. I had incorporated the suggestions you had shared with me in the document after the cloud native sig demo. Rest will be pretty much the same from my side because that demo marked everything we did in phase 1. If you feel that was fine, then maybe we don't need a dry run
I just went down the path of history of Redis after reading this :P
Also jenkinsci/redis-fingerprint-storage-plugin#23 (but this depends on 4817 to actually get merged)