by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 09 18:38
    stellargo review_requested #57
  • Aug 09 18:38
    stellargo review_requested #57
  • Aug 09 18:38
    stellargo review_requested #56
  • Aug 09 18:36
    stellargo review_requested #14
  • Aug 09 18:36
    stellargo review_requested #15
  • Aug 09 18:24
    stellargo synchronize #56
  • Aug 09 18:24
    stellargo synchronize #56
  • Aug 09 18:24
    stellargo synchronize #56
  • Aug 09 18:22
    stellargo synchronize #16
  • Aug 09 18:15
    stellargo review_requested #16
  • Aug 09 18:14
    stellargo synchronize #16
  • Aug 09 17:40
    stellargo edited #16
  • Aug 09 17:39
    stellargo review_requested #16
  • Aug 09 17:39
    stellargo opened #16
  • Aug 09 14:24
    stellargo unlabeled #12
  • Aug 09 14:19
    stellargo labeled #57
  • Aug 09 14:19
    stellargo reopened #56
  • Aug 09 14:17
    stellargo closed #56
  • Aug 09 14:16
    stellargo review_requested #57
  • Aug 09 14:16
    stellargo opened #57
michael cirioli
@mikecirioli
i will be late, on another call that is running long
stellargo
@stellargo
No worries @mikecirioli :)
stellargo
@stellargo
One of my personal goals: see my name in this list https://github.com/jenkinsci/jenkins/graphs/contributors :P I think 3 more PRs to go hehe
Oleg Nenashev
@oleg-nenashev
@stellargo @afalko @mikecirioli Hi all. Just a heads-up, I will be traveling next Monday...Wednesday. I will be checking my inbox on evenings, but I won;t be available for meetings including the GSoC sync-up
stellargo
@stellargo
@oleg-nenashev No worries :)
Have a safe travel!
stellargo
@stellargo
I have been working on fingerprint cleanup at jenkinsci/jenkins#4817. WIP, so NOT under review :)
stellargo
@stellargo
Building the reference implementation for fingerprint cleanup at jenkinsci/redis-fingerprint-storage-plugin#23
stellargo
@stellargo
Does it make sense to instead of having a fingerprintCleanupThread which the plugins can implement as discussed in jenkinsci/jep#291, we implement a method which can give us a set of fingerprints and we clean them up at Jenkins core side. Why i say this? Because ultimately the cleanup has to be done at Jenkins core side. @oleg-nenashev @afalko @mikecirioli
I can't think of a case where the plugin would decide to implement this cleanup in a totally different manner
Oleg Nenashev
@oleg-nenashev
@stellargo Jenkins Core is released FYI
stellargo
@stellargo
Yes I saw, I have been monitoring the page which shows how many issues reported
It seems no major issues yet
which is awesome
stellargo
@stellargo
@oleg-nenashev @afalko @mikecirioli requesting reviews for jenkinsci/jenkins#4817
stellargo
@stellargo
Oleg Nenashev
@oleg-nenashev
@stellargo So you want to try the release today at the meeting, right? Just realized that I will have to drop early due to the Jenkins Online Meetup
stellargo
@stellargo
@oleg-nenashev that is the plan, I went through https://www.jenkins.io/doc/developer/publishing/releasing/ , and only the last step is remaining.
It is perfectly fine if you have to drop early, I think it should be quick
stellargo
@stellargo
stellargo
@stellargo
@oleg-nenashev IIUC mvn release:prepare release:perform only this remains. Will do it during the meeting :)
Oleg Nenashev
@oleg-nenashev
Or before
whatever works
stellargo
@stellargo
Can do! Just gotta rebase 2 PRs, then getting right to it :) Thank you
Waiting for checks to pass :P
stellargo
@stellargo
There are still some remaining snapshot dependencies.
: Do you want to resolve them now? (yes/no)
After no:
Can't release project due to non released dependencies
Do i need to add this -DignoreSnapshots=true ?
@oleg-nenashev I think I should remove the version from the redis plugin POM?
Oleg Nenashev
@oleg-nenashev
@stellargo looks like the release did not come through. Any help needed?
stellargo
@stellargo
@oleg-nenashev I got success from my end, but it was not being reflected on update center. I thought it may take some time to reflect. Ill check again
I can see redis-fingerprint-storage.hpi here : https://updates.jenkins.io/experimental/latest/
Would that mean it came through?
Oleg Nenashev
@oleg-nenashev
@stellargo yes, it means that the release was successful :+1: I was just surprised to not see commits in the master branch. Maybe I missed them
stellargo
@stellargo
So I was thinking how fingerprint cleanup would work in a system with external storage configured, as well as some old fingerprints lying around on disk. In such case, we can either:
  • Run the cleanup ONLY on external storage. Gradually some fingerprints would get migrated when used, but others would remain there for eternity.
  • Run the fingerprint cleanup on both external and file system storage. But here, on the first run of fingerprint cleanup, the entire fingerprint base would get migrated in one go.
5 replies
Would love some thoughts and opinions :)
@oleg-nenashev @afalko @mikecirioli
According to me second option looks better
stellargo
@stellargo
I was looking into dealing with passing a virtual file to a method which needs java.io.File (think SaveableListener). I found https://stackoverflow.com/questions/4317035/how-to-convert-inputstream-to-virtual-file which suggests basically creating a temp file on disk. One interesting answer is https://stackoverflow.com/a/17595282/8461040 (first comment on this) which suggests using an Apache Commons VFS RAM file as a way to have an in memory file. But it seems like it cannot be converted to a java.io.File as mentioned here : https://stackoverflow.com/questions/58140765/use-apache-commons-vfs-ram-file-to-avoid-using-file-system-with-api-requiring-a
I am not sure if creating a temporary file on disk is the right answer because that creates dependence on disk @oleg-nenashev @afalko @mikecirioli
Oleg Nenashev
@oleg-nenashev
@stellargo I doubt it is a right answer for 'SaveableListener'. We used temporary files to retain binary compatibility for Artifact and Log APIs, but in those cases this was a temporary solution. File-based APIs were deprecated. For SaveableListener such approach may work as well, but we never know whether the file would be modified by the listener. So such workaround may require you to also check tmo files, and propagate changes to the storage. It is doable, but a lot of overhead. IMHO it is better to start designing for non-File saveable objects
1 reply
I can take this topic for the next coding phase, IMHO it makes sense to design the new API together
VFS basically requires switching to another API as well. Path API from Java 7+ is more friendly to cirtualization, but also not ideal
2 replies
stellargo
@stellargo
Up for review: jenkinsci/jenkins#4817
Oleg Nenashev
@oleg-nenashev
@stellargo Looks like there are still issues with opengraph