Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 30 2019 20:42
    timja commented #56
  • Jan 30 2019 20:32
    imaffe commented #56
  • Jan 30 2019 18:34
    imaffe commented #56
  • Jan 29 2019 11:58
    martinda commented #56
  • Jan 29 2019 07:07
    imaffe commented #56
  • Jan 28 2019 18:35
    imaffe synchronize #56
  • Jan 28 2019 14:28
  • Jan 26 2019 14:50
    martinda commented #56
  • Jan 26 2019 08:28
    imaffe commented #56
  • Jan 26 2019 08:20
    imaffe commented #56
  • Jan 22 2019 16:33
  • Jan 19 2019 17:48
    imaffe commented #56
  • Jan 19 2019 10:52
    oleg-nenashev commented #56
  • Jan 19 2019 04:42
    imaffe commented #56
  • Jan 19 2019 04:31
    imaffe synchronize #56
  • Jan 19 2019 03:38
    imaffe commented #56
  • Jan 19 2019 03:32
    imaffe commented #56
  • Jan 17 2019 07:20
    alexsomai closed #58
  • Jan 17 2019 06:32
    imaffe commented #51
  • Jan 17 2019 03:46
    imaffe synchronize #56
Alexandru Somai
@alexsomai
alright, let us know if that doesn't work well
affe
@imaffe
image.png
Alexandru Somai
@alexsomai
Regarding the PRs, I think we have to decide how it would be better to proceed. Here is my proposal: Create a new branch in EWM from master, and it could be named 2.0, or cloud-extension, or something like this. Then, Yufei, you could create all your PRs against this branch. When all the work is finished on the AWS - EFS support, only then do merge the entire cloud-extension branch into master. What do you guys think about this?
My concern is that everything that goes into master should be ready for release
affe
@imaffe
Yeah, just I don't have the permission to create a new branch maybe ?
That is a standard git workflow.
+1
Alexandru Somai
@alexsomai
I can create the branch. Any preference for the name? cloud-features?
Martin d'Anjou
@martinda
+1 on branch. Maybe cloud-aws-efs?
Alexandru Somai
@alexsomai
alright, so I've created this branch cloud-aws-efs https://github.com/jenkinsci/external-workspace-manager-plugin/tree/cloud-aws-efs, and Yufei, you can create your PRs against this one. I'll find some time tomorrow to look over what you've raised so far, even if it's work in progress
affe
@imaffe
@alexsomai , Hi Alex, how did you managed the UI related technique, like how to use jenkins' jelly files ? Now I'm diving into the global configuration and see what UI do I need, then go that source code to get some hints,.
Alexandru Somai
@alexsomai
@imaffe here is some documentation that might help you https://wiki.jenkins.io/display/JENKINS/Basic+guide+to+Jelly+usage+in+Jenkins
basically, you need to place the config.jelly file under the same directory structure as where it's placed the Describable implementation
and some more documentation
affe
@imaffe
Well, I under part of the config.jelly, but there are more advanced topics like <f:repeatableHeteroProperty />
and what I also did was to look at other plugins
affe
@imaffe
Wow, thanks, that is a lot for me to discover.
Alexandru Somai
@alexsomai
see how they've used and implemented somethings
yep, hope it helps
affe
@imaffe
Well, some times I found a groovy example, but I don't know how to transfer that to jelly
Alexandru Somai
@alexsomai
and, if you search for some jelly properties in the github jenkinsci, like this https://github.com/search?q=org%3Ajenkinsci+f%3ArepeatableHeteroProperty&type=Code
you can find many usages
oh, I don't think I did anything in Groovy (UI related)
affe
@imaffe
Yeah, in other plugins.
But nvm, you taught me a way to find the code examples in Github, thanks !
Alexandru Somai
@alexsomai
also, probably you know about this one https://wiki.jenkins.io/display/JENKINS/Extend+Jenkins, more like a generic Jenkins plugin tutorial
cool, let me know if anything :+1:
affe
@imaffe
For example , for a repeatableHeteroProperty, its corresponding groovy block would be like : f.hetero_list(name:"cloud", hasHeader:true, descriptors:Cloud.all(), items:app.clouds, addCaption:_("Add a new cloud"), deleteCaption:_("Delete cloud")), but I don't know if fields like descriptors:Cloud.all(), items:app.clouds are needed in jelly. Can I have a more detailed description about a certain property ? I found one documentation on https://reports.jenkins.io/core-taglib/jelly-taglib-ref.html but it didn't say in detail
affe
@imaffe
Oh, looks like I succeeded creating the webUI ....
Congrats to myself !
Oleg Nenashev
@oleg-nenashev
Yeah, Jelly and Groovy UIs are quite challenging in the beginning
@imaffe My recommendation would be to actually use Jelly for user-facing UIs which are being accessed often. According to old benchmarks we had, Jelly UI renderingis almost 10 times faster than Groovy
affe
@imaffe
Yeah, actually I'm using Jelly, because Alex did so.
image.png
It is now working :)
@martinda @alexsomai @hynespm I'm likely to have one day off tomorrow, got some friends coming, but I will still try to push some code tomorrow. Also, tried to finish the UI part and make the code style 'submitable' this weekend :) Thanks !
Alexandru Somai
@alexsomai
nice Yufei, well done! :)
regarding the day off, IMO I'm alright with it. Not very sure about this, but I don't think it's required to work every day the same amount of hours. Some days you can work a bit more hours, other days a bit less, and in the long run, the hours will balance out.
affe
@imaffe
@alexsomai @martinda Got a question : here in : https://github.com/jenkinsci/external-workspace-manager-plugin/blob/08073fc5c2878633f5129b6d583b83c5263274a7/src/main/java/org/jenkinsci/plugins/ewm/definitions/Disk.java#L104 , we never defined a definitions_Disk_DisplayName() method but it is automatically generated, and now I have want to have adefinitions_AwsEfsDisk_DisplayName() method, what should I do? Thanks
affe
@imaffe
@alexsomai Hi Alex, can you still remember the difference between a masterMountPoint and a nodeMountPoint ? I noticed in the code, that only nodeMountPoint was used, so what is the usage of masterMountPoint ?
affe
@imaffe
And, we will have a meeting on Sunday right ?
Well, is it masterMountPoint is used for jenkins master only, and nodeMountPoint is for slaves. And because user might want to define different path for slave and master, and that is why we have two mount point ?
Alexandru Somai
@alexsomai
@imaffe regarding your first question, isn't the display name method generated automatically when you run mvn clean install?
And about master and slave mount point
That was the idea, that you can define different paths for the mount points on the jenkins master and on slaves
And mainly master mount point is used to be able browse the workspace in the web ui. I think it's used is some jekyll files, if I recall correctly
affe
@imaffe
Thanks ! that is cool. Now I'm able to print the configured entries in the console:) Tomorrow gonna figure out how and where to insert code in exwsExecution.
image.png
Alexandru Somai
@alexsomai
Looks good!
Martin d'Anjou
@martinda
If there is a meeting today, I cannot make it, but next Sunday yes.