Regarding the PRs, I think we have to decide how it would be better to proceed. Here is my proposal: Create a new branch in EWM from
master, and it could be named 2.0, or cloud-extension, or something like this. Then, Yufei, you could create all your PRs against this branch. When all the work is finished on the AWS - EFS support, only then do merge the entire cloud-extension branch into master. What do you guys think about this?
My concern is that everything that goes into
master should be ready for release
That is a standard git workflow.
+1
alright, so I've created this branch
cloud-aws-efs https://github.com/jenkinsci/external-workspace-manager-plugin/tree/cloud-aws-efs, and Yufei, you can create your PRs against this one. I'll find some time tomorrow to look over what you've raised so far, even if it's work in progress
@imaffe here is some documentation that might help you https://wiki.jenkins.io/display/JENKINS/Basic+guide+to+Jelly+usage+in+Jenkins
basically, you need to place the config.jelly file under the same directory structure as where it's placed the
Describable implementation
and some more documentation
and what I also did was to look at other plugins
yep, hope it helps
and, if you search for some jelly properties in the github jenkinsci, like this https://github.com/search?q=org%3Ajenkinsci+f%3ArepeatableHeteroProperty&type=Code
you can find many usages
oh, I don't think I did anything in Groovy (UI related)
But nvm, you taught me a way to find the code examples in Github, thanks !
also, probably you know about this one https://wiki.jenkins.io/display/JENKINS/Extend+Jenkins, more like a generic Jenkins plugin tutorial
cool, let me know if anything :+1:
For example , for a repeatableHeteroProperty, its corresponding groovy block would be like :
f.hetero_list(name:"cloud", hasHeader:true, descriptors:Cloud.all(), items:app.clouds,
addCaption:_("Add a new cloud"), deleteCaption:_("Delete cloud")), but I don't know if fields like descriptors:Cloud.all(), items:app.clouds are needed in jelly. Can I have a more detailed description about a certain property ? I found one documentation on https://reports.jenkins.io/core-taglib/jelly-taglib-ref.html but it didn't say in detail
Congrats to myself !
@imaffe My recommendation would be to actually use Jelly for user-facing UIs which are being accessed often. According to old benchmarks we had, Jelly UI renderingis almost 10 times faster than Groovy
It is now working :)
@martinda @alexsomai @hynespm I'm likely to have one day off tomorrow, got some friends coming, but I will still try to push some code tomorrow. Also, tried to finish the UI part and make the code style 'submitable' this weekend :) Thanks !
nice Yufei, well done! :)
regarding the day off, IMO I'm alright with it. Not very sure about this, but I don't think it's required to work every day the same amount of hours. Some days you can work a bit more hours, other days a bit less, and in the long run, the hours will balance out.
regarding the day off, IMO I'm alright with it. Not very sure about this, but I don't think it's required to work every day the same amount of hours. Some days you can work a bit more hours, other days a bit less, and in the long run, the hours will balance out.
@alexsomai @martinda Got a question : here in : https://github.com/jenkinsci/external-workspace-manager-plugin/blob/08073fc5c2878633f5129b6d583b83c5263274a7/src/main/java/org/jenkinsci/plugins/ewm/definitions/Disk.java#L104 , we never defined a
definitions_Disk_DisplayName() method but it is automatically generated, and now I have want to have adefinitions_AwsEfsDisk_DisplayName() method, what should I do? Thanks
Well, is it masterMountPoint is used for jenkins master only, and nodeMountPoint is for slaves. And because user might want to define different path for slave and master, and that is why we have two mount point ?
And about master and slave mount point
That was the idea, that you can define different paths for the mount points on the jenkins master and on slaves
And mainly master mount point is used to be able browse the workspace in the web ui. I think it's used is some jekyll files, if I recall correctly
